From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH] docs: replace 'Edit on GitLab' with 'View page source'
Date: Mon, 9 Dec 2024 10:57:24 -0800 [thread overview]
Message-ID: <c87d5221-68eb-47c7-aa42-4bfcb041d9bf@linaro.org> (raw)
In-Reply-To: <20241209163506.2089961-1-berrange@redhat.com>
On 12/9/24 08:35, Daniel P. Berrangé wrote:
> QEMU takes contributions via the mailing list, so while you can edit a
> file on gitlab and then switch to the terminal to send a patch, the
> wording 'Edit on GitLab' strongly suggests we take merge requests.
>
> Switching back to "View page source" is a more agnostic term that does
> not imply a particular contribution approach, that we had used in QEMU
> before:
>
> commit 73e6aec6522e1edd63f631c52577b49a39bc234f
> Author: Marc-André Lureau <marcandre.lureau@redhat.com>
> Date: Tue Mar 23 15:53:28 2021 +0400
>
> sphinx: adopt kernel readthedoc theme
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> docs/conf.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/conf.py b/docs/conf.py
> index c11a6ead8a..164a8ee8b2 100644
> --- a/docs/conf.py
> +++ b/docs/conf.py
> @@ -186,7 +186,7 @@
> ]
>
> html_context = {
> - "display_gitlab": True,
> + "source_url_prefix": "https://gitlab.com/qemu-project/qemu/-/blob/master/docs/",
> "gitlab_user": "qemu-project",
> "gitlab_repo": "qemu",
> "gitlab_version": "master",
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
prev parent reply other threads:[~2024-12-09 18:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 16:35 [PATCH] docs: replace 'Edit on GitLab' with 'View page source' Daniel P. Berrangé
2024-12-09 16:38 ` Philippe Mathieu-Daudé
2024-12-09 16:41 ` Daniel P. Berrangé
2024-12-09 18:57 ` Pierrick Bouvier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c87d5221-68eb-47c7-aa42-4bfcb041d9bf@linaro.org \
--to=pierrick.bouvier@linaro.org \
--cc=berrange@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).