From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Sean Wei <me@sean.taipei>, qemu-devel@nongnu.org
Cc: Christian Schoenebeck <qemu_oss@crudebyte.com>,
Greg Kurz <groug@kaod.org>
Subject: Re: [PATCH 2/2] hw/9pfs: move G_GNUC_PRINTF to header
Date: Mon, 16 Jun 2025 07:10:14 +0200 [thread overview]
Message-ID: <c892aff3-b77a-4131-b3c3-9c671cd18af4@linaro.org> (raw)
In-Reply-To: <20250613.qemu.9p.02@sean.taipei>
On 14/6/25 04:09, Sean Wei wrote:
> v9fs_path_sprintf() is annotated with G_GNUC_PRINTF(2, 3) in
> hw/9pfs/9p.c, but the prototype in hw/9pfs/9p.h is missing the
> attribute, so callers that include only the header do not get format
> checking.
>
> Move the annotation to the header and delete the duplicate in the
> source file. No behavior change.
>
> Signed-off-by: Sean Wei <me@sean.taipei>
> ---
> hw/9pfs/9p.c | 3 +--
> hw/9pfs/9p.h | 2 +-
> 2 files changed, 2 insertions(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2025-06-16 5:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-14 2:07 [PATCH 0/2] virtio-9p: move G_GNUC_PRINTF to header Sean Wei
2025-06-14 2:08 ` [PATCH 1/2] fsdev/9p-marshal: " Sean Wei
2025-06-16 5:10 ` Philippe Mathieu-Daudé
2025-06-14 2:09 ` [PATCH 2/2] hw/9pfs: " Sean Wei
2025-06-16 5:10 ` Philippe Mathieu-Daudé [this message]
2025-06-14 2:09 ` [PoC] show header-vs-source G_GNUC_PRINTF behavior Sean Wei
2025-06-20 14:17 ` [PATCH 0/2] virtio-9p: move G_GNUC_PRINTF to header Christian Schoenebeck
2025-06-20 15:04 ` Sean Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c892aff3-b77a-4131-b3c3-9c671cd18af4@linaro.org \
--to=philmd@linaro.org \
--cc=groug@kaod.org \
--cc=me@sean.taipei \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).