qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	qemu-block@nongnu.org
Cc: kwolf@redhat.com, berrange@redhat.com, qemu-devel@nongnu.org,
	mreitz@redhat.com, kraxel@redhat.com, den@openvz.org
Subject: Re: [PATCH for-5.1? 0/4] non-blocking connect
Date: Thu, 23 Jul 2020 14:35:35 -0500	[thread overview]
Message-ID: <c8a9ac63-6d7d-1955-976d-b51c3ad6b0ab@redhat.com> (raw)
In-Reply-To: <20200720180715.10521-1-vsementsov@virtuozzo.com>

On 7/20/20 1:07 PM, Vladimir Sementsov-Ogievskiy wrote:
> Hi! This fixes real problem (see 04). On the other hand it may be too
> much for 5.1, and it's not a degradation. So, up to you.

Given the concerns raised on 3, I think I'll wait for v2 of the series, 
and defer it to 5.2.

> 
> It's based on "[PATCH for-5.1? 0/3] Fix nbd reconnect dead-locks", or
> in other words
> Based-on: <20200720090024.18186-1-vsementsov@virtuozzo.com>
> 
> Vladimir Sementsov-Ogievskiy (4):
>    qemu-sockets: refactor inet_connect_addr
>    qemu-sockets: implement non-blocking connect interface
>    io/channel-socket: implement non-blocking connect
>    block/nbd: use non-blocking connect: fix vm hang on connect()
> 
>   include/io/channel-socket.h | 14 +++++++
>   include/qemu/sockets.h      |  6 +++
>   block/nbd.c                 | 11 +++---
>   io/channel-socket.c         | 74 ++++++++++++++++++++++++++++++++++++
>   util/qemu-sockets.c         | 76 ++++++++++++++++++++++++++-----------
>   5 files changed, 153 insertions(+), 28 deletions(-)
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org



      parent reply	other threads:[~2020-07-23 19:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-20 18:07 [PATCH for-5.1? 0/4] non-blocking connect Vladimir Sementsov-Ogievskiy
2020-07-20 18:07 ` [PATCH 1/4] qemu-sockets: refactor inet_connect_addr Vladimir Sementsov-Ogievskiy
2020-07-20 18:07 ` [PATCH 2/4] qemu-sockets: implement non-blocking connect interface Vladimir Sementsov-Ogievskiy
2020-07-20 18:07 ` [PATCH 3/4] io/channel-socket: implement non-blocking connect Vladimir Sementsov-Ogievskiy
2020-07-20 18:29   ` Daniel P. Berrangé
2020-07-22 11:00     ` Vladimir Sementsov-Ogievskiy
2020-07-22 11:21       ` Daniel P. Berrangé
2020-07-22 12:43         ` Vladimir Sementsov-Ogievskiy
2020-07-22 12:53           ` Daniel P. Berrangé
2020-07-22 13:47             ` Vladimir Sementsov-Ogievskiy
2020-07-22 15:04               ` Vladimir Sementsov-Ogievskiy
2020-07-22 15:21                 ` Daniel P. Berrangé
2020-07-22 15:40                   ` Vladimir Sementsov-Ogievskiy
2020-07-22 15:43                     ` Daniel P. Berrangé
2020-07-22 15:56                       ` Vladimir Sementsov-Ogievskiy
2020-07-20 18:07 ` [PATCH 4/4] block/nbd: use non-blocking connect: fix vm hang on connect() Vladimir Sementsov-Ogievskiy
2020-07-23 19:35 ` Eric Blake [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8a9ac63-6d7d-1955-976d-b51c3ad6b0ab@redhat.com \
    --to=eblake@redhat.com \
    --cc=berrange@redhat.com \
    --cc=den@openvz.org \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).