From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09024C433DF for ; Thu, 23 Jul 2020 19:05:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C8F89206F4 for ; Thu, 23 Jul 2020 19:05:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cjK2jQn0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C8F89206F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jygX5-0005cZ-3A for qemu-devel@archiver.kernel.org; Thu, 23 Jul 2020 15:05:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33074) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jygWR-00052n-IT for qemu-devel@nongnu.org; Thu, 23 Jul 2020 15:04:51 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:23255 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jygWQ-0006Ck-0h for qemu-devel@nongnu.org; Thu, 23 Jul 2020 15:04:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595531089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XB1aAD7zOAn2xfkLbC1RfxDMtUY6NKPXuvEdYL2zL5s=; b=cjK2jQn09dWKRA6gXl40i9Dqa8SbgT2YW44HZU6qytuMQCM0fGSv+mGtUhHhq4w0vbVFuq 5kj+ut/gAjyFVcocw8Yyu5vSBd0izq4aDKzaAf+lipJGb8OZYEDflayj/X0VCBy8r9VkS7 JRatFssPwgwlmwCd1nvpZpF2R5JitoM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-53-66t9lMdzMMa9MX2oq0H1bw-1; Thu, 23 Jul 2020 15:04:47 -0400 X-MC-Unique: 66t9lMdzMMa9MX2oq0H1bw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 841B88E1D26 for ; Thu, 23 Jul 2020 19:04:46 +0000 (UTC) Received: from [10.3.112.189] (ovpn-112-189.phx2.redhat.com [10.3.112.189]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 31E7760CC0; Thu, 23 Jul 2020 19:04:46 +0000 (UTC) Subject: Re: [PATCH 1/4] qom: make object_ref/unref use a void * instead of Object *. To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , qemu-devel@nongnu.org References: <20200723181410.3145233-1-berrange@redhat.com> <20200723181410.3145233-2-berrange@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: Date: Thu, 23 Jul 2020 14:04:45 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200723181410.3145233-2-berrange@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=207.211.31.120; envelope-from=eblake@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/22 22:13:02 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/23/20 1:14 PM, Daniel P. Berrangé wrote: > The object_ref/unref methods are intended for use with any subclass of > the base Object. Using "Object *" in the signature is not adding any > meaningful level of type safety, since callers simply use "OBJECT(ptr)" > and this expands to an unchecked cast "(Object *)". > > By using "void *" we enable the object_unref() method to be used to > provide support for g_autoptr() with any subclass. > > Signed-off-by: Daniel P. Berrangé > --- > include/qom/object.h | 4 ++-- > qom/object.c | 6 ++++-- > 2 files changed, 6 insertions(+), 4 deletions(-) Is it worth a followup patch (probably with Coccinelle) that changes: object_ref(OBJECT(dev)); to the now-simpler object_ref(dev); But I don't think it belongs in this patch, so Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org