From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Song Gao <gaosong@loongson.cn>, qemu-devel@nongnu.org
Cc: richard.henderson@linaro.org, c@jia.je, maobibo@loongson.cn,
yangxiaojuan@loongson.cn, yijun@loongson.cn,
shenjinyang@loongson.cn
Subject: Re: [PATCH v3 11/18] target/loongarch: Add a check parameter to the TRANS macro
Date: Fri, 18 Aug 2023 12:39:37 +0200 [thread overview]
Message-ID: <c8b1453e-6549-7dd4-4bc3-ceac72331a77@linaro.org> (raw)
In-Reply-To: <20230817093121.1053890-12-gaosong@loongson.cn>
On 17/8/23 11:31, Song Gao wrote:
> The default check parmeter is ALL.
>
> Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Song Gao <gaosong@loongson.cn>
> ---
> target/loongarch/insn_trans/trans_arith.c.inc | 84 +-
> .../loongarch/insn_trans/trans_atomic.c.inc | 80 +-
> target/loongarch/insn_trans/trans_bit.c.inc | 56 +-
> .../loongarch/insn_trans/trans_branch.c.inc | 20 +-
> target/loongarch/insn_trans/trans_extra.c.inc | 16 +-
> .../loongarch/insn_trans/trans_farith.c.inc | 72 +-
> target/loongarch/insn_trans/trans_fcnv.c.inc | 56 +-
> .../loongarch/insn_trans/trans_fmemory.c.inc | 32 +-
> target/loongarch/insn_trans/trans_fmov.c.inc | 16 +-
> target/loongarch/insn_trans/trans_lsx.c.inc | 1322 ++++++++---------
> .../loongarch/insn_trans/trans_memory.c.inc | 84 +-
> .../insn_trans/trans_privileged.c.inc | 16 +-
> target/loongarch/insn_trans/trans_shift.c.inc | 30 +-
> target/loongarch/translate.c | 3 +
> target/loongarch/translate.h | 8 +-
> 15 files changed, 951 insertions(+), 944 deletions(-)
Please setup scripts/git.orderfile.
> diff --git a/target/loongarch/translate.c b/target/loongarch/translate.c
> index de7c1c5d1f..fd393ed76d 100644
> --- a/target/loongarch/translate.c
> +++ b/target/loongarch/translate.c
> @@ -127,6 +127,9 @@ static void loongarch_tr_init_disas_context(DisasContextBase *dcbase,
> ctx->va32 = (ctx->base.tb->flags & HW_FLAGS_VA32) != 0;
>
> ctx->zero = tcg_constant_tl(0);
> +
> + ctx->cpucfg1 = env->cpucfg[1];
> + ctx->cpucfg2 = env->cpucfg[2];
Unrelated to this patch.
> }
> @@ -35,6 +37,8 @@ typedef struct DisasContext {
> TCGv zero;
> bool la64; /* LoongArch64 mode */
> bool va32; /* 32-bit virtual address */
> + uint32_t cpucfg1;
> + uint32_t cpucfg2;
Unrelated to this patch.
> } DisasContext;
Removing unrelated cpucfgX:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-08-18 14:10 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 9:31 [PATCH v3 00/18] Add some checks before translating instructions Song Gao
2023-08-17 9:31 ` [PATCH v3 01/18] target/loongarch: Add function to check current arch Song Gao
2023-08-18 16:58 ` Philippe Mathieu-Daudé
2023-08-17 9:31 ` [PATCH v3 02/18] target/loongarch: Add new object class for loongarch32 cpus Song Gao
2023-08-18 8:51 ` Philippe Mathieu-Daudé
2023-08-18 8:56 ` chen huacai
2023-08-17 9:31 ` [PATCH v3 03/18] target/loongarch: Add GDB support for loongarch32 mode Song Gao
2023-08-17 9:31 ` [PATCH v3 04/18] target/loongarch: Support LoongArch32 TLB entry Song Gao
2023-08-17 9:31 ` [PATCH v3 05/18] target/loongarch: Support LoongArch32 DMW Song Gao
2023-08-17 9:31 ` [PATCH v3 06/18] target/loongarch: Support LoongArch32 VPPN Song Gao
2023-08-17 9:31 ` [PATCH v3 07/18] target/loongarch: Add LA64 & VA32 to DisasContext Song Gao
2023-08-17 9:31 ` [PATCH v3 08/18] target/loongarch: Truncate high 32 bits of address in VA32 mode Song Gao
2023-08-18 9:41 ` Philippe Mathieu-Daudé
2023-08-18 15:25 ` Richard Henderson
2023-08-18 17:05 ` Philippe Mathieu-Daudé
2023-08-17 9:31 ` [PATCH v3 09/18] target/loongarch: Sign extend results " Song Gao
2023-08-17 9:31 ` [PATCH v3 10/18] target/loongarch: Fix loongarch_la464_initfn() misses setting LSPW Song Gao
2023-08-18 10:36 ` Philippe Mathieu-Daudé
2023-08-17 9:31 ` [PATCH v3 11/18] target/loongarch: Add a check parameter to the TRANS macro Song Gao
2023-08-18 10:39 ` Philippe Mathieu-Daudé [this message]
2023-08-18 15:28 ` Richard Henderson
2023-08-17 9:31 ` [PATCH v3 12/18] target/loongarch: Add avail_64 to check la64-only instructions Song Gao
2023-08-18 15:32 ` Richard Henderson
2023-08-17 9:31 ` [PATCH v3 13/18] target/loongarch: Add loongarch32 cpu la132 Song Gao
2023-08-18 9:29 ` Philippe Mathieu-Daudé
2023-08-18 10:41 ` Philippe Mathieu-Daudé
2023-08-17 9:31 ` [PATCH v3 14/18] target/loongarch: Add avail_FP/FP_SP/FP_DP to check fpu instructions Song Gao
2023-08-17 9:31 ` [PATCH v3 15/18] target/loongarch: Add avail_LSPW to check LSPW instructions Song Gao
2023-08-17 9:31 ` [PATCH v3 16/18] target/loongarch: Add avail_LAM to check atomic instructions Song Gao
2023-08-18 15:34 ` Richard Henderson
2023-08-17 9:31 ` [PATCH v3 17/18] target/loongarch: Add avail_LSX to check LSX instructions Song Gao
2023-08-17 9:31 ` [PATCH v3 18/18] target/loongarch: Add avail_IOCSR to check iocsr instructions Song Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8b1453e-6549-7dd4-4bc3-ceac72331a77@linaro.org \
--to=philmd@linaro.org \
--cc=c@jia.je \
--cc=gaosong@loongson.cn \
--cc=maobibo@loongson.cn \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shenjinyang@loongson.cn \
--cc=yangxiaojuan@loongson.cn \
--cc=yijun@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).