From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: eblake@redhat.com
Subject: Re: [PATCH 3/6] qapi/qdev: Tidy up device_add documentation
Date: Thu, 20 Jul 2023 15:42:02 +0200 [thread overview]
Message-ID: <c8b31bc5-fbe8-f4d9-c3d4-d1014355639a@linaro.org> (raw)
In-Reply-To: <20230720071610.1096458-4-armbru@redhat.com>
On 20/7/23 09:16, Markus Armbruster wrote:
> The notes section comes out like this:
>
> Notes
>
> Additional arguments depend on the type.
>
> 1. For detailed information about this command, please refer to the
> ‘docs/qdev-device-use.txt’ file.
>
> 2. It’s possible to list device properties by running QEMU with the
> “-device DEVICE,help” command-line argument, where DEVICE is the
> device’s name
>
> The first item isn't numbered. Fix that:
>
> 1. Additional arguments depend on the type.
>
> 2. For detailed information about this command, please refer to the
> ‘docs/qdev-device-use.txt’ file.
>
> 3. It’s possible to list device properties by running QEMU with the
> “-device DEVICE,help” command-line argument, where DEVICE is the
> device’s name
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> qapi/qdev.json | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-07-20 13:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 7:16 [PATCH 0/6] qapi: Tidy up doc comments Markus Armbruster
2023-07-20 7:16 ` [PATCH 1/6] qapi/block-core: Tidy up BlockLatencyHistogramInfo documentation Markus Armbruster
2023-07-20 7:16 ` [PATCH 2/6] qapi/block: Tidy up block-latency-histogram-set documentation Markus Armbruster
2023-07-20 13:39 ` Philippe Mathieu-Daudé
2023-07-20 7:16 ` [PATCH 3/6] qapi/qdev: Tidy up device_add documentation Markus Armbruster
2023-07-20 13:42 ` Philippe Mathieu-Daudé [this message]
2023-07-20 7:16 ` [PATCH 4/6] qapi/trace: Tidy up trace-event-get-state, -set-state documentation Markus Armbruster
2023-07-20 7:16 ` [PATCH 5/6] qapi: Correct "eg." to "e.g." in documentation Markus Armbruster
2023-07-20 13:41 ` Philippe Mathieu-Daudé
2023-07-20 15:13 ` Markus Armbruster
2023-07-20 7:16 ` [PATCH 6/6] qapi: Reformat recent doc comments to conform to current conventions Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8b31bc5-fbe8-f4d9-c3d4-d1014355639a@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).