From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>,
"Mark Kanda" <mark.kanda@oracle.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [PATCH v3 1/3] qmp: Support for querying stats
Date: Thu, 3 Feb 2022 19:38:08 +0100 [thread overview]
Message-ID: <c8b8434f-17c2-5a50-bc7f-49bb7fa9f7b9@redhat.com> (raw)
In-Reply-To: <YfkiyiK+jfrdbVcY@redhat.com>
On 2/1/22 13:08, Daniel P. Berrangé wrote:
> I still feel like this is rather verbose, and should be simplified
> down to.
>
> { "return": {
> "vm": {
> "kvm": [ ... ]
> "provider-XYZ": [ ... ],
> ...
> }
> }
My main qualm with this is that not just QEMU, but every layer above
then needs to either treat stats as a "dynamic" type unless they want to
only handle providers that they know.
The main reason why I asked Mark to do all this work, was so that new
stats and stats providers could be added transparently, and only new
*targets* would need work all over the stack (but those are fewer, for
example blockdev/netdev/iothread).
Paolo
next prev parent reply other threads:[~2022-02-03 19:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 19:43 [PATCH v3 0/3] Support fd-based KVM stats Mark Kanda
2022-01-31 19:43 ` [PATCH v3 1/3] qmp: Support for querying stats Mark Kanda
2022-02-01 10:51 ` Paolo Bonzini
2022-02-01 11:01 ` Daniel P. Berrangé
2022-02-11 13:51 ` Markus Armbruster
2022-02-01 12:08 ` Daniel P. Berrangé
2022-02-03 18:12 ` Mark Kanda
2022-02-03 18:30 ` Daniel P. Berrangé
2022-02-03 18:37 ` Mark Kanda
2022-02-03 18:39 ` Paolo Bonzini
2022-02-03 18:38 ` Paolo Bonzini [this message]
2022-02-03 18:53 ` Daniel P. Berrangé
2022-02-03 18:52 ` Mark Kanda
2022-01-31 19:43 ` [PATCH v3 2/3] hmp: " Mark Kanda
2022-01-31 19:43 ` [PATCH v3 3/3] kvm: Support for querying fd-based stats Mark Kanda
2022-02-01 10:08 ` Daniel P. Berrangé
2022-02-01 10:51 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8b8434f-17c2-5a50-bc7f-49bb7fa9f7b9@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=mark.kanda@oracle.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).