From: Jason Wang <jasowang@redhat.com>
To: Cindy Lu <lulu@redhat.com>, mst@redhat.com, qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org
Subject: Re: [PATCH v2 1/2] vhost-vdpa: Add qemu_close in vhost_vdpa_cleanup
Date: Mon, 19 Oct 2020 15:52:27 +0800 [thread overview]
Message-ID: <c8c9edad-a62e-b633-3d2b-7bd58497ab81@redhat.com> (raw)
In-Reply-To: <20201016030909.9522-1-lulu@redhat.com>
On 2020/10/16 上午11:09, Cindy Lu wrote:
> fix the bug that fd will still open after the cleanup
>
> Signed-off-by: Cindy Lu <lulu@redhat.com>
> ---
> net/vhost-vdpa.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
> index bc0e0d2d35..0480b92102 100644
> --- a/net/vhost-vdpa.c
> +++ b/net/vhost-vdpa.c
> @@ -144,6 +144,10 @@ static void vhost_vdpa_cleanup(NetClientState *nc)
> g_free(s->vhost_net);
> s->vhost_net = NULL;
> }
> + if (s->vhost_vdpa.device_fd >= 0) {
> + qemu_close(s->vhost_vdpa.device_fd);
> + s->vhost_vdpa.device_fd = -1;
> + }
> }
>
> static bool vhost_vdpa_has_vnet_hdr(NetClientState *nc)
Acked-by: Jason Wang <jasowang@redhat.com>
prev parent reply other threads:[~2020-10-19 8:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 3:09 [PATCH v2 1/2] vhost-vdpa: Add qemu_close in vhost_vdpa_cleanup Cindy Lu
2020-10-16 3:09 ` [PATCH v2 2/2] net: Add vhost-vdpa in show_netdevs() Cindy Lu
2020-10-19 7:52 ` Jason Wang
2020-10-19 7:52 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8c9edad-a62e-b633-3d2b-7bd58497ab81@redhat.com \
--to=jasowang@redhat.com \
--cc=lulu@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).