From: Thomas Huth <thuth@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Kevin Wolf" <kwolf@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH] meson/configure: add 'valgrind' option & --{en, dis}able-valgrind flag
Date: Fri, 25 Apr 2025 14:26:34 +0200 [thread overview]
Message-ID: <c8d1eb76-cd90-45b2-a6ba-e889e5f5b62f@redhat.com> (raw)
In-Reply-To: <20250425121713.1913424-1-berrange@redhat.com>
On 25/04/2025 14.17, Daniel P. Berrangé via wrote:
> Currently valgrind debugging support for coroutine stacks is enabled
> unconditionally when valgrind/valgrind.h is found. There is no way
> to disable valgrind support if valgrind.h is present in the build env.
>
> This is bad for distros, as an dependency far down the chain may cause
> valgrind.h to become installed, inadvertantly enabling QEMU's valgrind
> debugging support. It also means if a distro wants valgrind support
> there is no way to mandate this.
>
> The solution is to add a 'valgrind' build feature to meson and thus
> configure script.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> meson.build | 13 ++++++++++++-
> meson_options.txt | 2 ++
> scripts/meson-buildoptions.sh | 3 +++
> 3 files changed, 17 insertions(+), 1 deletion(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2025-04-25 12:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 12:17 [PATCH] meson/configure: add 'valgrind' option & --{en, dis}able-valgrind flag Daniel P. Berrangé via
2025-04-25 12:26 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8d1eb76-cd90-45b2-a6ba-e889e5f5b62f@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).