Re: [Qemu-devel] [RFC PATCH v2 24/35] multi-process: add qdev_proxy_add to create proxy devices

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1228 bytes --]

On 6/17/19 1:16 PM, elena.ufimtseva@oracle.com wrote:
> From: Elena Ufimtseva <elena.ufimtseva@oracle.com>
> 
> This is handled while parsing the command line options.
> The parsed options are being sent to remote process
> as the messgaes containing JSON strings.

s/messgaes/messages/

> 
> Changes in v2:
>  - parse socket and command suboptions of drive/device commands;

The changelog paragraph belongs...

> 
> Signed-off-by: Jagannathan Raman <jag.raman@oracle.com>
> Signed-off-by: John G Johnson <john.g.johnson@oracle.com>
> Signed-off-by: Elena Ufimtseva <elena.ufimtseva@oracle.com>
> ---

...here, after the --- divider. It is useful to reviewers, but gets
stripped by 'git am' when the maintainer applies the series. A year from
now, we won't care how many iterations the patches went through on list,
only the one version that got committed to git.

>  include/hw/proxy/qemu-proxy.h |   7 ++
>  include/monitor/qdev.h        |   5 +
>  qdev-monitor.c                | 166 ++++++++++++++++++++++++++++++++++
>  3 files changed, 178 insertions(+)
> 


-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]