Re: [PATCH for-10.1 v2 33/37] vfio: Rename RAM discard related services

["Cédric Le Goater" <clg@redhat.com>]

On 3/27/25 10:51, John Levon wrote:
> On Wed, Mar 26, 2025 at 08:51:18AM +0100, Cédric Le Goater wrote:
> 
>> Rename some routines to better reflect the namespace they belong to.
>>
>> Signed-off-by: Cédric Le Goater <clg@redhat.com>
>> ---
>>   hw/vfio/listener.c | 12 ++++++------
>>   1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/hw/vfio/listener.c b/hw/vfio/listener.c
>> index 26ced6d4fb04b0dedf399686db40acaca5d85552..07c8dc6ce343510dea20c5946e64a23a57c0f91b 100644
>> --- a/hw/vfio/listener.c
>> +++ b/hw/vfio/listener.c
>> @@ -243,7 +243,7 @@ static int vfio_ram_discard_notify_populate(RamDiscardListener *rdl,
>>       return 0;
>>   }
>>   
>> -static void vfio_register_ram_discard_listener(VFIOContainerBase *bcontainer,
>> +static void  vfio_ram_discard_register_listener(VFIOContainerBase *bcontainer,
>>                                                  MemoryRegionSection *section)
>>   {
>>       RamDiscardManager *rdm = memory_region_get_ram_discard_manager(section->mr);
>> @@ -318,7 +318,7 @@ static void vfio_register_ram_discard_listener(VFIOContainerBase *bcontainer,
>>       }
>>   }
>>   
>> -static void vfio_unregister_ram_discard_listener(VFIOContainerBase *bcontainer,
>> +static void  vfio_ram_discard_unregister_listener(VFIOContainerBase *bcontainer,
>>                                                    MemoryRegionSection *section)
> 
> Nit, unnecessary double spaces introduced here?

Indeed ! The sed expression I used was bogus. Fixed


Thanks,

C.


> 
> regards
> john
>