From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Sunny Zhu <sunnyzhyy@qq.com>, qemu-devel@nongnu.org
Cc: eblake@redhat.com, hreitz@redhat.com, kwolf@redhat.com,
qemu-block@nongnu.org
Subject: Re: [PATCH v2] block: Remove unused callback function *bdrv_aio_pdiscard
Date: Tue, 22 Apr 2025 09:09:28 +0200 [thread overview]
Message-ID: <c901543c-57bc-4bfd-b742-4dc302126eb6@linaro.org> (raw)
In-Reply-To: <tencent_7140D2E54157D98CF3D9E64B1A007A1A7906@qq.com>
On 21/4/25 20:21, Sunny Zhu wrote:
> The bytes type in *bdrv_aio_pdiscard should be int64_t rather than int.
>
> There are no drivers implementing the *bdrv_aio_pdiscard() callback,
> it appears to be an unused function. Therefore, we'll simply remove it
> instead of fixing it.
>
> Additionally, coroutine-based callbacks are preferred. If someone needs
> to implement bdrv_aio_pdiscard, a coroutine-based version would be
> straightforward to implement.
>
> Signed-off-by: Sunny Zhu <sunnyzhyy@qq.com>
> ---
> block/io.c | 22 +++-------------------
> include/block/block_int-common.h | 4 ----
> 2 files changed, 3 insertions(+), 23 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2025-04-22 7:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 18:21 [PATCH v2] block: Remove unused callback function *bdrv_aio_pdiscard Sunny Zhu
2025-04-22 7:09 ` Philippe Mathieu-Daudé [this message]
2025-04-25 15:12 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c901543c-57bc-4bfd-b742-4dc302126eb6@linaro.org \
--to=philmd@linaro.org \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sunnyzhyy@qq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).