From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 7/7] tcg: Allow 6 arguments to TCG helpers
Date: Mon, 18 Dec 2017 11:20:25 -0800 [thread overview]
Message-ID: <c9038f49-5972-289c-949a-0365f8cbc032@linaro.org> (raw)
In-Reply-To: <13ac2e8e-cd5d-9ce1-cad3-9c16f041e1bd@amsat.org>
On 12/15/2017 10:06 AM, Philippe Mathieu-Daudé wrote:
>> @@ -305,14 +305,16 @@ static const int tcg_target_call_iarg_regs[] = {
>> TCG_REG_R4,
>> #endif
>> TCG_REG_R5,
>> + TCG_REG_R6,
>> #if TCG_TARGET_REG_BITS == 32
>> /* 32 bit hosts need 2 * MAX_OPC_PARAM_IARGS registers. */
>> - TCG_REG_R6,
>> TCG_REG_R7,
>
> I think now TCG_REG_R8 belongs here...
>
>> #if TCG_TARGET_NB_REGS >= 16
>> TCG_REG_R8,
>
> ^ not here.
Why? Unless TCG_TARGET_NB_REGS >= 16, TCG_REG_R8 doesn't exist.
I'd say this over-configuration of TCI ought to be cleaned up,
but I'd rather remove it entirely.
r~
next prev parent reply other threads:[~2017-12-18 19:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 17:07 [Qemu-devel] [PATCH 0/7] TCG misc patches Richard Henderson
2017-12-15 17:07 ` [Qemu-devel] [PATCH 1/7] target/*helper: don't check retaddr before calling cpu_restore_state Richard Henderson
2017-12-15 17:07 ` [Qemu-devel] [PATCH 2/7] target/moxie: Fix tlb_fill Richard Henderson
2017-12-15 17:31 ` Peter Maydell
2017-12-18 18:47 ` Richard Henderson
2017-12-15 17:07 ` [Qemu-devel] [PATCH 3/7] tcg: Remove TCGV_UNUSED* and TCGV_IS_UNUSED* Richard Henderson
2017-12-15 17:58 ` Philippe Mathieu-Daudé
2017-12-15 17:07 ` [Qemu-devel] [PATCH 4/7] tcg: Dynamically allocate TCGOps Richard Henderson
2017-12-15 17:07 ` [Qemu-devel] [PATCH 5/7] tcg: Generalize TCGOp parameters Richard Henderson
2017-12-15 17:59 ` Philippe Mathieu-Daudé
2017-12-15 17:07 ` [Qemu-devel] [PATCH 6/7] tcg: Add tcg_signed_cond Richard Henderson
2017-12-15 17:07 ` [Qemu-devel] [PATCH 7/7] tcg: Allow 6 arguments to TCG helpers Richard Henderson
2017-12-15 18:06 ` Philippe Mathieu-Daudé
2017-12-18 19:20 ` Richard Henderson [this message]
2017-12-18 20:39 ` Philippe Mathieu-Daudé
2017-12-15 18:13 ` [Qemu-devel] [PATCH 0/7] TCG misc patches no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9038f49-5972-289c-949a-0365f8cbc032@linaro.org \
--to=richard.henderson@linaro.org \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).