From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EDBBEC5478C for ; Mon, 26 Feb 2024 07:04:43 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1reV2O-0002TK-H1; Mon, 26 Feb 2024 02:04:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1reV2M-0002Sl-LW for qemu-devel@nongnu.org; Mon, 26 Feb 2024 02:04:30 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1reV2H-0003cB-8Z for qemu-devel@nongnu.org; Mon, 26 Feb 2024 02:04:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708931063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LfRURWK6oYZl/Fbj3F0n1k9dog/oTC7o3rBVtl+5lxA=; b=IcB1We88Yz92CU7zxthDdSp5qoQO68eXCXI/wtUugh1adhbl6VT86+fsTf1i6oTlLB7XdV 0SNxDKdLJ9sGAwan0meTTmhVEtRcPun4lYXGekP6BhxC6XOYoGzGPXeejkZ4AxBiOxO5bT IAX3ZytlCK8T/3By1SNnwKcvvsJwNTI= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-156-KQjEJ0LoN5-QAY7Ze3YMrg-1; Mon, 26 Feb 2024 02:04:22 -0500 X-MC-Unique: KQjEJ0LoN5-QAY7Ze3YMrg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-412a805f783so686525e9.3 for ; Sun, 25 Feb 2024 23:04:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708931061; x=1709535861; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LfRURWK6oYZl/Fbj3F0n1k9dog/oTC7o3rBVtl+5lxA=; b=YhJFkvNasG+AthBuCttfDK+8aOLs2dZdzd5xaANGqs211IFx6Q8AZ5bZXiCSQ0fLLL aKYP19jSlYE4bUjQV29fvQbACTvJFr0GD7tXwatc/YII8YTajNdu2f8otXpTyubKqXLo WGLL9xjkoymnGhxStFZ4umWbPiNB3teX3UZiTQGV/db9IAhJH8a5B0C4RBdkn/t97lnH TMOUMMIHKHdUjgdJjZw6zYC+JRIpQCySclXCHKGBamwYgXa01bMm782d4rDVt+57n69e ORN1XpoWHKHBApQPSf/Ry0Q6pKz1W7t215bTfmKlOyHDMLjcICSWRMtIR+mMHUVZqIgw usBw== X-Forwarded-Encrypted: i=1; AJvYcCUe0Lm3WCb2rRUAFd5QW2h8yeg6vDtCkM324ogL5NUh01+8p5aI4uoeexnl4CDkGFpQVcUWPJw4hmrKwxC8+Pkv06Rlpmc= X-Gm-Message-State: AOJu0YwTfmH2HhEINNl6lXk/fBVQYN8EqQMHblb11Tiyd4JXzEaUo3Kw S/HJCG8wR1TmNqOhEkE5NX5UMYoDqJ4gfKdQu7Flwn8VTYFXnk5us6N+Vy8zNhhduwXXWOZKTID 0DCkI+m8V36IMUYjWVw7aj7lb0ThonSQMD+OlIXhnyaXCu/IWD6NATexe11Zn X-Received: by 2002:a05:600c:358f:b0:412:a7da:8286 with SMTP id p15-20020a05600c358f00b00412a7da8286mr315309wmq.4.1708931061197; Sun, 25 Feb 2024 23:04:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IF8/r8g7QJxgT+faMbdsfMnRWTjOpPapqf9VmdkeRJNS4LyNNCB8LfWBtatz5cxedP19B6axw== X-Received: by 2002:a05:600c:358f:b0:412:a7da:8286 with SMTP id p15-20020a05600c358f00b00412a7da8286mr315294wmq.4.1708931060899; Sun, 25 Feb 2024 23:04:20 -0800 (PST) Received: from [192.168.0.9] (ip-109-43-176-215.web.vodafone.de. [109.43.176.215]) by smtp.gmail.com with ESMTPSA id x1-20020a05600c2a4100b0041292306f2csm10858780wme.16.2024.02.25.23.04.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Feb 2024 23:04:20 -0800 (PST) Message-ID: Date: Mon, 26 Feb 2024 08:04:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/10] sh4: r2d: do not use usb_bus_find() Content-Language: en-US To: Paolo Bonzini , qemu-devel@nongnu.org Cc: philmd@linaro.org, balaton@eik.bme.hu References: <20240223124406.234509-1-pbonzini@redhat.com> <20240223124406.234509-4-pbonzini@redhat.com> From: Thomas Huth Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20240223124406.234509-4-pbonzini@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.097, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 23/02/2024 13.43, Paolo Bonzini wrote: > usb_bus_find() is always used with argument -1; it can be replaced with > a search of the single USB bus on the machine. > > Suggested-by: Philippe Mathieu-Daudé > Signed-off-by: Paolo Bonzini > --- > hw/sh4/r2d.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/sh4/r2d.c b/hw/sh4/r2d.c > index c73e8f49b8a..4d34ad00d93 100644 > --- a/hw/sh4/r2d.c > +++ b/hw/sh4/r2d.c > @@ -244,6 +244,7 @@ static void r2d_init(MachineState *machine) > SysBusDevice *busdev; > MemoryRegion *address_space_mem = get_system_memory(); > PCIBus *pci_bus; > + USBBus *usb_bus; > > cpu = SUPERH_CPU(cpu_create(machine->cpu_type)); > env = &cpu->env; > @@ -312,7 +313,8 @@ static void r2d_init(MachineState *machine) > pci_init_nic_devices(pci_bus, mc->default_nic); > > /* USB keyboard */ > - usb_create_simple(usb_bus_find(-1), "usb-kbd"); > + usb_bus = USB_BUS(object_resolve_type_unambiguous(TYPE_USB_BUS, &error_abort)); > + usb_create_simple(usb_bus, "usb-kbd"); > > /* Todo: register on board registers */ > memset(&boot_params, 0, sizeof(boot_params)); Reviewed-by: Thomas Huth