From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Bernhard Beschow <shentey@gmail.com>, qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <eduardo@habkost.net>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Ani Sinha <ani@anisinha.ca>,
Markus Armbruster <armbru@redhat.com>,
Aurelien Jarno <aurelien@aurel32.net>,
Igor Mammedov <imammedo@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 5/7] hw/acpi/acpi_aml_interface: Extract qbus_build_aml()
Date: Mon, 16 Jan 2023 10:13:08 +0100 [thread overview]
Message-ID: <c9168fc5-81e8-0182-18bd-4aed67c51221@linaro.org> (raw)
In-Reply-To: <20230114222738.282478-6-shentey@gmail.com>
On 14/1/23 23:27, Bernhard Beschow wrote:
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> ---
> include/hw/acpi/acpi_aml_interface.h | 11 +++++++++++
> hw/i2c/smbus_ich9.c | 5 +----
> hw/isa/lpc_ich9.c | 5 +----
> hw/isa/piix3.c | 5 +----
> 4 files changed, 14 insertions(+), 12 deletions(-)
>
> diff --git a/include/hw/acpi/acpi_aml_interface.h b/include/hw/acpi/acpi_aml_interface.h
> index 436da069d6..cb2f1c9910 100644
> --- a/include/hw/acpi/acpi_aml_interface.h
> +++ b/include/hw/acpi/acpi_aml_interface.h
> +static inline void qbus_build_aml(BusState *bus, Aml *scope)
> +{
> + BusChild *kid;
> +
> + QTAILQ_FOREACH(kid, &bus->children, sibling) {
> + call_dev_aml_func(DEVICE(kid->child), scope);
> + }
> +}
Inline not really justified, can we move this to hw/acpi/aml-build.c?
Otherwise:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-01-16 9:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-14 22:27 [PATCH 0/7] AML Housekeeping Bernhard Beschow
2023-01-14 22:27 ` [PATCH 1/7] hw/acpi: Add missing includes Bernhard Beschow
2023-01-16 6:46 ` Markus Armbruster
2023-01-16 8:56 ` Bernhard Beschow
2023-01-16 13:02 ` Markus Armbruster
2023-01-16 13:30 ` Bernhard Beschow
2023-01-14 22:27 ` [PATCH 2/7] hw/acpi/acpi_dev_interface: Remove unused parameter from AcpiDeviceIfClass::madt_cpu Bernhard Beschow
2023-01-16 15:51 ` Igor Mammedov
2023-01-14 22:27 ` [PATCH 3/7] hw/acpi/acpi_dev_interface: Resolve AcpiDeviceIfClass::madt_cpu Bernhard Beschow
2023-01-14 22:27 ` [PATCH 4/7] hw/i386/acpi-build: Remove unused attributes Bernhard Beschow
2023-01-16 9:09 ` Philippe Mathieu-Daudé
2023-01-14 22:27 ` [PATCH 5/7] hw/acpi/acpi_aml_interface: Extract qbus_build_aml() Bernhard Beschow
2023-01-16 9:13 ` Philippe Mathieu-Daudé [this message]
2023-01-14 22:27 ` [PATCH 6/7] hw/i386/acpi-microvm: Reuse qbus_build_aml() Bernhard Beschow
2023-01-16 9:14 ` Philippe Mathieu-Daudé
2023-01-16 14:02 ` Bernhard Beschow
2023-01-16 14:18 ` Bernhard Beschow
2023-01-16 14:22 ` Philippe Mathieu-Daudé
2023-01-14 22:27 ` [PATCH 7/7] hw/isa/isa-bus: Remove now unused isa_build_aml() Bernhard Beschow
2023-01-16 9:14 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9168fc5-81e8-0182-18bd-4aed67c51221@linaro.org \
--to=philmd@linaro.org \
--cc=ani@anisinha.ca \
--cc=armbru@redhat.com \
--cc=aurelien@aurel32.net \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shentey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).