From: Richard Henderson <richard.henderson@linaro.org>
To: "Cédric Le Goater" <clg@kaod.org>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Cc: Christophe Leroy <christophe.leroy@c-s.fr>,
Daniel Henrique Barboza <danielhb413@gmail.com>,
Greg Kurz <groug@kaod.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 4/8] ppc/ppc405: Restore TCR and STR write handlers
Date: Thu, 23 Dec 2021 13:36:32 -0800 [thread overview]
Message-ID: <c91d8ff9-47af-0715-5fe7-5d29ba6f0d69@linaro.org> (raw)
In-Reply-To: <20211222064025.1541490-5-clg@kaod.org>
On 12/21/21 10:40 PM, Cédric Le Goater wrote:
> The 405 timers were broken when booke support was added. Assumption
> was made that the register numbers were the same but it's not :
>
> SPR_BOOKE_TSR (0x150)
> SPR_BOOKE_TCR (0x154)
> SPR_40x_TSR (0x3D8)
> SPR_40x_TCR (0x3DA)
>
> Cc: Christophe Leroy<christophe.leroy@c-s.fr>
> Fixes: ddd1055b07fd ("PPC: booke timers")
> Signed-off-by: Cédric Le Goater<clg@kaod.org>
> ---
> target/ppc/cpu.h | 2 ++
> target/ppc/helper.h | 2 ++
> target/ppc/spr_tcg.h | 2 ++
> hw/ppc/ppc.c | 25 +++++++++++++++++++++++++
> target/ppc/cpu_init.c | 4 ++--
> target/ppc/timebase_helper.c | 10 ++++++++++
> target/ppc/translate.c | 12 ++++++++++++
> hw/ppc/trace-events | 2 ++
> 8 files changed, 57 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2021-12-23 21:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 6:40 [PATCH 0/8] ppc/ppc405: Fixes Cédric Le Goater
2021-12-22 6:40 ` [PATCH 1/8] target/ppc: Print out literal exception names in logs Cédric Le Goater
2021-12-22 10:00 ` Fabiano Rosas
2021-12-23 4:25 ` David Gibson
2021-12-23 21:32 ` Richard Henderson
2021-12-22 6:40 ` [PATCH 2/8] ppc/ppc4xx: Convert printfs() Cédric Le Goater
2021-12-23 4:26 ` David Gibson
2021-12-22 6:40 ` [PATCH 3/8] ppc/ppc405: Activate MMU logs Cédric Le Goater
2021-12-23 21:34 ` Richard Henderson
2021-12-24 12:57 ` BALATON Zoltan
2021-12-24 19:57 ` Richard Henderson
2021-12-22 6:40 ` [PATCH 4/8] ppc/ppc405: Restore TCR and STR write handlers Cédric Le Goater
2021-12-23 21:36 ` Richard Henderson [this message]
2021-12-22 6:40 ` [PATCH 5/8] ppc/ppc405: Rework ppc_40x_timers_init() to use a PowerPCCPU Cédric Le Goater
2021-12-23 21:41 ` Richard Henderson
2021-12-22 6:40 ` [PATCH 6/8] ppc/ppc405: Fix timer initialization Cédric Le Goater
2021-12-23 21:43 ` Richard Henderson
2021-12-22 6:40 ` [PATCH 7/8] ppc/ppc405: Introduce a store helper for SPR_40x_PID Cédric Le Goater
2021-12-23 21:44 ` Richard Henderson
2021-12-22 6:40 ` [PATCH 8/8] ppc/ppc405: Dump specific registers Cédric Le Goater
2021-12-23 21:47 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c91d8ff9-47af-0715-5fe7-5d29ba6f0d69@linaro.org \
--to=richard.henderson@linaro.org \
--cc=christophe.leroy@c-s.fr \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).