From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Joe Komlodi <komlodi@xilinx.com>
Subject: Re: [PATCH 1/2] target/cris: Use MMUAccessType enum type when possible
Date: Wed, 3 Feb 2021 16:45:50 -1000 [thread overview]
Message-ID: <c92e6957-8e17-e11f-e269-888b8b1b3c84@linaro.org> (raw)
In-Reply-To: <20210128003223.3561108-2-f4bug@amsat.org>
On 1/27/21 2:32 PM, Philippe Mathieu-Daudé wrote:
> Replace the 0/1/2 magic values by the corresponding MMUAccessType.
> We can remove a comment as enum names are self explicit.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/cris/helper.c | 4 ++--
> target/cris/mmu.c | 13 ++++++-------
> 2 files changed, 8 insertions(+), 9 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2021-02-04 3:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 0:32 [PATCH 0/2] target/cris: Pass MMUAccessType to cris_mmu_translate() Philippe Mathieu-Daudé
2021-01-28 0:32 ` [PATCH 1/2] target/cris: Use MMUAccessType enum type when possible Philippe Mathieu-Daudé
2021-02-04 2:45 ` Richard Henderson [this message]
2021-02-04 14:33 ` Edgar E. Iglesias
2021-01-28 0:32 ` [PATCH 2/2] target/cris: Let cris_mmu_translate() use MMUAccessType access_type Philippe Mathieu-Daudé
2021-02-04 2:46 ` Richard Henderson
2021-02-04 14:33 ` Edgar E. Iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c92e6957-8e17-e11f-e269-888b8b1b3c84@linaro.org \
--to=richard.henderson@linaro.org \
--cc=edgar.iglesias@gmail.com \
--cc=f4bug@amsat.org \
--cc=komlodi@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).