From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Vaibhav Jain <vaibhav@linux.ibm.com>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>,
"Anton Johansson" <anjo@rev.ng>
Subject: Re: [PATCH v2] travis.yml: Add missing 'flex','bison' packages to 'GCC (user)' job
Date: Thu, 20 Apr 2023 11:23:59 +0200 [thread overview]
Message-ID: <c96288ed-56c5-00a6-c69b-c6ec9dc048b9@linaro.org> (raw)
In-Reply-To: <20230417162354.186678-1-vaibhav@linux.ibm.com>
On 17/4/23 18:23, Vaibhav Jain wrote:
> Since commit fd8171fe52b5e("target/hexagon: import lexer for idef-parser") the
> hexagon target uses 'flex', 'bison' to generate idef-parser. However default
> travis builder image for 'focal' may not have these pre-installed, consequently
> following error is seen with travis when trying to execute the 'GCC (user)' job
> that also tries to build hexagon user binary:
>
> <snip>
> export CONFIG="--disable-containers --disable-system"
> <snip>
> Program flex found: NO
>
> ../target/hexagon/meson.build:179:4: ERROR: Program 'flex' not found or not
> executable
> <snip>
>
> Fix this by explicitly add 'flex' and 'bison' to the list of addon apt-packages
> for the 'GCC (user)' job.
>
> Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> Changelog:
>
> Since v1:
> Link: https://lore.kernel.org/qemu-devel/20230414210645.820204-2-vaibhav@linux.ibm.com/
>
> - Added 'bison' also to the addon package list (Thomas)
> - Updated the patch description
> ---
> .travis.yml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/.travis.yml b/.travis.yml
> index 11894eb810..b958eca5de 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -237,6 +237,8 @@ jobs:
> - libglib2.0-dev
> - libgnutls28-dev
> - ninja-build
> + - flex
> + - bison
> env:
> - CONFIG="--disable-containers --disable-system"
>
prev parent reply other threads:[~2023-04-20 9:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 16:23 [PATCH v2] travis.yml: Add missing 'flex', 'bison' packages to 'GCC (user)' job Vaibhav Jain
2023-04-18 6:28 ` [PATCH v2] travis.yml: Add missing 'flex','bison' " Thomas Huth
2023-04-20 9:23 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c96288ed-56c5-00a6-c69b-c6ec9dc048b9@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=anjo@rev.ng \
--cc=bleal@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=vaibhav@linux.ibm.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).