* [PATCH v2] travis.yml: Add missing 'flex', 'bison' packages to 'GCC (user)' job
@ 2023-04-17 16:23 Vaibhav Jain
2023-04-18 6:28 ` [PATCH v2] travis.yml: Add missing 'flex','bison' " Thomas Huth
2023-04-20 9:23 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Vaibhav Jain @ 2023-04-17 16:23 UTC (permalink / raw)
To: qemu-devel
Cc: Vaibhav Jain, Alex Bennée, Philippe Mathieu-Daudé,
Thomas Huth, Wainer dos Santos Moschetta, Beraldo Leal
Since commit fd8171fe52b5e("target/hexagon: import lexer for idef-parser") the
hexagon target uses 'flex', 'bison' to generate idef-parser. However default
travis builder image for 'focal' may not have these pre-installed, consequently
following error is seen with travis when trying to execute the 'GCC (user)' job
that also tries to build hexagon user binary:
<snip>
export CONFIG="--disable-containers --disable-system"
<snip>
Program flex found: NO
../target/hexagon/meson.build:179:4: ERROR: Program 'flex' not found or not
executable
<snip>
Fix this by explicitly add 'flex' and 'bison' to the list of addon apt-packages
for the 'GCC (user)' job.
Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com>
---
Changelog:
Since v1:
Link: https://lore.kernel.org/qemu-devel/20230414210645.820204-2-vaibhav@linux.ibm.com/
- Added 'bison' also to the addon package list (Thomas)
- Updated the patch description
---
.travis.yml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.travis.yml b/.travis.yml
index 11894eb810..b958eca5de 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -237,6 +237,8 @@ jobs:
- libglib2.0-dev
- libgnutls28-dev
- ninja-build
+ - flex
+ - bison
env:
- CONFIG="--disable-containers --disable-system"
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] travis.yml: Add missing 'flex','bison' packages to 'GCC (user)' job
2023-04-17 16:23 [PATCH v2] travis.yml: Add missing 'flex', 'bison' packages to 'GCC (user)' job Vaibhav Jain
@ 2023-04-18 6:28 ` Thomas Huth
2023-04-20 9:23 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2023-04-18 6:28 UTC (permalink / raw)
To: Vaibhav Jain, qemu-devel
Cc: Alex Bennée, Philippe Mathieu-Daudé,
Wainer dos Santos Moschetta, Beraldo Leal
On 17/04/2023 18.23, Vaibhav Jain wrote:
> Since commit fd8171fe52b5e("target/hexagon: import lexer for idef-parser") the
> hexagon target uses 'flex', 'bison' to generate idef-parser. However default
> travis builder image for 'focal' may not have these pre-installed, consequently
> following error is seen with travis when trying to execute the 'GCC (user)' job
> that also tries to build hexagon user binary:
>
> <snip>
> export CONFIG="--disable-containers --disable-system"
> <snip>
> Program flex found: NO
>
> ../target/hexagon/meson.build:179:4: ERROR: Program 'flex' not found or not
> executable
> <snip>
>
> Fix this by explicitly add 'flex' and 'bison' to the list of addon apt-packages
> for the 'GCC (user)' job.
>
> Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com>
> ---
> Changelog:
>
> Since v1:
> Link: https://lore.kernel.org/qemu-devel/20230414210645.820204-2-vaibhav@linux.ibm.com/
>
> - Added 'bison' also to the addon package list (Thomas)
> - Updated the patch description
> ---
> .travis.yml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/.travis.yml b/.travis.yml
> index 11894eb810..b958eca5de 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -237,6 +237,8 @@ jobs:
> - libglib2.0-dev
> - libgnutls28-dev
> - ninja-build
> + - flex
> + - bison
> env:
> - CONFIG="--disable-containers --disable-system"
Reviewed-by: Thomas Huth <thuth@redhat.com>
Thanks, queued it for my next pull request.
Thomas
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] travis.yml: Add missing 'flex','bison' packages to 'GCC (user)' job
2023-04-17 16:23 [PATCH v2] travis.yml: Add missing 'flex', 'bison' packages to 'GCC (user)' job Vaibhav Jain
2023-04-18 6:28 ` [PATCH v2] travis.yml: Add missing 'flex','bison' " Thomas Huth
@ 2023-04-20 9:23 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-04-20 9:23 UTC (permalink / raw)
To: Vaibhav Jain, qemu-devel
Cc: Alex Bennée, Thomas Huth, Wainer dos Santos Moschetta,
Beraldo Leal, Anton Johansson
On 17/4/23 18:23, Vaibhav Jain wrote:
> Since commit fd8171fe52b5e("target/hexagon: import lexer for idef-parser") the
> hexagon target uses 'flex', 'bison' to generate idef-parser. However default
> travis builder image for 'focal' may not have these pre-installed, consequently
> following error is seen with travis when trying to execute the 'GCC (user)' job
> that also tries to build hexagon user binary:
>
> <snip>
> export CONFIG="--disable-containers --disable-system"
> <snip>
> Program flex found: NO
>
> ../target/hexagon/meson.build:179:4: ERROR: Program 'flex' not found or not
> executable
> <snip>
>
> Fix this by explicitly add 'flex' and 'bison' to the list of addon apt-packages
> for the 'GCC (user)' job.
>
> Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> Changelog:
>
> Since v1:
> Link: https://lore.kernel.org/qemu-devel/20230414210645.820204-2-vaibhav@linux.ibm.com/
>
> - Added 'bison' also to the addon package list (Thomas)
> - Updated the patch description
> ---
> .travis.yml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/.travis.yml b/.travis.yml
> index 11894eb810..b958eca5de 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -237,6 +237,8 @@ jobs:
> - libglib2.0-dev
> - libgnutls28-dev
> - ninja-build
> + - flex
> + - bison
> env:
> - CONFIG="--disable-containers --disable-system"
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-20 9:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-17 16:23 [PATCH v2] travis.yml: Add missing 'flex', 'bison' packages to 'GCC (user)' job Vaibhav Jain
2023-04-18 6:28 ` [PATCH v2] travis.yml: Add missing 'flex','bison' " Thomas Huth
2023-04-20 9:23 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).