From: John Snow <jsnow@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] iotests: Replace assertEquals() with assertEqual()
Date: Tue, 20 Nov 2018 16:37:52 -0500 [thread overview]
Message-ID: <c96bff11-d143-c3ea-adc9-7cb6b6431984@redhat.com> (raw)
In-Reply-To: <20181120172252.17800-3-kwolf@redhat.com>
On 11/20/18 12:22 PM, Kevin Wolf wrote:
> TestCase.assertEquals() is deprecated since Python 2.7. Recent Python
> versions print a warning when the function is called, which makes test
> cases fail.
>
> Replace it with the preferred spelling assertEqual().
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
next prev parent reply other threads:[~2018-11-20 21:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 17:22 [Qemu-devel] [PATCH for-3.1 0/2] iotests: More Python 3 fixes Kevin Wolf
2018-11-20 17:22 ` [Qemu-devel] [PATCH 1/2] iotests: Replace time.clock() with Timeout Kevin Wolf
2018-11-20 20:16 ` Philippe Mathieu-Daudé
2018-11-20 21:36 ` [Qemu-devel] [Qemu-block] " John Snow
2018-11-20 17:22 ` [Qemu-devel] [PATCH 2/2] iotests: Replace assertEquals() with assertEqual() Kevin Wolf
2018-11-20 20:17 ` Philippe Mathieu-Daudé
2018-11-20 21:37 ` John Snow [this message]
2018-11-20 21:54 ` [Qemu-devel] [PATCH for-3.1 0/2] iotests: More Python 3 fixes Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c96bff11-d143-c3ea-adc9-7cb6b6431984@redhat.com \
--to=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).