From: Richard Henderson <richard.henderson@linaro.org>
To: Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [RFC PATCH] configure: Do not add --warn-common to the linker flags anymore
Date: Tue, 25 May 2021 16:22:40 -0700 [thread overview]
Message-ID: <c98d9300-c0dc-c0bd-7b78-009c5fb1986d@linaro.org> (raw)
In-Reply-To: <20210525111149.131222-1-thuth@redhat.com>
On 5/25/21 4:11 AM, Thomas Huth wrote:
> We are compiling with -fno-common since commit 4c288acbd6 ("configure:
> Always build with -fno-common"), so --warn-common (which had been added
> in commit 49237acdb725e in 2008 already) should not be necessary anymore
> nowadays.
>
> Signed-off-by: Thomas Huth<thuth@redhat.com>
> ---
> Marked as RFC since I'm not 100% sure whether I'm missing here something...
> but IMHO the --warn-common does not buy us anything if we also compile
> with -fno-common...
I agree.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2021-05-25 23:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 11:11 [RFC PATCH] configure: Do not add --warn-common to the linker flags anymore Thomas Huth
2021-05-25 23:22 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c98d9300-c0dc-c0bd-7b78-009c5fb1986d@linaro.org \
--to=richard.henderson@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).