Re: [Qemu-devel] [PATCH v9 00/11] Build ACPI Heterogeneous Memory Attribute Table (HMAT)

[Tao Xu <tao3.xu@intel.com>]

Hi Igor and Eduardo,

I am wondering if there are more comments about patch 1/11~4/11? Because 
these 4 patch are independent and the patch series are big and pushing 
for a long time. Could the patch 1/11~4/11 be ready for queuing firstly?

If there is anything else need me to do about this series, please tell me.

Tao

On 8/9/2019 2:57 PM, Tao wrote:
> This series of patches will build Heterogeneous Memory Attribute Table (HMAT)
> according to the command line. The ACPI HMAT describes the memory attributes,
> such as memory side cache attributes and bandwidth and latency details,
> related to the Memory Proximity Domain.
> The software is expected to use HMAT information as hint for optimization.
> 
> In the linux kernel, the codes in drivers/acpi/hmat/hmat.c parse and report
> the platform's HMAT tables.
> 
> The V8 patches link:
> https://patchwork.kernel.org/cover/11066983/
> 
> Changelog:
> v9:
>      - change the CLI input way, make it more user firendly (Daniel Black)
>      use latency=NUM[p|n|u]s and bandwidth=NUM[M|G|P](B/s) as input and drop
>      the base-lat and base-bw input.
> v8:
>      - rebase to upstream
>      - Add check if numa->numa_state is NULL in pxb_dev_realize_common
>      - Use nb_nodes in spapr_populate_memory() (RESEND to fix) (Igor)
> v7:
>      - Defer 11-13 of patch v6, because the driver of _HMA hasn't been
>        implemented in kernel driver
>      - Drop the HMAT_LB_MEM_CACHE_LAST_LEVEL which is not used in
>        ACPI 6.3 (Jonathan)
>      - Add bit mask in flags of hmat-lb (Jonathan)
>      - Add a marco to indicate the type is latency or bandwidth (Jonathan)
> 
> Liu Jingqi (5):
>    hmat acpi: Build Memory Proximity Domain Attributes Structure(s)
>    hmat acpi: Build System Locality Latency and Bandwidth Information
>      Structure(s)
>    hmat acpi: Build Memory Side Cache Information Structure(s)
>    numa: Extend the CLI to provide memory latency and bandwidth
>      information
>    numa: Extend the CLI to provide memory side cache information
> 
> Tao Xu (6):
>    hw/arm: simplify arm_load_dtb
>    numa: move numa global variable nb_numa_nodes into MachineState
>    numa: move numa global variable have_numa_distance into MachineState
>    numa: move numa global variable numa_info into MachineState
>    numa: Extend CLI to provide initiator information for numa nodes
>    tests/bios-tables-test: add test cases for ACPI HMAT
> 
>   exec.c                              |   5 +-
>   hw/acpi/Kconfig                     |   5 +
>   hw/acpi/Makefile.objs               |   1 +
>   hw/acpi/aml-build.c                 |   9 +-
>   hw/acpi/hmat.c                      | 256 +++++++++++++++++++++
>   hw/acpi/hmat.h                      | 106 +++++++++
>   hw/arm/aspeed.c                     |   5 +-
>   hw/arm/boot.c                       |  20 +-
>   hw/arm/collie.c                     |   8 +-
>   hw/arm/cubieboard.c                 |   5 +-
>   hw/arm/exynos4_boards.c             |   7 +-
>   hw/arm/highbank.c                   |   8 +-
>   hw/arm/imx25_pdk.c                  |   5 +-
>   hw/arm/integratorcp.c               |   8 +-
>   hw/arm/kzm.c                        |   5 +-
>   hw/arm/mainstone.c                  |   5 +-
>   hw/arm/mcimx6ul-evk.c               |   5 +-
>   hw/arm/mcimx7d-sabre.c              |   5 +-
>   hw/arm/musicpal.c                   |   8 +-
>   hw/arm/nseries.c                    |   5 +-
>   hw/arm/omap_sx1.c                   |   5 +-
>   hw/arm/palm.c                       |  10 +-
>   hw/arm/raspi.c                      |   6 +-
>   hw/arm/realview.c                   |   5 +-
>   hw/arm/sabrelite.c                  |   5 +-
>   hw/arm/sbsa-ref.c                   |  12 +-
>   hw/arm/spitz.c                      |   5 +-
>   hw/arm/tosa.c                       |   8 +-
>   hw/arm/versatilepb.c                |   5 +-
>   hw/arm/vexpress.c                   |   5 +-
>   hw/arm/virt-acpi-build.c            |  19 +-
>   hw/arm/virt.c                       |  17 +-
>   hw/arm/xilinx_zynq.c                |   8 +-
>   hw/arm/xlnx-versal-virt.c           |   7 +-
>   hw/arm/xlnx-zcu102.c                |   5 +-
>   hw/arm/z2.c                         |   8 +-
>   hw/core/machine-hmp-cmds.c          |  12 +-
>   hw/core/machine.c                   |  38 ++-
>   hw/core/numa.c                      | 345 +++++++++++++++++++++++++---
>   hw/i386/acpi-build.c                |   7 +-
>   hw/i386/pc.c                        |  13 +-
>   hw/mem/pc-dimm.c                    |   2 +
>   hw/pci-bridge/pci_expander_bridge.c |   8 +-
>   hw/ppc/spapr.c                      |  29 +--
>   hw/ppc/spapr_pci.c                  |   4 +-
>   include/hw/acpi/aml-build.h         |   2 +-
>   include/hw/arm/boot.h               |   4 +-
>   include/hw/boards.h                 |   1 +
>   include/qemu/typedefs.h             |   2 +
>   include/sysemu/numa.h               |  30 ++-
>   include/sysemu/sysemu.h             |  23 ++
>   qapi/machine.json                   | 178 +++++++++++++-
>   qemu-options.hx                     |  83 ++++++-
>   tests/bios-tables-test.c            |  43 ++++
>   54 files changed, 1189 insertions(+), 246 deletions(-)
>   create mode 100644 hw/acpi/hmat.c
>   create mode 100644 hw/acpi/hmat.h
>