From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Peter Xu <peterx@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH v3 2/8] cpus: Move do_run_on_cpu into softmmu/cpus.c
Date: Wed, 28 Jul 2021 20:35:15 +0200 [thread overview]
Message-ID: <c9a2d8d8-e8b0-71dc-bb67-468e2525f048@redhat.com> (raw)
In-Reply-To: <20210728183151.195139-3-peterx@redhat.com>
On 7/28/21 8:31 PM, Peter Xu wrote:
> It's only used by softmmu binaries not linux-user ones. Make it static and
> drop the definition in the header too.
>
> Since at it, initialize variable "wi" with less loc.
>
> Reviewed-by: David Hildenbrand <david@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> cpus-common.c | 25 -------------------------
> include/hw/core/cpu.h | 12 ------------
> softmmu/cpus.c | 23 +++++++++++++++++++++++
> 3 files changed, 23 insertions(+), 37 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2021-07-28 18:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 18:31 [PATCH v3 0/8] memory: Sanity checks memory transaction when releasing BQL Peter Xu
2021-07-28 18:31 ` [PATCH v3 1/8] cpus: Export queue work related fields to cpu.h Peter Xu
2021-07-28 18:40 ` Philippe Mathieu-Daudé
2021-07-28 18:31 ` [PATCH v3 2/8] cpus: Move do_run_on_cpu into softmmu/cpus.c Peter Xu
2021-07-28 18:35 ` Philippe Mathieu-Daudé [this message]
2021-07-28 18:31 ` [PATCH v3 3/8] memory: Introduce memory_region_transaction_depth_{inc|dec}() Peter Xu
2021-07-28 20:06 ` David Hildenbrand
2021-07-28 18:31 ` [PATCH v3 4/8] memory: Don't do topology update in memory finalize() Peter Xu
2021-07-28 18:31 ` [PATCH v3 5/8] cpus: Use qemu_cond_wait_iothread() where proper Peter Xu
2021-07-28 18:38 ` Philippe Mathieu-Daudé
2021-07-28 18:31 ` [PATCH v3 6/8] cpus: Remove the mutex parameter from do_run_on_cpu() Peter Xu
2021-07-28 18:39 ` Philippe Mathieu-Daudé
2021-07-28 18:31 ` [PATCH v3 7/8] memory: Assert on no ongoing memory transaction before release BQL Peter Xu
2021-07-28 18:31 ` [PATCH v3 8/8] memory: Delay the transaction pop() until commit completed Peter Xu
2021-09-08 15:30 ` [PATCH v3 0/8] memory: Sanity checks memory transaction when releasing BQL Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9a2d8d8-e8b0-71dc-bb67-468e2525f048@redhat.com \
--to=philmd@redhat.com \
--cc=david@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).