From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42958C4743C for ; Mon, 21 Jun 2021 14:48:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A4297606A5 for ; Mon, 21 Jun 2021 14:48:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4297606A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lvLED-0002YQ-KX for qemu-devel@archiver.kernel.org; Mon, 21 Jun 2021 10:48:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvLBm-00019P-47; Mon, 21 Jun 2021 10:46:14 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:6802) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvLBj-0004dL-Lm; Mon, 21 Jun 2021 10:46:13 -0400 Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 15LEY7nK072952; Mon, 21 Jun 2021 10:46:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=content-type : date : from : to : cc : subject : in-reply-to : references : message-id : content-transfer-encoding : mime-version; s=pp1; bh=Oigs2SneyNHO7hqNxhxSTKcGLrv+m08Ln9urxerGnwg=; b=pLFyWqvodHxZ6QmYGyt+8EvWUyW60FRZNt8mSjmAG8iYeJm0FiCtQ/2egGZj0cGWIQqz hn+L3/1ctSAgK/0jl8yAHX8MZ5uPCigu0UXTicDdhE05N6yIXQANAFZ6lXOeM+xLXOsn atOT70uqy47yoKyDAeGJX1tAtxCpPs/i0rnjb2mt0XSuk0o2zksW9NhGr9JRemBtApJY EfN21w2KFYsgXY1klyvMRDv7MR6pTmCKUcFT6uIpkUC2EHGiUYYGS8nCUtBUxNcI8S2X 4Pt482m/X3ucP65Pi7kDOrXvoaEpS6rAmwRRq+BlGPm0gwqUxDyyQ0N3cU6j21+3vuom vw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 39auaubjtu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 21 Jun 2021 10:46:08 -0400 Received: from m0187473.ppops.net (m0187473.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 15LEZ3x6077479; Mon, 21 Jun 2021 10:46:08 -0400 Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com with ESMTP id 39auaubjt4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 21 Jun 2021 10:46:08 -0400 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 15LEgXJs028880; Mon, 21 Jun 2021 14:46:07 GMT Received: from b01cxnp23034.gho.pok.ibm.com (b01cxnp23034.gho.pok.ibm.com [9.57.198.29]) by ppma01dal.us.ibm.com with ESMTP id 399879bwk7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 21 Jun 2021 14:46:07 +0000 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 15LEk6kU34079204 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 21 Jun 2021 14:46:06 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 69C40124055; Mon, 21 Jun 2021 14:46:06 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EC7C312405A; Mon, 21 Jun 2021 14:46:05 +0000 (GMT) Received: from ltc.linux.ibm.com (unknown [9.10.229.42]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 21 Jun 2021 14:46:05 +0000 (GMT) Content-Type: text/plain; charset=UTF-8; format=flowed Date: Mon, 21 Jun 2021 10:46:05 -0400 From: "jonathan.albrecht" To: Ilya Leoshkevich Subject: Re: [PATCH v3 0/2] target/s390x: Fix SIGILL psw.addr reporting Organization: IBM In-Reply-To: References: <20210602002210.3144559-1-iii@linux.ibm.com> <972102fd-ac1e-f13c-7aa7-ad6c7a9be67e@redhat.com> <095e6342f7f93b6d157f5a3cb99980a96990c290.camel@linux.ibm.com> Message-ID: X-Sender: jonathan.albrecht@linux.vnet.ibm.com User-Agent: Roundcube Webmail/1.1.12 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: -yWa0QBOB_1v6qiY8JAGafM7HgN_fdSz X-Proofpoint-ORIG-GUID: ACwok5flcHeNsK8cGYNRLwfmwUshXdg0 Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-06-21_06:2021-06-21, 2021-06-21 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 adultscore=0 spamscore=0 clxscore=1015 priorityscore=1501 mlxlogscore=999 malwarescore=0 suspectscore=0 lowpriorityscore=0 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2106210086 Received-SPF: none client-ip=148.163.156.1; envelope-from=jonathan.albrecht@linux.vnet.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-s390x , David Hildenbrand , Cornelia Huck , Richard Henderson , qemu-devel@nongnu.org, Laurent Vivier , Christian Borntraeger , qemu-s390x@nongnu.org, Andreas Krebbel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2021-06-21 9:44 am, Ilya Leoshkevich wrote: > On Mon, 2021-06-21 at 09:12 -0400, jonathan.albrecht wrote: >> On 2021-06-21 8:00 am, Ilya Leoshkevich wrote: >> > On Thu, 2021-06-10 at 11:49 +0200, David Hildenbrand wrote: >> > > On 02.06.21 02:22, Ilya Leoshkevich wrote: >> > > > qemu-s390x puts a wrong value into SIGILL's siginfo_t's >> > > > psw.addr: >> > > > it >> > > > should be a pointer to the instruction following the illegal >> > > > instruction, but at the moment it is a pointer to the illegal >> > > > instruction itself. This breaks OpenJDK, which relies on this >> > > > value. >> > > > >> > > > Patch 1 fixes the issue, patch 2 adds a test. >> > > > >> > > > v1: >> > > > https://lists.nongnu.org/archive/html/qemu-devel/2021-05/msg06592.html >> > > > v1 -> v2: Use a better buglink (Cornelia), simplify the inline >> > > > asm >> > > >            magic in the test and add an explanation (David). >> > > > >> > > > v2: >> > > > https://lists.nongnu.org/archive/html/qemu-devel/2021-05/msg06649.html >> > > > v2 -> v3: Fix SIGSEGV handling (found when trying to run >> > > > valgrind >> > > > under >> > > >            qemu-user). >> > > > >> > > >> > > There might still be something wrong: >> > > >> > > https://gitlab.com/qemu-project/qemu/-/issues/319 >> > > >> > > At least it smells like some more signal (mis)handling. >> > > >> > > >> > >> > I've taken another look, and it must be compare-and-trap >> > SIGFPE/SIGILL >> > mixup. I think I will just fix it here in v4. >> >> Yes, I've been looking at it too and found it is a compare-and-trap >> SIGFPE/SIGILL mixup. I was about to send out a patch if you want >> to wait. I should be able to send it out in an hour. >> >> Jon > > Sure, please go ahead. I'll simply rebase my v4 on top of your patch > then. > > Best regards, > Ilya Yes, please add it to your v4 if it looks ok. Jon