From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>,
Paul Burton <paulburton@kernel.org>
Subject: Re: [PATCH for-5.2] hw/mips/boston.c: Fix memory leak in boston_fdt_filter() error-handling paths
Date: Mon, 9 Nov 2020 00:13:15 +0100 [thread overview]
Message-ID: <c9c2023a-fa95-33e2-0ae2-265b2e398f84@amsat.org> (raw)
In-Reply-To: <20201106175823.1650-1-peter.maydell@linaro.org>
On 11/6/20 6:58 PM, Peter Maydell wrote:
> Coverity points out that the error-handling paths in the
> boston_fdt_filter() function don't free the fdt that was allocated.
> Fix the leak by using g_autofree.
>
> Fixes: Coverity CID 1432275
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/mips/boston.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
Thanks, applied to mips-fixes.
prev parent reply other threads:[~2020-11-08 23:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 17:58 [PATCH for-5.2] hw/mips/boston.c: Fix memory leak in boston_fdt_filter() error-handling paths Peter Maydell
2020-11-06 18:38 ` Philippe Mathieu-Daudé
2020-11-08 23:13 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9c2023a-fa95-33e2-0ae2-265b2e398f84@amsat.org \
--to=f4bug@amsat.org \
--cc=aleksandar.rikalo@syrmia.com \
--cc=paulburton@kernel.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).