qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH v5 04/11] rules.mak: Add strequal() and startwith() and rules
Date: Fri, 5 Jun 2020 09:42:07 +0200	[thread overview]
Message-ID: <c9d8b7dd-9c3f-a21a-aa82-c2346efb3474@redhat.com> (raw)
In-Reply-To: <20200605073953.19268-5-philmd@redhat.com>

Err extra 'and' in patch subject, should be:
"rules.mak: Add strequal() and startwith() rules"

I can respin the whole if it is easier for the maintainer.

On 6/5/20 9:39 AM, Philippe Mathieu-Daudé wrote:
> Add a rule to test if two strings are equal,
> and another to test if a string starts with a substring,
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  rules.mak | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/rules.mak b/rules.mak
> index 694865b63e..ccc1c49604 100644
> --- a/rules.mak
> +++ b/rules.mak
> @@ -191,6 +191,20 @@ ne = $(if $(subst $2,,$1)$(subst $1,,$2),y,n)
>  isempty = $(if $1,n,y)
>  notempty = $(if $1,y,n)
>  
> +# strequal
> +# Usage: $(call strequal, str1, str2)
> +#
> +# This macro returns a string (TRUE) when @str1 and @str2
> +# are equal, else returns the empty string (FALSE)
> +strequal = $(if $(subst $2,,$1)$(subst $1,,$2),,$1)
> +
> +# startwith
> +# Usage: $(call startwith, startstr, fullstr)
> +#
> +# This macro returns a string (TRUE) when @fullstr starts with
> +# @startstr, else returns the empty string (FALSE)
> +startwith = $(findstring :$1,:$2)
> +
>  # Generate files with tracetool
>  TRACETOOL=$(PYTHON) $(SRC_PATH)/scripts/tracetool.py
>  
> 



  reply	other threads:[~2020-06-05  7:48 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-05  7:39 [PATCH v5 00/11] accel: Allow targets to use Kconfig Philippe Mathieu-Daudé
2020-06-05  7:39 ` [PATCH v5 01/11] MAINTAINERS: Fix KVM path expansion glob Philippe Mathieu-Daudé
2020-06-05  7:39 ` [PATCH v5 02/11] MAINTAINERS: Add an 'overall' entry for accelerators Philippe Mathieu-Daudé
2020-06-05  7:39 ` [PATCH v5 03/11] MAINTAINERS: Add an entry for the HAX accelerator Philippe Mathieu-Daudé
2020-06-05  8:35   ` Philippe Mathieu-Daudé
2020-06-05  7:39 ` [PATCH v5 04/11] rules.mak: Add strequal() and startwith() and rules Philippe Mathieu-Daudé
2020-06-05  7:42   ` Philippe Mathieu-Daudé [this message]
2020-06-05 12:48   ` Markus Armbruster
2020-06-05 12:53     ` Philippe Mathieu-Daudé
2020-06-05  7:39 ` [PATCH v5 05/11] rules.mak: Add base-arch() rule Philippe Mathieu-Daudé
2020-06-05  7:39 ` [PATCH v5 06/11] Makefile: Remove dangerous EOL trailing backslash Philippe Mathieu-Daudé
2020-06-05  7:39 ` [PATCH v5 07/11] Makefile: Write MINIKCONF variables as one entry per line Philippe Mathieu-Daudé
2020-06-05  7:39 ` [PATCH v5 08/11] accel/Kconfig: Extract accel selectors into their own config Philippe Mathieu-Daudé
2020-06-05  7:39 ` [PATCH v5 09/11] accel/Kconfig: Add the TCG selector Philippe Mathieu-Daudé
2020-06-05  7:39 ` [PATCH v5 10/11] Makefile: Allow target-specific optional Kconfig Philippe Mathieu-Daudé
2020-06-05  7:39 ` [PATCH v5 11/11] accel/tcg: Add stub for probe_access() Philippe Mathieu-Daudé
2020-06-05  7:45   ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9d8b7dd-9c3f-a21a-aa82-c2346efb3474@redhat.com \
    --to=philmd@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).