From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [PATCH] target/mips: Remove XBurst Media eXtension Unit dead code
Date: Wed, 17 Feb 2021 11:27:51 -0800 [thread overview]
Message-ID: <c9d92acc-af2b-ff72-7337-30f05c1a95c8@linaro.org> (raw)
In-Reply-To: <20210217185848.1421360-1-f4bug@amsat.org>
On 2/17/21 10:58 AM, Philippe Mathieu-Daudé wrote:
> All these unimplemented MXU opcodes end up calling
> gen_reserved_instruction() which is the default switch
> case in decode_opc_mxu().
>
> The translate.c file is already big enough and hard to maintain,
> remove 1k+ lines of unnecessary code and /* TODO */ comments.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> Maybe better to review using 'git-diff --function-context'
> ---
> target/mips/translate.c | 1055 ---------------------------------------
> 1 file changed, 1055 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2021-02-17 19:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 18:58 [PATCH] target/mips: Remove XBurst Media eXtension Unit dead code Philippe Mathieu-Daudé
2021-02-17 19:27 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9d92acc-af2b-ff72-7337-30f05c1a95c8@linaro.org \
--to=richard.henderson@linaro.org \
--cc=aleksandar.rikalo@syrmia.com \
--cc=aurelien@aurel32.net \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).