Re: [PATCH] configure: Require Python >= 3.5

[John Snow <jsnow@redhat.com>]

On 10/17/19 7:21 AM, Kevin Wolf wrote:
> Am 17.10.2019 um 00:48 hat John Snow geschrieben:
>>
>>
>> On 10/16/19 6:42 PM, Eduardo Habkost wrote:
>>> Python 3.5 is the oldest Python version available on our
>>> supported build platforms, and Python 2 end of life will be 3
>>> weeks after the planned release date of QEMU 4.2.0.  Drop Python
>>> 2 support from configure completely, and require Python 3.5 or
>>> newer.
>>>
>>> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
>>
>> Seems like a good time and place to mention this. Kevin, you require
>> 3.6+ for iotests, which are -- at present -- invoked as part of "make
>> check".
>>
>> Do we care? Basically, this just means that iotests won't run for
>> systems that don't have 3.6+, which would be platforms like Debian 9 --
>> which is why ehabkost is choosing 3.5 here.
> 
> I think we were aware of this when we made the change to iotests. That
> all tests of the current upstream QEMU version are run on Debian
> oldstable (with the distro Python version) is, to say the least, not a
> priority for me. They must not fail, but I'd say skipping is fine.
> 
> And actually, we should still have a reasonable coverage there with the
> shell-based test cases.
> 
> Kevin
> 

This seems like a weirdly arbitrary decision for a benefit that's not
clear to me. Is it because you want variable annotations?

(Well, regardless, you're the ranger in charge of this forest.)