From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Xu <peterx@redhat.com>, qemu-devel@nongnu.org
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Igor Mammedov <imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/4] q35: set split kernel irqchip as default
Date: Wed, 19 Dec 2018 21:12:55 +0100 [thread overview]
Message-ID: <c9e56e11-214f-552a-faea-cb5901392164@redhat.com> (raw)
In-Reply-To: <20181219085038.7729-3-peterx@redhat.com>
On 19/12/18 09:50, Peter Xu wrote:
> Starting from QEMU 4.0, let's specify "split" as the default value for
> kernel-irqchip.
>
> So for QEMU>=4.0 we'll have: allowed=Y,required=N,split=Y
> for QEMU<=3.1 we'll have: allowed=Y,required=N,split=N
> (omitting all the "kernel_irqchip_" prefix)
>
> Note that this "split" is optional - we'll first try to enable split
> kernel irqchip, and we'll fall back to complete kernel irqchip if we
> found that the kernel capability is missing.
Please just fail completely and require a new kernel for the 4.0 machine
type. There are subtle differences between kernel and QEMU irqchip, I
don't think we want to open that can of worms.
Paolo
next prev parent reply other threads:[~2018-12-19 20:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 8:50 [Qemu-devel] [PATCH 0/4] q35: change defaults for kernel irqchip and IR Peter Xu
2018-12-19 8:50 ` [Qemu-devel] [PATCH 1/4] kvm: let split be optional for kvm_arch_irqchip_create Peter Xu
2018-12-19 15:53 ` Michael S. Tsirkin
2018-12-19 20:15 ` Paolo Bonzini
2018-12-19 8:50 ` [Qemu-devel] [PATCH 2/4] q35: set split kernel irqchip as default Peter Xu
2018-12-19 15:52 ` Michael S. Tsirkin
2018-12-19 20:16 ` Paolo Bonzini
2018-12-19 20:12 ` Paolo Bonzini [this message]
2018-12-19 21:24 ` Eduardo Habkost
2018-12-19 21:45 ` Paolo Bonzini
2018-12-20 5:31 ` Peter Xu
2018-12-19 8:50 ` [Qemu-devel] [PATCH 3/4] x86-iommu: switch intr_supported to OnOffAuto type Peter Xu
2018-12-19 8:50 ` [Qemu-devel] [PATCH 4/4] x86-iommu: turn on IR by default if proper Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9e56e11-214f-552a-faea-cb5901392164@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).