From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2EDB8C001B0 for ; Mon, 7 Aug 2023 09:55:12 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qSwx6-0000JO-Sl; Mon, 07 Aug 2023 05:55:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSwx3-000080-LZ for qemu-devel@nongnu.org; Mon, 07 Aug 2023 05:55:02 -0400 Received: from mail.xen0n.name ([115.28.160.31] helo=mailbox.box.xen0n.name) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qSwwz-0004aL-Rl for qemu-devel@nongnu.org; Mon, 07 Aug 2023 05:55:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xen0n.name; s=mail; t=1691402087; bh=SOn0hTrdzpePUIg6aiO1CxwL6/chkRK5ZVKAKEpWGEw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=k2OaMu7Hz0CjYJ8XHbD2Zgzq3D/ADxw3aJZKMghOdg+9MhcZu1B0qNXomTVgBaPtf c8dHiYYMlbGB2DlzV/3lDM+v5JJV52LtcIyMr1S0QzwJMk6ZyGhAwBjZcbx0LnuxOO rRPQ+YFpeA3gP3jtSSWpE9G9WFDS0IRcwyutERqc= Received: from [100.100.34.13] (unknown [220.248.53.61]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailbox.box.xen0n.name (Postfix) with ESMTPSA id B018A6011C; Mon, 7 Aug 2023 17:54:47 +0800 (CST) Message-ID: Date: Mon, 7 Aug 2023 17:54:46 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v3 2/6] target/loongarch: Add loongarch32 cpu la132 Content-Language: en-US To: Jiajie Chen , qemu-devel@nongnu.org Cc: richard.henderson@linaro.org, yijun@loongson.cn, shenjinyang@loongson.cn, Xiaojuan Yang , Song Gao References: <20230807094505.2030603-1-c@jia.je> <20230807094505.2030603-3-c@jia.je> From: WANG Xuerui In-Reply-To: <20230807094505.2030603-3-c@jia.je> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=115.28.160.31; envelope-from=i.qemu@xen0n.name; helo=mailbox.box.xen0n.name X-Spam_score_int: -61 X-Spam_score: -6.2 X-Spam_bar: ------ X-Spam_report: (-6.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-4.139, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi, On 2023/8/7 17:45, Jiajie Chen wrote: > Add la132 as a loongarch32 cpu type and allow virt machine to be used > with la132 instead of la464. > > Signed-off-by: Jiajie Chen > --- > hw/loongarch/virt.c | 5 ----- > target/loongarch/cpu.c | 41 +++++++++++++++++++++++++++++++++++++++++ > target/loongarch/cpu.h | 11 +++++++++++ > 3 files changed, 52 insertions(+), 5 deletions(-) > > diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c > index e19b042ce8..af15bf5aaa 100644 > --- a/hw/loongarch/virt.c > +++ b/hw/loongarch/virt.c > @@ -798,11 +798,6 @@ static void loongarch_init(MachineState *machine) > cpu_model = LOONGARCH_CPU_TYPE_NAME("la464"); > } > > - if (!strstr(cpu_model, "la464")) { > - error_report("LoongArch/TCG needs cpu type la464"); > - exit(1); > - } > - > if (ram_size < 1 * GiB) { > error_report("ram_size must be greater than 1G."); > exit(1); > diff --git a/target/loongarch/cpu.c b/target/loongarch/cpu.c > index ad93ecac92..d31efe86da 100644 > --- a/target/loongarch/cpu.c > +++ b/target/loongarch/cpu.c > @@ -362,6 +362,8 @@ static void loongarch_la464_initfn(Object *obj) > CPULoongArchState *env = &cpu->env; > int i; > > + env->mode = LA64; > + > for (i = 0; i < 21; i++) { > env->cpucfg[i] = 0x0; > } > @@ -439,6 +441,20 @@ static void loongarch_la464_initfn(Object *obj) > env->CSR_ASID = FIELD_DP64(0, CSR_ASID, ASIDBITS, 0xa); > } > > +static void loongarch_la132_initfn(Object *obj) > +{ > + LoongArchCPU *cpu = LOONGARCH_CPU(obj); > + CPULoongArchState *env = &cpu->env; > + > + env->mode = LA32; > + > + cpu->dtb_compatible = "loongarch,Loongson-3C103"; "3C103"? I assume you want something like "1C300" or "1Axxx", at least something prefixed with "1"...