From: Thomas Huth <thuth@redhat.com>
To: Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org
Cc: lvivier@redhat.com, dgilbert@redhat.com, peterx@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 02/22] config: CONFIG_SERIAL* is already in pci.mak
Date: Wed, 8 Aug 2018 14:00:32 +0200 [thread overview]
Message-ID: <ca087b01-80d8-16cf-9b9a-b4b56e3e66e8@redhat.com> (raw)
In-Reply-To: <20180808114830.7169-3-quintela@redhat.com>
On 08/08/2018 01:48 PM, Juan Quintela wrote:
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
> default-configs/alpha-softmmu.mak | 2 --
> default-configs/arm-softmmu.mak | 2 --
> default-configs/hppa-softmmu.mak | 3 ---
> default-configs/i386-softmmu.mak | 2 --
> default-configs/mips-softmmu-common.mak | 2 --
> default-configs/ppc-softmmu.mak | 1 -
> default-configs/ppcemb-softmmu.mak | 2 --
> default-configs/sh4-softmmu.mak | 2 --
> default-configs/sh4eb-softmmu.mak | 2 --
> default-configs/sparc64-softmmu.mak | 2 --
> default-configs/x86_64-softmmu.mak | 2 --
> 11 files changed, 22 deletions(-)
>
> diff --git a/default-configs/alpha-softmmu.mak b/default-configs/alpha-softmmu.mak
> index bbe361f01a..2d81a98441 100644
> --- a/default-configs/alpha-softmmu.mak
> +++ b/default-configs/alpha-softmmu.mak
> @@ -2,8 +2,6 @@
>
> include pci.mak
> include usb.mak
> -CONFIG_SERIAL=y
> -CONFIG_SERIAL_ISA=y
> CONFIG_I82374=y
> CONFIG_I8254=y
> CONFIG_I8257=y
> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
> index 834d45cfaf..4d33e9983d 100644
> --- a/default-configs/arm-softmmu.mak
> +++ b/default-configs/arm-softmmu.mak
> @@ -5,8 +5,6 @@ include usb.mak
> CONFIG_VGA=y
> CONFIG_NAND=y
> CONFIG_ECC=y
> -CONFIG_SERIAL=y
> -CONFIG_SERIAL_ISA=y
> CONFIG_PTIMER=y
> CONFIG_SD=y
> CONFIG_MAX7310=y
> diff --git a/default-configs/hppa-softmmu.mak b/default-configs/hppa-softmmu.mak
> index 4badc0521e..f3712afc27 100644
> --- a/default-configs/hppa-softmmu.mak
> +++ b/default-configs/hppa-softmmu.mak
> @@ -1,8 +1,5 @@
> include pci.mak
> include usb.mak
> -CONFIG_SERIAL=y
> -CONFIG_SERIAL_ISA=y
> -CONFIG_ISA_BUS=y
You should maybe mention CONFIG_ISA_BUS in the patch description, too.
Apart from that nit:
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2018-08-08 12:00 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 11:48 [Qemu-devel] [RFC PATCH v2 00/22] More patches to disable stuff Juan Quintela
2018-08-08 11:48 ` [Qemu-devel] [PATCH v2 01/22] configure: We don't want to clean configuration files Juan Quintela
2018-08-08 11:48 ` [Qemu-devel] [PATCH v2 02/22] config: CONFIG_SERIAL* is already in pci.mak Juan Quintela
2018-08-08 12:00 ` Thomas Huth [this message]
2018-08-10 10:19 ` Paolo Bonzini
2018-08-10 11:06 ` Juan Quintela
2018-08-10 12:08 ` Paolo Bonzini
2018-08-14 11:40 ` Juan Quintela
2018-08-14 11:52 ` Paolo Bonzini
2018-08-14 12:06 ` Peter Maydell
2018-08-14 12:56 ` Paolo Bonzini
2018-08-14 12:57 ` Peter Maydell
2018-08-14 13:05 ` Paolo Bonzini
2018-08-14 13:31 ` Juan Quintela
2018-08-08 11:48 ` [Qemu-devel] [PATCH v2 03/22] check: Use land/lor when possible Juan Quintela
2018-08-08 11:48 ` [Qemu-devel] [PATCH v2 04/22] check: Only test isa-testdev when it is compiled in Juan Quintela
2018-08-08 12:03 ` Thomas Huth
2018-08-10 10:20 ` Paolo Bonzini
2018-08-10 11:08 ` Juan Quintela
2018-08-10 12:11 ` Paolo Bonzini
2018-08-10 15:17 ` Juan Quintela
2018-08-13 11:31 ` Paolo Bonzini
2018-08-08 11:48 ` [Qemu-devel] [PATCH v2 05/22] check: Only test usb-xhci-nec " Juan Quintela
2018-08-08 12:06 ` Thomas Huth
2018-08-08 17:02 ` Juan Quintela
2018-08-09 5:28 ` Thomas Huth
2018-08-08 11:48 ` [Qemu-devel] [PATCH v2 06/22] i386-softmmu: Configuration is identical to x86_64-softmmu Juan Quintela
2018-08-08 12:10 ` Thomas Huth
2018-08-08 16:59 ` Juan Quintela
2018-08-08 11:48 ` [Qemu-devel] [PATCH v2 07/22] check: Only test ivshm when it is compiled in Juan Quintela
2018-08-08 11:48 ` [Qemu-devel] [PATCH v2 08/22] check: Only test tpm devices when they are " Juan Quintela
2018-08-08 12:11 ` Thomas Huth
2018-08-08 11:48 ` [Qemu-devel] [PATCH v2 09/22] virtio: Remove unneeded includes Juan Quintela
2018-08-08 13:11 ` Thomas Huth
2018-08-09 19:03 ` Dr. David Alan Gilbert
2018-08-09 22:56 ` Michael S. Tsirkin
2018-08-10 7:34 ` Juan Quintela
2018-08-10 9:29 ` Michael S. Tsirkin
2018-08-10 10:01 ` Juan Quintela
2018-08-10 10:17 ` Michael S. Tsirkin
2018-08-10 11:08 ` Juan Quintela
2018-08-08 11:48 ` [Qemu-devel] [PATCH v2 10/22] virtio: split vsock bits from virtio-pci Juan Quintela
2018-08-08 12:18 ` Thomas Huth
2018-08-09 19:10 ` Dr. David Alan Gilbert
2018-08-08 11:48 ` [Qemu-devel] [PATCH v2 11/22] virtio: split host " Juan Quintela
2018-08-09 6:10 ` Thomas Huth
2018-08-24 13:00 ` Juan Quintela
2018-08-08 11:48 ` [Qemu-devel] [PATCH v2 12/22] virtio: split input " Juan Quintela
2018-08-09 6:17 ` Thomas Huth
2018-08-24 13:14 ` Juan Quintela
2018-08-08 11:48 ` [Qemu-devel] [PATCH v2 13/22] virtio: split rng " Juan Quintela
2018-08-09 6:22 ` Thomas Huth
2018-08-08 11:48 ` [Qemu-devel] [PATCH v2 14/22] virtio: split balloon " Juan Quintela
2018-08-15 15:32 ` Thomas Huth
2018-08-08 11:48 ` [Qemu-devel] [PATCH v2 15/22] virtio: split 9p " Juan Quintela
2018-08-15 15:37 ` Thomas Huth
2018-08-15 15:40 ` Thomas Huth
2018-08-08 11:48 ` [Qemu-devel] [PATCH v2 16/22] virtio: split vhost-user-blk " Juan Quintela
2018-08-15 15:40 ` Thomas Huth
2018-08-08 11:48 ` [Qemu-devel] [PATCH v2 17/22] virtio: split vhost-user-scsi " Juan Quintela
2018-08-15 16:18 ` Thomas Huth
2018-08-08 11:48 ` [Qemu-devel] [PATCH v2 18/22] virtio: split vhost-scsi " Juan Quintela
2018-08-15 16:21 ` Thomas Huth
2018-08-08 11:48 ` [Qemu-devel] [PATCH v2 19/22] virtio: split virtio-scsi " Juan Quintela
2018-08-15 16:30 ` Thomas Huth
2018-08-08 11:48 ` [Qemu-devel] [PATCH v2 20/22] virtio: split virtio-blk bits rom virtio-pci Juan Quintela
2018-08-16 7:12 ` Thomas Huth
2018-08-08 11:48 ` [Qemu-devel] [PATCH v2 21/22] virtio: split virtio-net " Juan Quintela
2018-08-16 7:14 ` Thomas Huth
2018-08-08 11:48 ` [Qemu-devel] [PATCH v2 22/22] virtio: split virtio-serial " Juan Quintela
2018-08-16 7:24 ` Thomas Huth
2018-08-10 10:22 ` [Qemu-devel] [RFC PATCH v2 00/22] More patches to disable stuff Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca087b01-80d8-16cf-9b9a-b4b56e3e66e8@redhat.com \
--to=thuth@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).