* [PATCH 0/5] hw: More DEVICE_ [NATIVE -> LITTLE] _ENDIAN conversions
@ 2025-02-12 11:39 Philippe Mathieu-Daudé
2025-02-12 11:39 ` [PATCH 1/5] hw/arm: Mark Allwinner Technology devices as little-endian Philippe Mathieu-Daudé
` (5 more replies)
0 siblings, 6 replies; 12+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-02-12 11:39 UTC (permalink / raw)
To: qemu-devel
Cc: Paul Burton, Jiaxun Yang, Huacai Chen, qemu-arm,
Philippe Mathieu-Daudé, Aleksandar Rikalo, Sunil Muthuswamy,
Peter Maydell, Beniamino Galvani, Strahinja Jankovic,
Alistair Francis, Jason Wang, Niek Linnenbank
When devices are only built for little-endian targets,
DEVICE_NATIVE_ENDIAN expand to DEVICE_LITTLE_ENDIAN.
Replace by the latter to simplify.
Philippe Mathieu-Daudé (5):
hw/arm: Mark Allwinner Technology devices as little-endian
hw/mips: Mark Boston machine devices as little-endian
hw/mips: Mark Loonson3 Virt machine devices as little-endian
hw/pci-host: Mark versatile regions as little-endian
target/i386: Mark WHPX APIC region as little-endian
hw/arm/allwinner-a10.c | 2 +-
hw/arm/allwinner-h3.c | 8 ++++----
hw/arm/allwinner-r40.c | 2 +-
hw/i2c/allwinner-i2c.c | 2 +-
hw/intc/allwinner-a10-pic.c | 2 +-
hw/mips/boston.c | 6 +++---
hw/mips/loongson3_virt.c | 4 ++--
hw/misc/allwinner-a10-ccm.c | 2 +-
hw/misc/allwinner-a10-dramc.c | 2 +-
hw/misc/allwinner-cpucfg.c | 2 +-
hw/misc/allwinner-h3-ccu.c | 2 +-
hw/misc/allwinner-h3-dramc.c | 6 +++---
hw/misc/allwinner-h3-sysctrl.c | 2 +-
hw/misc/allwinner-r40-ccu.c | 2 +-
hw/misc/allwinner-r40-dramc.c | 10 +++++-----
hw/misc/allwinner-sid.c | 2 +-
hw/misc/allwinner-sramc.c | 2 +-
hw/net/allwinner-sun8i-emac.c | 2 +-
hw/net/allwinner_emac.c | 2 +-
hw/pci-host/versatile.c | 4 ++--
hw/rtc/allwinner-rtc.c | 2 +-
hw/sd/allwinner-sdhost.c | 2 +-
hw/ssi/allwinner-a10-spi.c | 2 +-
hw/timer/allwinner-a10-pit.c | 2 +-
hw/watchdog/allwinner-wdt.c | 2 +-
target/i386/whpx/whpx-apic.c | 2 +-
26 files changed, 39 insertions(+), 39 deletions(-)
--
2.47.1
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH 1/5] hw/arm: Mark Allwinner Technology devices as little-endian 2025-02-12 11:39 [PATCH 0/5] hw: More DEVICE_ [NATIVE -> LITTLE] _ENDIAN conversions Philippe Mathieu-Daudé @ 2025-02-12 11:39 ` Philippe Mathieu-Daudé 2025-02-12 17:47 ` Richard Henderson 2025-02-12 11:39 ` [PATCH 2/5] hw/mips: Mark Boston machine " Philippe Mathieu-Daudé ` (4 subsequent siblings) 5 siblings, 1 reply; 12+ messages in thread From: Philippe Mathieu-Daudé @ 2025-02-12 11:39 UTC (permalink / raw) To: qemu-devel Cc: Paul Burton, Jiaxun Yang, Huacai Chen, qemu-arm, Philippe Mathieu-Daudé, Aleksandar Rikalo, Sunil Muthuswamy, Peter Maydell, Beniamino Galvani, Strahinja Jankovic, Alistair Francis, Jason Wang, Niek Linnenbank These devices are only used by the ARM targets, which are only built as little-endian. Therefore the DEVICE_NATIVE_ENDIAN definition expand to DEVICE_LITTLE_ENDIAN (besides, the DEVICE_BIG_ENDIAN case isn't tested). Simplify directly using DEVICE_LITTLE_ENDIAN. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- hw/arm/allwinner-a10.c | 2 +- hw/arm/allwinner-h3.c | 8 ++++---- hw/arm/allwinner-r40.c | 2 +- hw/i2c/allwinner-i2c.c | 2 +- hw/intc/allwinner-a10-pic.c | 2 +- hw/misc/allwinner-a10-ccm.c | 2 +- hw/misc/allwinner-a10-dramc.c | 2 +- hw/misc/allwinner-cpucfg.c | 2 +- hw/misc/allwinner-h3-ccu.c | 2 +- hw/misc/allwinner-h3-dramc.c | 6 +++--- hw/misc/allwinner-h3-sysctrl.c | 2 +- hw/misc/allwinner-r40-ccu.c | 2 +- hw/misc/allwinner-r40-dramc.c | 10 +++++----- hw/misc/allwinner-sid.c | 2 +- hw/misc/allwinner-sramc.c | 2 +- hw/net/allwinner-sun8i-emac.c | 2 +- hw/net/allwinner_emac.c | 2 +- hw/rtc/allwinner-rtc.c | 2 +- hw/sd/allwinner-sdhost.c | 2 +- hw/ssi/allwinner-a10-spi.c | 2 +- hw/timer/allwinner-a10-pit.c | 2 +- hw/watchdog/allwinner-wdt.c | 2 +- 22 files changed, 31 insertions(+), 31 deletions(-) diff --git a/hw/arm/allwinner-a10.c b/hw/arm/allwinner-a10.c index a829913f1b5..f1b399759a1 100644 --- a/hw/arm/allwinner-a10.c +++ b/hw/arm/allwinner-a10.c @@ -158,7 +158,7 @@ static void aw_a10_realize(DeviceState *dev, Error **errp) /* FIXME use a qdev chardev prop instead of serial_hd() */ serial_mm_init(get_system_memory(), AW_A10_UART0_REG_BASE, 2, qdev_get_gpio_in(dev, 1), - 115200, serial_hd(0), DEVICE_NATIVE_ENDIAN); + 115200, serial_hd(0), DEVICE_LITTLE_ENDIAN); for (size_t i = 0; i < AW_A10_NUM_USB; i++) { g_autofree char *bus = g_strdup_printf("usb-bus.%zu", i); diff --git a/hw/arm/allwinner-h3.c b/hw/arm/allwinner-h3.c index 2efced3f66a..1b1afa4fb6f 100644 --- a/hw/arm/allwinner-h3.c +++ b/hw/arm/allwinner-h3.c @@ -408,19 +408,19 @@ static void allwinner_h3_realize(DeviceState *dev, Error **errp) /* UART0. For future clocktree API: All UARTS are connected to APB2_CLK. */ serial_mm_init(get_system_memory(), s->memmap[AW_H3_DEV_UART0], 2, qdev_get_gpio_in(DEVICE(&s->gic), AW_H3_GIC_SPI_UART0), - 115200, serial_hd(0), DEVICE_NATIVE_ENDIAN); + 115200, serial_hd(0), DEVICE_LITTLE_ENDIAN); /* UART1 */ serial_mm_init(get_system_memory(), s->memmap[AW_H3_DEV_UART1], 2, qdev_get_gpio_in(DEVICE(&s->gic), AW_H3_GIC_SPI_UART1), - 115200, serial_hd(1), DEVICE_NATIVE_ENDIAN); + 115200, serial_hd(1), DEVICE_LITTLE_ENDIAN); /* UART2 */ serial_mm_init(get_system_memory(), s->memmap[AW_H3_DEV_UART2], 2, qdev_get_gpio_in(DEVICE(&s->gic), AW_H3_GIC_SPI_UART2), - 115200, serial_hd(2), DEVICE_NATIVE_ENDIAN); + 115200, serial_hd(2), DEVICE_LITTLE_ENDIAN); /* UART3 */ serial_mm_init(get_system_memory(), s->memmap[AW_H3_DEV_UART3], 2, qdev_get_gpio_in(DEVICE(&s->gic), AW_H3_GIC_SPI_UART3), - 115200, serial_hd(3), DEVICE_NATIVE_ENDIAN); + 115200, serial_hd(3), DEVICE_LITTLE_ENDIAN); /* DRAMC */ sysbus_realize(SYS_BUS_DEVICE(&s->dramc), &error_fatal); diff --git a/hw/arm/allwinner-r40.c b/hw/arm/allwinner-r40.c index 47b3180f0ec..cef6e4d18c2 100644 --- a/hw/arm/allwinner-r40.c +++ b/hw/arm/allwinner-r40.c @@ -492,7 +492,7 @@ static void allwinner_r40_realize(DeviceState *dev, Error **errp) serial_mm_init(get_system_memory(), addr, 2, qdev_get_gpio_in(DEVICE(&s->gic), uart_irqs[i]), - 115200, serial_hd(i), DEVICE_NATIVE_ENDIAN); + 115200, serial_hd(i), DEVICE_LITTLE_ENDIAN); } /* I2C */ diff --git a/hw/i2c/allwinner-i2c.c b/hw/i2c/allwinner-i2c.c index 16f1d6d40e7..66d6431c508 100644 --- a/hw/i2c/allwinner-i2c.c +++ b/hw/i2c/allwinner-i2c.c @@ -407,7 +407,7 @@ static const MemoryRegionOps allwinner_i2c_ops = { .write = allwinner_i2c_write, .valid.min_access_size = 1, .valid.max_access_size = 4, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, }; static const VMStateDescription allwinner_i2c_vmstate = { diff --git a/hw/intc/allwinner-a10-pic.c b/hw/intc/allwinner-a10-pic.c index c0f30092cd6..93a604f7a04 100644 --- a/hw/intc/allwinner-a10-pic.c +++ b/hw/intc/allwinner-a10-pic.c @@ -135,7 +135,7 @@ static void aw_a10_pic_write(void *opaque, hwaddr offset, uint64_t value, static const MemoryRegionOps aw_a10_pic_ops = { .read = aw_a10_pic_read, .write = aw_a10_pic_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, }; static const VMStateDescription vmstate_aw_a10_pic = { diff --git a/hw/misc/allwinner-a10-ccm.c b/hw/misc/allwinner-a10-ccm.c index 575b0189524..6ca1daaff8a 100644 --- a/hw/misc/allwinner-a10-ccm.c +++ b/hw/misc/allwinner-a10-ccm.c @@ -147,7 +147,7 @@ static void allwinner_a10_ccm_write(void *opaque, hwaddr offset, static const MemoryRegionOps allwinner_a10_ccm_ops = { .read = allwinner_a10_ccm_read, .write = allwinner_a10_ccm_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, .valid = { .min_access_size = 4, .max_access_size = 4, diff --git a/hw/misc/allwinner-a10-dramc.c b/hw/misc/allwinner-a10-dramc.c index a7c58fa6d06..badc4c56eb7 100644 --- a/hw/misc/allwinner-a10-dramc.c +++ b/hw/misc/allwinner-a10-dramc.c @@ -114,7 +114,7 @@ static void allwinner_a10_dramc_write(void *opaque, hwaddr offset, static const MemoryRegionOps allwinner_a10_dramc_ops = { .read = allwinner_a10_dramc_read, .write = allwinner_a10_dramc_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, .valid = { .min_access_size = 4, .max_access_size = 4, diff --git a/hw/misc/allwinner-cpucfg.c b/hw/misc/allwinner-cpucfg.c index 022f63ddf34..a4f7a011419 100644 --- a/hw/misc/allwinner-cpucfg.c +++ b/hw/misc/allwinner-cpucfg.c @@ -217,7 +217,7 @@ static void allwinner_cpucfg_write(void *opaque, hwaddr offset, static const MemoryRegionOps allwinner_cpucfg_ops = { .read = allwinner_cpucfg_read, .write = allwinner_cpucfg_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, .valid = { .min_access_size = 4, .max_access_size = 4, diff --git a/hw/misc/allwinner-h3-ccu.c b/hw/misc/allwinner-h3-ccu.c index 92e579a9918..e765f4c54b4 100644 --- a/hw/misc/allwinner-h3-ccu.c +++ b/hw/misc/allwinner-h3-ccu.c @@ -155,7 +155,7 @@ static void allwinner_h3_ccu_write(void *opaque, hwaddr offset, static const MemoryRegionOps allwinner_h3_ccu_ops = { .read = allwinner_h3_ccu_read, .write = allwinner_h3_ccu_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, .valid = { .min_access_size = 4, .max_access_size = 4, diff --git a/hw/misc/allwinner-h3-dramc.c b/hw/misc/allwinner-h3-dramc.c index 13bba26d0e4..c4f3eb92747 100644 --- a/hw/misc/allwinner-h3-dramc.c +++ b/hw/misc/allwinner-h3-dramc.c @@ -219,7 +219,7 @@ static void allwinner_h3_dramphy_write(void *opaque, hwaddr offset, static const MemoryRegionOps allwinner_h3_dramcom_ops = { .read = allwinner_h3_dramcom_read, .write = allwinner_h3_dramcom_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, .valid = { .min_access_size = 4, .max_access_size = 4, @@ -230,7 +230,7 @@ static const MemoryRegionOps allwinner_h3_dramcom_ops = { static const MemoryRegionOps allwinner_h3_dramctl_ops = { .read = allwinner_h3_dramctl_read, .write = allwinner_h3_dramctl_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, .valid = { .min_access_size = 4, .max_access_size = 4, @@ -241,7 +241,7 @@ static const MemoryRegionOps allwinner_h3_dramctl_ops = { static const MemoryRegionOps allwinner_h3_dramphy_ops = { .read = allwinner_h3_dramphy_read, .write = allwinner_h3_dramphy_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, .valid = { .min_access_size = 4, .max_access_size = 4, diff --git a/hw/misc/allwinner-h3-sysctrl.c b/hw/misc/allwinner-h3-sysctrl.c index 40059e8cb0c..32a0ceb01a3 100644 --- a/hw/misc/allwinner-h3-sysctrl.c +++ b/hw/misc/allwinner-h3-sysctrl.c @@ -78,7 +78,7 @@ static void allwinner_h3_sysctrl_write(void *opaque, hwaddr offset, static const MemoryRegionOps allwinner_h3_sysctrl_ops = { .read = allwinner_h3_sysctrl_read, .write = allwinner_h3_sysctrl_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, .valid = { .min_access_size = 4, .max_access_size = 4, diff --git a/hw/misc/allwinner-r40-ccu.c b/hw/misc/allwinner-r40-ccu.c index 005a15b2dae..8f37a9213c0 100644 --- a/hw/misc/allwinner-r40-ccu.c +++ b/hw/misc/allwinner-r40-ccu.c @@ -129,7 +129,7 @@ static void allwinner_r40_ccu_write(void *opaque, hwaddr offset, static const MemoryRegionOps allwinner_r40_ccu_ops = { .read = allwinner_r40_ccu_read, .write = allwinner_r40_ccu_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, .valid = { .min_access_size = 4, .max_access_size = 4, diff --git a/hw/misc/allwinner-r40-dramc.c b/hw/misc/allwinner-r40-dramc.c index 97c3664e3a3..96e1848c21f 100644 --- a/hw/misc/allwinner-r40-dramc.c +++ b/hw/misc/allwinner-r40-dramc.c @@ -297,7 +297,7 @@ static void allwinner_r40_dramphy_write(void *opaque, hwaddr offset, static const MemoryRegionOps allwinner_r40_dramcom_ops = { .read = allwinner_r40_dramcom_read, .write = allwinner_r40_dramcom_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, .valid = { .min_access_size = 4, .max_access_size = 4, @@ -308,7 +308,7 @@ static const MemoryRegionOps allwinner_r40_dramcom_ops = { static const MemoryRegionOps allwinner_r40_dramctl_ops = { .read = allwinner_r40_dramctl_read, .write = allwinner_r40_dramctl_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, .valid = { .min_access_size = 4, .max_access_size = 4, @@ -319,7 +319,7 @@ static const MemoryRegionOps allwinner_r40_dramctl_ops = { static const MemoryRegionOps allwinner_r40_dramphy_ops = { .read = allwinner_r40_dramphy_read, .write = allwinner_r40_dramphy_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, .valid = { .min_access_size = 4, .max_access_size = 4, @@ -358,7 +358,7 @@ static void allwinner_r40_detect_write(void *opaque, hwaddr offset, static const MemoryRegionOps allwinner_r40_detect_ops = { .read = allwinner_r40_detect_read, .write = allwinner_r40_detect_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, .valid = { .min_access_size = 4, .max_access_size = 4, @@ -393,7 +393,7 @@ static uint64_t allwinner_r40_dualrank_detect_read(void *opaque, hwaddr offset, static const MemoryRegionOps allwinner_r40_dualrank_detect_ops = { .read = allwinner_r40_dualrank_detect_read, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, .valid = { .min_access_size = 4, .max_access_size = 4, diff --git a/hw/misc/allwinner-sid.c b/hw/misc/allwinner-sid.c index 042b747f30b..2bb81f9c540 100644 --- a/hw/misc/allwinner-sid.c +++ b/hw/misc/allwinner-sid.c @@ -99,7 +99,7 @@ static void allwinner_sid_write(void *opaque, hwaddr offset, static const MemoryRegionOps allwinner_sid_ops = { .read = allwinner_sid_read, .write = allwinner_sid_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, .valid = { .min_access_size = 4, .max_access_size = 4, diff --git a/hw/misc/allwinner-sramc.c b/hw/misc/allwinner-sramc.c index a20b0b4c5cb..51df5e45aa2 100644 --- a/hw/misc/allwinner-sramc.c +++ b/hw/misc/allwinner-sramc.c @@ -104,7 +104,7 @@ static void allwinner_sramc_write(void *opaque, hwaddr offset, static const MemoryRegionOps allwinner_sramc_ops = { .read = allwinner_sramc_read, .write = allwinner_sramc_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, .valid = { .min_access_size = 4, .max_access_size = 4, diff --git a/hw/net/allwinner-sun8i-emac.c b/hw/net/allwinner-sun8i-emac.c index ff44554e957..5adb41dc469 100644 --- a/hw/net/allwinner-sun8i-emac.c +++ b/hw/net/allwinner-sun8i-emac.c @@ -784,7 +784,7 @@ static void allwinner_sun8i_emac_set_link(NetClientState *nc) static const MemoryRegionOps allwinner_sun8i_emac_mem_ops = { .read = allwinner_sun8i_emac_read, .write = allwinner_sun8i_emac_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, .valid = { .min_access_size = 4, .max_access_size = 4, diff --git a/hw/net/allwinner_emac.c b/hw/net/allwinner_emac.c index 3eb9e09dc5c..47f1e7f086c 100644 --- a/hw/net/allwinner_emac.c +++ b/hw/net/allwinner_emac.c @@ -421,7 +421,7 @@ static void aw_emac_set_link(NetClientState *nc) static const MemoryRegionOps aw_emac_mem_ops = { .read = aw_emac_read, .write = aw_emac_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, .valid = { .min_access_size = 4, .max_access_size = 4, diff --git a/hw/rtc/allwinner-rtc.c b/hw/rtc/allwinner-rtc.c index a19e4310bb1..fd8355a8676 100644 --- a/hw/rtc/allwinner-rtc.c +++ b/hw/rtc/allwinner-rtc.c @@ -259,7 +259,7 @@ static void allwinner_rtc_write(void *opaque, hwaddr offset, static const MemoryRegionOps allwinner_rtc_ops = { .read = allwinner_rtc_read, .write = allwinner_rtc_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, .valid = { .min_access_size = 4, .max_access_size = 4, diff --git a/hw/sd/allwinner-sdhost.c b/hw/sd/allwinner-sdhost.c index ee5c5c78a81..03980d27168 100644 --- a/hw/sd/allwinner-sdhost.c +++ b/hw/sd/allwinner-sdhost.c @@ -761,7 +761,7 @@ static void allwinner_sdhost_write(void *opaque, hwaddr offset, static const MemoryRegionOps allwinner_sdhost_ops = { .read = allwinner_sdhost_read, .write = allwinner_sdhost_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, .valid = { .min_access_size = 4, .max_access_size = 4, diff --git a/hw/ssi/allwinner-a10-spi.c b/hw/ssi/allwinner-a10-spi.c index 3eb50b44ac5..d2f6bb9cdc7 100644 --- a/hw/ssi/allwinner-a10-spi.c +++ b/hw/ssi/allwinner-a10-spi.c @@ -502,7 +502,7 @@ static const MemoryRegionOps allwinner_a10_spi_ops = { .write = allwinner_a10_spi_write, .valid.min_access_size = 1, .valid.max_access_size = 4, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, }; static const VMStateDescription allwinner_a10_spi_vmstate = { diff --git a/hw/timer/allwinner-a10-pit.c b/hw/timer/allwinner-a10-pit.c index ddaf2128c2d..da3d7173ef5 100644 --- a/hw/timer/allwinner-a10-pit.c +++ b/hw/timer/allwinner-a10-pit.c @@ -185,7 +185,7 @@ static void a10_pit_write(void *opaque, hwaddr offset, uint64_t value, static const MemoryRegionOps a10_pit_ops = { .read = a10_pit_read, .write = a10_pit_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, }; static const Property a10_pit_properties[] = { diff --git a/hw/watchdog/allwinner-wdt.c b/hw/watchdog/allwinner-wdt.c index 1bfec41ff8b..78f4f9d6f67 100644 --- a/hw/watchdog/allwinner-wdt.c +++ b/hw/watchdog/allwinner-wdt.c @@ -275,7 +275,7 @@ static void allwinner_wdt_write(void *opaque, hwaddr offset, static const MemoryRegionOps allwinner_wdt_ops = { .read = allwinner_wdt_read, .write = allwinner_wdt_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, .valid = { .min_access_size = 4, .max_access_size = 4, -- 2.47.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 1/5] hw/arm: Mark Allwinner Technology devices as little-endian 2025-02-12 11:39 ` [PATCH 1/5] hw/arm: Mark Allwinner Technology devices as little-endian Philippe Mathieu-Daudé @ 2025-02-12 17:47 ` Richard Henderson 0 siblings, 0 replies; 12+ messages in thread From: Richard Henderson @ 2025-02-12 17:47 UTC (permalink / raw) To: qemu-devel On 2/12/25 03:39, Philippe Mathieu-Daudé wrote: > These devices are only used by the ARM targets, which are > only built as little-endian. Therefore the DEVICE_NATIVE_ENDIAN > definition expand to DEVICE_LITTLE_ENDIAN (besides, the > DEVICE_BIG_ENDIAN case isn't tested). Simplify directly using > DEVICE_LITTLE_ENDIAN. > > Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org> > --- > hw/arm/allwinner-a10.c | 2 +- > hw/arm/allwinner-h3.c | 8 ++++---- > hw/arm/allwinner-r40.c | 2 +- > hw/i2c/allwinner-i2c.c | 2 +- > hw/intc/allwinner-a10-pic.c | 2 +- > hw/misc/allwinner-a10-ccm.c | 2 +- > hw/misc/allwinner-a10-dramc.c | 2 +- > hw/misc/allwinner-cpucfg.c | 2 +- > hw/misc/allwinner-h3-ccu.c | 2 +- > hw/misc/allwinner-h3-dramc.c | 6 +++--- > hw/misc/allwinner-h3-sysctrl.c | 2 +- > hw/misc/allwinner-r40-ccu.c | 2 +- > hw/misc/allwinner-r40-dramc.c | 10 +++++----- > hw/misc/allwinner-sid.c | 2 +- > hw/misc/allwinner-sramc.c | 2 +- > hw/net/allwinner-sun8i-emac.c | 2 +- > hw/net/allwinner_emac.c | 2 +- > hw/rtc/allwinner-rtc.c | 2 +- > hw/sd/allwinner-sdhost.c | 2 +- > hw/ssi/allwinner-a10-spi.c | 2 +- > hw/timer/allwinner-a10-pit.c | 2 +- > hw/watchdog/allwinner-wdt.c | 2 +- > 22 files changed, 31 insertions(+), 31 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~ ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 2/5] hw/mips: Mark Boston machine devices as little-endian 2025-02-12 11:39 [PATCH 0/5] hw: More DEVICE_ [NATIVE -> LITTLE] _ENDIAN conversions Philippe Mathieu-Daudé 2025-02-12 11:39 ` [PATCH 1/5] hw/arm: Mark Allwinner Technology devices as little-endian Philippe Mathieu-Daudé @ 2025-02-12 11:39 ` Philippe Mathieu-Daudé 2025-02-12 17:51 ` Richard Henderson 2025-02-12 11:39 ` [PATCH 3/5] hw/mips: Mark Loonson3 Virt " Philippe Mathieu-Daudé ` (3 subsequent siblings) 5 siblings, 1 reply; 12+ messages in thread From: Philippe Mathieu-Daudé @ 2025-02-12 11:39 UTC (permalink / raw) To: qemu-devel Cc: Paul Burton, Jiaxun Yang, Huacai Chen, qemu-arm, Philippe Mathieu-Daudé, Aleksandar Rikalo, Sunil Muthuswamy, Peter Maydell, Beniamino Galvani, Strahinja Jankovic, Alistair Francis, Jason Wang, Niek Linnenbank The Boston machine is only built as little-endian. Therefore the DEVICE_NATIVE_ENDIAN definition expand to DEVICE_LITTLE_ENDIAN (besides, the DEVICE_BIG_ENDIAN case isn't tested). Simplify directly using DEVICE_LITTLE_ENDIAN. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- hw/mips/boston.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/mips/boston.c b/hw/mips/boston.c index 364c328032a..4690b254dda 100644 --- a/hw/mips/boston.c +++ b/hw/mips/boston.c @@ -220,7 +220,7 @@ static void boston_lcd_write(void *opaque, hwaddr addr, static const MemoryRegionOps boston_lcd_ops = { .read = boston_lcd_read, .write = boston_lcd_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, }; static uint64_t boston_platreg_read(void *opaque, hwaddr addr, @@ -299,7 +299,7 @@ static void boston_platreg_write(void *opaque, hwaddr addr, static const MemoryRegionOps boston_platreg_ops = { .read = boston_platreg_read, .write = boston_platreg_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, }; static void mips_boston_instance_init(Object *obj) @@ -758,7 +758,7 @@ static void boston_mach_init(MachineState *machine) s->uart = serial_mm_init(sys_mem, boston_memmap[BOSTON_UART].base, 2, get_cps_irq(&s->cps, 3), 10000000, - serial_hd(0), DEVICE_NATIVE_ENDIAN); + serial_hd(0), DEVICE_LITTLE_ENDIAN); lcd = g_new(MemoryRegion, 1); memory_region_init_io(lcd, NULL, &boston_lcd_ops, s, "boston-lcd", 0x8); -- 2.47.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 2/5] hw/mips: Mark Boston machine devices as little-endian 2025-02-12 11:39 ` [PATCH 2/5] hw/mips: Mark Boston machine " Philippe Mathieu-Daudé @ 2025-02-12 17:51 ` Richard Henderson 0 siblings, 0 replies; 12+ messages in thread From: Richard Henderson @ 2025-02-12 17:51 UTC (permalink / raw) To: qemu-devel On 2/12/25 03:39, Philippe Mathieu-Daudé wrote: > The Boston machine is only built as little-endian. > Therefore the DEVICE_NATIVE_ENDIAN definition expand to > DEVICE_LITTLE_ENDIAN (besides, the DEVICE_BIG_ENDIAN case > isn't tested). Simplify directly using DEVICE_LITTLE_ENDIAN. > > Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org> > --- > hw/mips/boston.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~ ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 3/5] hw/mips: Mark Loonson3 Virt machine devices as little-endian 2025-02-12 11:39 [PATCH 0/5] hw: More DEVICE_ [NATIVE -> LITTLE] _ENDIAN conversions Philippe Mathieu-Daudé 2025-02-12 11:39 ` [PATCH 1/5] hw/arm: Mark Allwinner Technology devices as little-endian Philippe Mathieu-Daudé 2025-02-12 11:39 ` [PATCH 2/5] hw/mips: Mark Boston machine " Philippe Mathieu-Daudé @ 2025-02-12 11:39 ` Philippe Mathieu-Daudé 2025-02-12 17:51 ` Richard Henderson 2025-02-12 11:39 ` [PATCH 4/5] hw/pci-host: Mark versatile regions " Philippe Mathieu-Daudé ` (2 subsequent siblings) 5 siblings, 1 reply; 12+ messages in thread From: Philippe Mathieu-Daudé @ 2025-02-12 11:39 UTC (permalink / raw) To: qemu-devel Cc: Paul Burton, Jiaxun Yang, Huacai Chen, qemu-arm, Philippe Mathieu-Daudé, Aleksandar Rikalo, Sunil Muthuswamy, Peter Maydell, Beniamino Galvani, Strahinja Jankovic, Alistair Francis, Jason Wang, Niek Linnenbank The Loonson3 Virt machine is only built as little-endian. Therefore the DEVICE_NATIVE_ENDIAN definition expand to DEVICE_LITTLE_ENDIAN (besides, the DEVICE_BIG_ENDIAN case isn't tested). Simplify directly using DEVICE_LITTLE_ENDIAN. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- hw/mips/loongson3_virt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/mips/loongson3_virt.c b/hw/mips/loongson3_virt.c index 831fddb1bd7..db1cc513147 100644 --- a/hw/mips/loongson3_virt.c +++ b/hw/mips/loongson3_virt.c @@ -144,7 +144,7 @@ static void loongson3_pm_write(void *opaque, hwaddr addr, static const MemoryRegionOps loongson3_pm_ops = { .read = loongson3_pm_read, .write = loongson3_pm_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, .valid = { .min_access_size = 1, .max_access_size = 1 @@ -560,7 +560,7 @@ static void mips_loongson3_virt_init(MachineState *machine) serial_mm_init(address_space_mem, virt_memmap[VIRT_UART].base, 0, qdev_get_gpio_in(liointc, UART_IRQ), 115200, serial_hd(0), - DEVICE_NATIVE_ENDIAN); + DEVICE_LITTLE_ENDIAN); sysbus_create_simple("goldfish_rtc", virt_memmap[VIRT_RTC].base, qdev_get_gpio_in(liointc, RTC_IRQ)); -- 2.47.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 3/5] hw/mips: Mark Loonson3 Virt machine devices as little-endian 2025-02-12 11:39 ` [PATCH 3/5] hw/mips: Mark Loonson3 Virt " Philippe Mathieu-Daudé @ 2025-02-12 17:51 ` Richard Henderson 0 siblings, 0 replies; 12+ messages in thread From: Richard Henderson @ 2025-02-12 17:51 UTC (permalink / raw) To: qemu-devel On 2/12/25 03:39, Philippe Mathieu-Daudé wrote: > The Loonson3 Virt machine is only built as little-endian. > Therefore the DEVICE_NATIVE_ENDIAN definition expand to > DEVICE_LITTLE_ENDIAN (besides, the DEVICE_BIG_ENDIAN case > isn't tested). Simplify directly using DEVICE_LITTLE_ENDIAN. > > Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org> > --- > hw/mips/loongson3_virt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~ ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 4/5] hw/pci-host: Mark versatile regions as little-endian 2025-02-12 11:39 [PATCH 0/5] hw: More DEVICE_ [NATIVE -> LITTLE] _ENDIAN conversions Philippe Mathieu-Daudé ` (2 preceding siblings ...) 2025-02-12 11:39 ` [PATCH 3/5] hw/mips: Mark Loonson3 Virt " Philippe Mathieu-Daudé @ 2025-02-12 11:39 ` Philippe Mathieu-Daudé 2025-02-12 17:53 ` Richard Henderson 2025-02-12 11:39 ` [PATCH 5/5] target/i386: Mark WHPX APIC region " Philippe Mathieu-Daudé 2025-02-16 21:03 ` [PATCH 0/5] hw: More DEVICE_ [NATIVE -> LITTLE] _ENDIAN conversions Philippe Mathieu-Daudé 5 siblings, 1 reply; 12+ messages in thread From: Philippe Mathieu-Daudé @ 2025-02-12 11:39 UTC (permalink / raw) To: qemu-devel Cc: Paul Burton, Jiaxun Yang, Huacai Chen, qemu-arm, Philippe Mathieu-Daudé, Aleksandar Rikalo, Sunil Muthuswamy, Peter Maydell, Beniamino Galvani, Strahinja Jankovic, Alistair Francis, Jason Wang, Niek Linnenbank This device is only used by the ARM targets, which are only built as little-endian. Therefore the DEVICE_NATIVE_ENDIAN definition expand to DEVICE_LITTLE_ENDIAN (besides, the DEVICE_BIG_ENDIAN case isn't tested). Simplify directly using DEVICE_LITTLE_ENDIAN. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- hw/pci-host/versatile.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/versatile.c b/hw/pci-host/versatile.c index c3fbf4cbf94..33a8ceb3b54 100644 --- a/hw/pci-host/versatile.c +++ b/hw/pci-host/versatile.c @@ -246,7 +246,7 @@ static uint64_t pci_vpb_reg_read(void *opaque, hwaddr addr, static const MemoryRegionOps pci_vpb_reg_ops = { .read = pci_vpb_reg_read, .write = pci_vpb_reg_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, .valid = { .min_access_size = 4, .max_access_size = 4, @@ -312,7 +312,7 @@ static uint64_t pci_vpb_config_read(void *opaque, hwaddr addr, static const MemoryRegionOps pci_vpb_config_ops = { .read = pci_vpb_config_read, .write = pci_vpb_config_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, }; static int pci_vpb_map_irq(PCIDevice *d, int irq_num) -- 2.47.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 4/5] hw/pci-host: Mark versatile regions as little-endian 2025-02-12 11:39 ` [PATCH 4/5] hw/pci-host: Mark versatile regions " Philippe Mathieu-Daudé @ 2025-02-12 17:53 ` Richard Henderson 0 siblings, 0 replies; 12+ messages in thread From: Richard Henderson @ 2025-02-12 17:53 UTC (permalink / raw) To: qemu-devel On 2/12/25 03:39, Philippe Mathieu-Daudé wrote: > This device is only used by the ARM targets, which are only > built as little-endian. Therefore the DEVICE_NATIVE_ENDIAN > definition expand to DEVICE_LITTLE_ENDIAN (besides, the > DEVICE_BIG_ENDIAN case isn't tested). Simplify directly > using DEVICE_LITTLE_ENDIAN. > > Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org> > --- > hw/pci-host/versatile.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~ ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 5/5] target/i386: Mark WHPX APIC region as little-endian 2025-02-12 11:39 [PATCH 0/5] hw: More DEVICE_ [NATIVE -> LITTLE] _ENDIAN conversions Philippe Mathieu-Daudé ` (3 preceding siblings ...) 2025-02-12 11:39 ` [PATCH 4/5] hw/pci-host: Mark versatile regions " Philippe Mathieu-Daudé @ 2025-02-12 11:39 ` Philippe Mathieu-Daudé 2025-02-12 17:54 ` Richard Henderson 2025-02-16 21:03 ` [PATCH 0/5] hw: More DEVICE_ [NATIVE -> LITTLE] _ENDIAN conversions Philippe Mathieu-Daudé 5 siblings, 1 reply; 12+ messages in thread From: Philippe Mathieu-Daudé @ 2025-02-12 11:39 UTC (permalink / raw) To: qemu-devel Cc: Paul Burton, Jiaxun Yang, Huacai Chen, qemu-arm, Philippe Mathieu-Daudé, Aleksandar Rikalo, Sunil Muthuswamy, Peter Maydell, Beniamino Galvani, Strahinja Jankovic, Alistair Francis, Jason Wang, Niek Linnenbank This device is only used by the x86 targets, which are only built as little-endian. Therefore the DEVICE_NATIVE_ENDIAN definition expand to DEVICE_LITTLE_ENDIAN (besides, the DEVICE_BIG_ENDIAN case isn't tested). Simplify directly using DEVICE_LITTLE_ENDIAN. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- target/i386/whpx/whpx-apic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/whpx/whpx-apic.c b/target/i386/whpx/whpx-apic.c index 4245ab68a27..630a9616d71 100644 --- a/target/i386/whpx/whpx-apic.c +++ b/target/i386/whpx/whpx-apic.c @@ -231,7 +231,7 @@ static void whpx_apic_mem_write(void *opaque, hwaddr addr, static const MemoryRegionOps whpx_apic_io_ops = { .read = whpx_apic_mem_read, .write = whpx_apic_mem_write, - .endianness = DEVICE_NATIVE_ENDIAN, + .endianness = DEVICE_LITTLE_ENDIAN, }; static void whpx_apic_reset(APICCommonState *s) -- 2.47.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 5/5] target/i386: Mark WHPX APIC region as little-endian 2025-02-12 11:39 ` [PATCH 5/5] target/i386: Mark WHPX APIC region " Philippe Mathieu-Daudé @ 2025-02-12 17:54 ` Richard Henderson 0 siblings, 0 replies; 12+ messages in thread From: Richard Henderson @ 2025-02-12 17:54 UTC (permalink / raw) To: qemu-devel On 2/12/25 03:39, Philippe Mathieu-Daudé wrote: > This device is only used by the x86 targets, which are only > built as little-endian. Therefore the DEVICE_NATIVE_ENDIAN > definition expand to DEVICE_LITTLE_ENDIAN (besides, the > DEVICE_BIG_ENDIAN case isn't tested). Simplify directly > using DEVICE_LITTLE_ENDIAN. > > Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org> > --- > target/i386/whpx/whpx-apic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~ ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/5] hw: More DEVICE_ [NATIVE -> LITTLE] _ENDIAN conversions 2025-02-12 11:39 [PATCH 0/5] hw: More DEVICE_ [NATIVE -> LITTLE] _ENDIAN conversions Philippe Mathieu-Daudé ` (4 preceding siblings ...) 2025-02-12 11:39 ` [PATCH 5/5] target/i386: Mark WHPX APIC region " Philippe Mathieu-Daudé @ 2025-02-16 21:03 ` Philippe Mathieu-Daudé 5 siblings, 0 replies; 12+ messages in thread From: Philippe Mathieu-Daudé @ 2025-02-16 21:03 UTC (permalink / raw) To: qemu-devel Cc: Paul Burton, Jiaxun Yang, Huacai Chen, qemu-arm, Aleksandar Rikalo, Sunil Muthuswamy, Peter Maydell, Beniamino Galvani, Strahinja Jankovic, Alistair Francis, Jason Wang, Niek Linnenbank On 12/2/25 12:39, Philippe Mathieu-Daudé wrote: > Philippe Mathieu-Daudé (5): > hw/arm: Mark Allwinner Technology devices as little-endian > hw/mips: Mark Boston machine devices as little-endian > hw/mips: Mark Loonson3 Virt machine devices as little-endian > hw/pci-host: Mark versatile regions as little-endian Series queued, thanks. ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2025-02-16 21:04 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-02-12 11:39 [PATCH 0/5] hw: More DEVICE_ [NATIVE -> LITTLE] _ENDIAN conversions Philippe Mathieu-Daudé 2025-02-12 11:39 ` [PATCH 1/5] hw/arm: Mark Allwinner Technology devices as little-endian Philippe Mathieu-Daudé 2025-02-12 17:47 ` Richard Henderson 2025-02-12 11:39 ` [PATCH 2/5] hw/mips: Mark Boston machine " Philippe Mathieu-Daudé 2025-02-12 17:51 ` Richard Henderson 2025-02-12 11:39 ` [PATCH 3/5] hw/mips: Mark Loonson3 Virt " Philippe Mathieu-Daudé 2025-02-12 17:51 ` Richard Henderson 2025-02-12 11:39 ` [PATCH 4/5] hw/pci-host: Mark versatile regions " Philippe Mathieu-Daudé 2025-02-12 17:53 ` Richard Henderson 2025-02-12 11:39 ` [PATCH 5/5] target/i386: Mark WHPX APIC region " Philippe Mathieu-Daudé 2025-02-12 17:54 ` Richard Henderson 2025-02-16 21:03 ` [PATCH 0/5] hw: More DEVICE_ [NATIVE -> LITTLE] _ENDIAN conversions Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).