From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 013AAEB64DA for ; Fri, 14 Jul 2023 06:32:33 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKCKh-0006df-Gh; Fri, 14 Jul 2023 02:31:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKCKM-0006c5-MP for qemu-devel@nongnu.org; Fri, 14 Jul 2023 02:30:57 -0400 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKCKL-00072l-3D for qemu-devel@nongnu.org; Fri, 14 Jul 2023 02:30:54 -0400 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1b9de2bd0abso8205535ad.0 for ; Thu, 13 Jul 2023 23:30:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689316251; x=1691908251; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6J5Db53f6xjvipUdL8t6sRYWt+uYG1taHQ91KoD9xCw=; b=eeHdVOkHr0dxq26I1RFQt/ekAYMMx4qQmOxFBeKFX6OVEMY5B7PirckhAP8pVvAn7/ FJB5ogOImosAXeI2S2qjMrgQ3mS7Ks8wa36Qa+0mWHC63d2d8LF9NScIoKC0Lec8piU1 m3IauvCdvy8Onh/Wk+V9kO0nraRCScMMq739Zl/F2duI0EFd+kkQaKiIc+zj6bpWyR2O p7ZGUfX1F4t6DGmuX77oN4hLWPq3sy//7AMdZJroh6us6xyd0DwZ514k7MC1gOfhZwRE +laV9yeu8xokarPoJQx+aWEkoE96LnxGbCGoubRCD9jv3HIeXpvMBGi1GQSLqRXUvO3+ L0uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689316251; x=1691908251; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6J5Db53f6xjvipUdL8t6sRYWt+uYG1taHQ91KoD9xCw=; b=gNIQ17cgeKsjJolR0CeajXhreC5UlmgcN5XyeMhOCpEwKFNmUjEwMaQlPpdQko4kYt gNMgi8TaFVXzcTtt90zodezOnfyVWW3CSlgLZkBQtNCHSp7nquYtELiCdV0KdF4Iz3SO 2z0DxhpjgOQFrxZYTUKbQOBThHLihsqvN+HZ9FKCSl/Rzi1cFViVV1qKvuQTlTJGgYIJ BJRcqrmRq1z6T5+ETSOdn8LaZu1xHG7Df5j0qvkur1Mc5cQ+mc1oGHPg+Wz9ap/64/D6 zzH7Ydiwdx9H6SmZaMc8ChAZ8cEcaumNWE9NmSfScAiOTX1OogryDiwal41+apvAMWmz NlFQ== X-Gm-Message-State: ABy/qLZpj06hD5CURjoveAEqIUlqiS0TStAS2hZiiEWcWdv1arO2liDs kYKxkXSdXpA88Eo6qJAdbwijNQ== X-Google-Smtp-Source: APBJJlF4PF+9OlQdkKC3Z8Iwf8xJH6oSGgYsSV2Gp36CCytcJ+Xo/naQcY61aefm4Nrb6R9my+pMMA== X-Received: by 2002:a17:902:788d:b0:1a9:40d5:b0ae with SMTP id q13-20020a170902788d00b001a940d5b0aemr2580310pll.12.1689316251505; Thu, 13 Jul 2023 23:30:51 -0700 (PDT) Received: from [192.168.149.227] ([172.58.27.104]) by smtp.gmail.com with ESMTPSA id c10-20020a1709029d8a00b001b83db0bcf2sm6932354plq.141.2023.07.13.23.30.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jul 2023 23:30:50 -0700 (PDT) Message-ID: Date: Fri, 14 Jul 2023 07:30:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH for-8.2 v2 5/7] target/riscv/cpu.c: add a ADD_CPU_PROPERTIES_ARRAY() macro Content-Language: en-US To: Daniel Henrique Barboza , qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com, bmeng@tinylab.org, liweiwei@iscas.ac.cn, zhiwei_liu@linux.alibaba.com, palmer@rivosinc.com References: <20230712205748.446931-1-dbarboza@ventanamicro.com> <20230712205748.446931-6-dbarboza@ventanamicro.com> <9626ed95-9d50-344b-696a-95998e98e3f4@linaro.org> From: Richard Henderson In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x631.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.096, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 7/13/23 22:27, Daniel Henrique Barboza wrote: > > > On 7/13/23 17:40, Richard Henderson wrote: >> On 7/12/23 21:57, Daniel Henrique Barboza wrote: >>> +#define ADD_CPU_PROPERTIES_ARRAY(_dev, _array) \ >>> +    for (prop = _array; prop && prop->name; prop++) { \ >>> +        qdev_property_add_static(_dev, prop); \ >>> +    } \ >> >> do { } while(0) >> >> Watch the \ on the last line of the macro. >> Declare the iterator within the macro, rather than use one defined in the outer scope. > > Like this? > > #define ADD_CPU_PROPERTIES_ARRAY(_dev, _array) \ >     do { \ >         Property *prop; \ >         for (prop = _array; prop && prop->name; prop++) { \ >             qdev_property_add_static(_dev, prop); \ >         } \ >     } while(0) Yes, like that, thanks. r~