From: Paolo Bonzini <pbonzini@redhat.com>
To: Greg Kurz <groug@kaod.org>,
Christian Schoenebeck <qemu_oss@crudebyte.com>
Cc: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Subject: Re: 9pfs developers docs
Date: Mon, 1 Feb 2021 14:15:42 +0100 [thread overview]
Message-ID: <ca497b43-bea4-14be-f49e-6b8c374da4d5@redhat.com> (raw)
In-Reply-To: <20210201132649.6db25cec@bahia.lan>
On 01/02/21 13:26, Greg Kurz wrote:
> Is it that '-m slow' doesn't work when running 'qos-test' or
> that 'make check-qtest SPEEP=slow' doesn't run the slow tests ?
>
> The latter was discussed on IRC last year but I don't know if
> anyone has tried to investigate this yet.
>
> Nov 24 11:36:53 <groug> th_huth, Hi. FYI it seems that the meson conversion kinda broke 'make check SPEED=slow'. Test programs aren't passed '-m slow'
> Nov 24 11:51:42 <f4bug> th_huth: do you know who uses/tests SPEED=slow?
> Nov 24 11:52:03 <f4bug> th_huth: I thought this was a block-related feature
> Nov 24 11:52:44 <groug> f4bug, it is supposedly used by gitlab CI
> Nov 24 11:52:59 <groug> .gitlab-ci.yml: MAKE_CHECK_ARGS: check-qtest SPEED=slow
> Nov 24 12:50:53 <th_huth> groug, I'm also running make check SPEED=slow manually sometimes ... I guess that got lost in the conversion to ninja ... bonzini, did you ever try?
> Nov 24 12:51:03 <bonzini> no it shouldn't
> Nov 24 12:51:21 <th_huth> let me check...
> Nov 24 12:51:40 <bonzini> ah, the tests are chosen correctly but -m slow is lost
> Nov 24 12:52:02 <groug> yes that's what I see
> Nov 24 12:54:04 <groug> bonzini, missing bits in scripts/mtest2make.py ?
> Nov 24 12:54:28 <bonzini> groug: sort of, but assuming that all executables support -m slow wouldn't work
>
> Cc'ing Thomas and Paolo for additional details.
Basically what's in the IRC log is still true. I'll look into using an
environment variable "SPEED" in addition to g_test_{slow,quick} in order
to restore SPEED=slow behavior.
Paolo
next prev parent reply other threads:[~2021-02-01 13:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-31 18:23 9pfs developers docs Christian Schoenebeck
2021-02-01 9:24 ` Greg Kurz
2021-02-01 11:30 ` Christian Schoenebeck
2021-02-01 12:26 ` Greg Kurz
2021-02-01 13:15 ` Paolo Bonzini [this message]
2021-02-01 13:37 ` qemu_oss--- via
2021-02-25 16:31 ` Christian Schoenebeck
2021-02-25 16:47 ` Greg Kurz
2021-02-01 11:42 ` Peter Maydell
2021-02-01 13:44 ` Christian Schoenebeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca497b43-bea4-14be-f49e-6b8c374da4d5@redhat.com \
--to=pbonzini@redhat.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).