From: Eric Farman <farman@linux.ibm.com>
To: Matthew Rosato <mjrosato@linux.ibm.com>,
thuth@redhat.com, qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Cc: pmorel@linux.ibm.com, david@redhat.com, cohuck@redhat.com,
richard.henderson@linaro.org, pasic@linux.ibm.com,
borntraeger@linux.ibm.com
Subject: Re: [PATCH 3/4] s390x/pci: use the passthrough measurement update interval
Date: Thu, 02 Dec 2021 16:30:12 -0500 [thread overview]
Message-ID: <ca4dc1b5b8e7f737337381609e4b44fb62f8f3eb.camel@linux.ibm.com> (raw)
In-Reply-To: <20211202164110.326947-4-mjrosato@linux.ibm.com>
On Thu, 2021-12-02 at 11:41 -0500, Matthew Rosato wrote:
> We may have gotten a measurement update interval from the underlying
> host
> via vfio -- Use it to set the interval via which we update the
> function
> measurement block.
>
> Fixes: 28dc86a072 ("s390x/pci: use a PCI Group structure")
> Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
Reviewed-by: Eric Farman <farman@linux.ibm.com>
> ---
> hw/s390x/s390-pci-inst.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c
> index 11b7f6bfa1..07bab85ce5 100644
> --- a/hw/s390x/s390-pci-inst.c
> +++ b/hw/s390x/s390-pci-inst.c
> @@ -1046,7 +1046,7 @@ static void fmb_update(void *opaque)
> sizeof(pbdev->fmb.last_update))) {
> return;
> }
> - timer_mod(pbdev->fmb_timer, t + DEFAULT_MUI);
> + timer_mod(pbdev->fmb_timer, t + pbdev->pci_group-
> >zpci_group.mui);
> }
>
> int mpcifc_service_call(S390CPU *cpu, uint8_t r1, uint64_t fiba,
> uint8_t ar,
> @@ -1204,7 +1204,8 @@ int mpcifc_service_call(S390CPU *cpu, uint8_t
> r1, uint64_t fiba, uint8_t ar,
> }
> pbdev->fmb_addr = fmb_addr;
> timer_mod(pbdev->fmb_timer,
> - qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL) +
> DEFAULT_MUI);
> + qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL) +
> + pbdev->pci_group-
> >zpci_group.mui);
> break;
> }
> default:
next prev parent reply other threads:[~2021-12-02 21:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 16:41 [PATCH 0/4] s390x/pci: some small fixes Matthew Rosato
2021-12-02 16:41 ` [PATCH 1/4] s390x/pci: use a reserved ID for the default PCI group Matthew Rosato
2021-12-02 16:43 ` David Hildenbrand
2021-12-02 17:11 ` Matthew Rosato
2021-12-02 21:55 ` David Hildenbrand
2021-12-02 23:06 ` Halil Pasic
2021-12-03 2:25 ` Matthew Rosato
2021-12-03 9:07 ` Pierre Morel
2021-12-03 18:21 ` David Hildenbrand
2021-12-02 21:27 ` Eric Farman
2021-12-03 9:24 ` Pierre Morel
2021-12-02 16:41 ` [PATCH 2/4] s390x/pci: don't use hard-coded dma range in reg_ioat Matthew Rosato
2021-12-02 21:27 ` Eric Farman
2021-12-03 9:17 ` Pierre Morel
2021-12-02 16:41 ` [PATCH 3/4] s390x/pci: use the passthrough measurement update interval Matthew Rosato
2021-12-02 21:30 ` Eric Farman [this message]
2021-12-03 9:17 ` Pierre Morel
2021-12-02 16:41 ` [PATCH 4/4] s390x/pci: add supported DT information to clp response Matthew Rosato
2021-12-02 21:40 ` Eric Farman
2021-12-03 9:33 ` Pierre Morel
2021-12-03 12:03 ` Matthew Rosato
2021-12-03 12:06 ` Matthew Rosato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca4dc1b5b8e7f737337381609e4b44fb62f8f3eb.camel@linux.ibm.com \
--to=farman@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).