qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* Re: QEMU 6.2.0 and rhbz#1999878
       [not found] <CAJzYwARYDA+E4wrszx-F1D_9+VAYB2dU=M-LtvzPJey02gu2qg@mail.gmail.com>
@ 2021-12-03 19:37 ` Richard W.M. Jones
  2021-12-03 20:35   ` Eduardo Lima
  0 siblings, 1 reply; 6+ messages in thread
From: Richard W.M. Jones @ 2021-12-03 19:37 UTC (permalink / raw)
  To: Eduardo Lima
  Cc: peter.maydell, berrange, sw, richard.henderson, qemu-devel, f4bug

On Fri, Dec 03, 2021 at 04:20:23PM -0300, Eduardo Lima wrote:
> Hi Rich,
> 
> Can you confirm if the patch you added for qemu in Fedora has still not been
> merged upstream? I could not find it on the git source tree.
> 
> +Patch2: 0001-tcg-arm-Reduce-vector-alignment-requirement-for-NEON.patch
> +From 1331e4eec016a295949009b4360c592401b089f7 Mon Sep 17 00:00:00 2001
> +From: Richard Henderson <richard.henderson@linaro.org>
> +Date: Sun, 12 Sep 2021 10:49:25 -0700
> +Subject: [PATCH] tcg/arm: Reduce vector alignment requirement for NEON

https://bugzilla.redhat.com/show_bug.cgi?id=1999878
https://lists.nongnu.org/archive/html/qemu-devel/2021-09/msg01028.html

The patch I posted wasn't correct (or meant to be), it was just a
workaround.  However I think you're right - I don't believe the
original problem was ever fixed.

Let's see what upstreams says ...

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: QEMU 6.2.0 and rhbz#1999878
  2021-12-03 19:37 ` QEMU 6.2.0 and rhbz#1999878 Richard W.M. Jones
@ 2021-12-03 20:35   ` Eduardo Lima
  2021-12-03 21:03     ` Richard W.M. Jones
  0 siblings, 1 reply; 6+ messages in thread
From: Eduardo Lima @ 2021-12-03 20:35 UTC (permalink / raw)
  To: Richard W.M. Jones
  Cc: peter.maydell, Daniel Berrange, sw, richard.henderson, qemu-devel,
	f4bug

[-- Attachment #1: Type: text/plain, Size: 1769 bytes --]

On Fri, Dec 3, 2021 at 4:37 PM Richard W.M. Jones <rjones@redhat.com> wrote:

> On Fri, Dec 03, 2021 at 04:20:23PM -0300, Eduardo Lima wrote:
> > Hi Rich,
> >
> > Can you confirm if the patch you added for qemu in Fedora has still not
> been
> > merged upstream? I could not find it on the git source tree.
> >
> > +Patch2: 0001-tcg-arm-Reduce-vector-alignment-requirement-for-NEON.patch
> > +From 1331e4eec016a295949009b4360c592401b089f7 Mon Sep 17 00:00:00 2001
> > +From: Richard Henderson <richard.henderson@linaro.org>
> > +Date: Sun, 12 Sep 2021 10:49:25 -0700
> > +Subject: [PATCH] tcg/arm: Reduce vector alignment requirement for NEON
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1999878
> https://lists.nongnu.org/archive/html/qemu-devel/2021-09/msg01028.html
>
> The patch I posted wasn't correct (or meant to be), it was just a
> workaround.  However I think you're right - I don't believe the
> original problem was ever fixed.
>
Yes, I saw that your original patch had been replaced by this new one I
mentioned, so I thought it was the correct solution, but I could not find
this new one on the repository as well.

At the moment I kept it as part of 6.2.0 build, which I am just about to
push to rawhide. It builds locally, and I am only waiting for the
scratch-build to finish.

https://koji.fedoraproject.org/koji/taskinfo?taskID=79556515

Thanks, Eduardo.



>
> Let's see what upstreams says ...
>
> Rich.
>
> --
> Richard Jones, Virtualization Group, Red Hat
> http://people.redhat.com/~rjones
> Read my programming and virtualization blog: http://rwmj.wordpress.com
> virt-p2v converts physical machines to virtual machines.  Boot with a
> live CD or over the network (PXE) and turn machines into KVM guests.
> http://libguestfs.org/virt-v2v
>
>

[-- Attachment #2: Type: text/html, Size: 3926 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: QEMU 6.2.0 and rhbz#1999878
  2021-12-03 20:35   ` Eduardo Lima
@ 2021-12-03 21:03     ` Richard W.M. Jones
  2021-12-03 22:00       ` Richard Henderson
  0 siblings, 1 reply; 6+ messages in thread
From: Richard W.M. Jones @ 2021-12-03 21:03 UTC (permalink / raw)
  To: Eduardo Lima
  Cc: peter.maydell, Daniel Berrange, sw, richard.henderson, qemu-devel,
	f4bug

On Fri, Dec 03, 2021 at 05:35:41PM -0300, Eduardo Lima wrote:
> 
> 
> On Fri, Dec 3, 2021 at 4:37 PM Richard W.M. Jones <rjones@redhat.com> wrote:
> 
>     On Fri, Dec 03, 2021 at 04:20:23PM -0300, Eduardo Lima wrote:
>     > Hi Rich,
>     >
>     > Can you confirm if the patch you added for qemu in Fedora has still not
>     been
>     > merged upstream? I could not find it on the git source tree.
>     >
>     > +Patch2: 0001-tcg-arm-Reduce-vector-alignment-requirement-for-NEON.patch
>     > +From 1331e4eec016a295949009b4360c592401b089f7 Mon Sep 17 00:00:00 2001
>     > +From: Richard Henderson <richard.henderson@linaro.org>
>     > +Date: Sun, 12 Sep 2021 10:49:25 -0700
>     > +Subject: [PATCH] tcg/arm: Reduce vector alignment requirement for NEON
> 
>     https://bugzilla.redhat.com/show_bug.cgi?id=1999878
>     https://lists.nongnu.org/archive/html/qemu-devel/2021-09/msg01028.html
> 
>     The patch I posted wasn't correct (or meant to be), it was just a
>     workaround.  However I think you're right - I don't believe the
>     original problem was ever fixed.
>
> Yes, I saw that your original patch had been replaced by this new
> one I mentioned, so I thought it was the correct solution, but I
> could not find this new one on the repository as well.

Oh I see, it was indeed replaced by Richard Henderson's patch:

https://src.fedoraproject.org/rpms/qemu/blob/rawhide/f/0001-tcg-arm-Reduce-vector-alignment-requirement-for-NEON.patch

> At the moment I kept it as part of 6.2.0 build, which I am just about to push
> to rawhide. It builds locally, and I am only waiting for the scratch-build to
> finish.

Yes looks like we need to keep it, and get it upstream too.

Thanks,

Rich.

> https://koji.fedoraproject.org/koji/taskinfo?taskID=79556515
> 
> Thanks, Eduardo.
> 
>  
> 
> 
>     Let's see what upstreams says ...
> 
>     Rich.
> 
>     --
>     Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/
>     ~rjones
>     Read my programming and virtualization blog: http://rwmj.wordpress.com
>     virt-p2v converts physical machines to virtual machines.  Boot with a
>     live CD or over the network (PXE) and turn machines into KVM guests.
>     http://libguestfs.org/virt-v2v
> 
> 

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: QEMU 6.2.0 and rhbz#1999878
  2021-12-03 21:03     ` Richard W.M. Jones
@ 2021-12-03 22:00       ` Richard Henderson
  2021-12-04  0:09         ` Richard Henderson
  0 siblings, 1 reply; 6+ messages in thread
From: Richard Henderson @ 2021-12-03 22:00 UTC (permalink / raw)
  To: Richard W.M. Jones, Eduardo Lima
  Cc: peter.maydell, sw, Daniel Berrange, qemu-devel, f4bug

On 12/3/21 1:03 PM, Richard W.M. Jones wrote:
> On Fri, Dec 03, 2021 at 05:35:41PM -0300, Eduardo Lima wrote:
>>
>>
>> On Fri, Dec 3, 2021 at 4:37 PM Richard W.M. Jones <rjones@redhat.com> wrote:
>>
>>      On Fri, Dec 03, 2021 at 04:20:23PM -0300, Eduardo Lima wrote:
>>      > Hi Rich,
>>      >
>>      > Can you confirm if the patch you added for qemu in Fedora has still not
>>      been
>>      > merged upstream? I could not find it on the git source tree.
>>      >
>>      > +Patch2: 0001-tcg-arm-Reduce-vector-alignment-requirement-for-NEON.patch
>>      > +From 1331e4eec016a295949009b4360c592401b089f7 Mon Sep 17 00:00:00 2001
>>      > +From: Richard Henderson <richard.henderson@linaro.org>
>>      > +Date: Sun, 12 Sep 2021 10:49:25 -0700
>>      > +Subject: [PATCH] tcg/arm: Reduce vector alignment requirement for NEON
>>
>>      https://bugzilla.redhat.com/show_bug.cgi?id=1999878
>>      https://lists.nongnu.org/archive/html/qemu-devel/2021-09/msg01028.html
>>
>>      The patch I posted wasn't correct (or meant to be), it was just a
>>      workaround.  However I think you're right - I don't believe the
>>      original problem was ever fixed.
>>
>> Yes, I saw that your original patch had been replaced by this new
>> one I mentioned, so I thought it was the correct solution, but I
>> could not find this new one on the repository as well.
> 
> Oh I see, it was indeed replaced by Richard Henderson's patch:
> 
> https://src.fedoraproject.org/rpms/qemu/blob/rawhide/f/0001-tcg-arm-Reduce-vector-alignment-requirement-for-NEON.patch
> 
>> At the moment I kept it as part of 6.2.0 build, which I am just about to push
>> to rawhide. It builds locally, and I am only waiting for the scratch-build to
>> finish.
> 
> Yes looks like we need to keep it, and get it upstream too.

Whoops.  That dropped through the cracks.
I'll queue that now-ish.


r~


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: QEMU 6.2.0 and rhbz#1999878
  2021-12-03 22:00       ` Richard Henderson
@ 2021-12-04  0:09         ` Richard Henderson
  2021-12-09 16:22           ` Eduardo Lima
  0 siblings, 1 reply; 6+ messages in thread
From: Richard Henderson @ 2021-12-04  0:09 UTC (permalink / raw)
  To: Richard W.M. Jones, Eduardo Lima
  Cc: peter.maydell, sw, Daniel Berrange, qemu-devel, f4bug

On 12/3/21 2:00 PM, Richard Henderson wrote:
>> Oh I see, it was indeed replaced by Richard Henderson's patch:
>>
>> https://src.fedoraproject.org/rpms/qemu/blob/rawhide/f/0001-tcg-arm-Reduce-vector-alignment-requirement-for-NEON.patch 
>>
>>
>>> At the moment I kept it as part of 6.2.0 build, which I am just about to push
>>> to rawhide. It builds locally, and I am only waiting for the scratch-build to
>>> finish.
>>
>> Yes looks like we need to keep it, and get it upstream too.
> 
> Whoops.  That dropped through the cracks.
> I'll queue that now-ish.

https://patchew.org/QEMU/20210912174925.200132-1-richard.henderson@linaro.org/

Ah right, I was supposed to test your kernel and never got there.
Plus it never got any r-b's.

Rebase was smooth and regression testing went ok on cortex-a57 host.


r~


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: QEMU 6.2.0 and rhbz#1999878
  2021-12-04  0:09         ` Richard Henderson
@ 2021-12-09 16:22           ` Eduardo Lima
  0 siblings, 0 replies; 6+ messages in thread
From: Eduardo Lima @ 2021-12-09 16:22 UTC (permalink / raw)
  To: Richard Henderson
  Cc: Peter Maydell, Daniel Berrange, qemu-devel, sw, f4bug,
	Richard W.M. Jones

[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]

Thanks all, I saw the patch has been merged and is part of rc4. I'm
removing it from the fedora package.

On Fri, Dec 3, 2021 at 9:09 PM Richard Henderson <
richard.henderson@linaro.org> wrote:

> On 12/3/21 2:00 PM, Richard Henderson wrote:
> >> Oh I see, it was indeed replaced by Richard Henderson's patch:
> >>
> >>
> https://src.fedoraproject.org/rpms/qemu/blob/rawhide/f/0001-tcg-arm-Reduce-vector-alignment-requirement-for-NEON.patch
> >>
> >>
> >>> At the moment I kept it as part of 6.2.0 build, which I am just about
> to push
> >>> to rawhide. It builds locally, and I am only waiting for the
> scratch-build to
> >>> finish.
> >>
> >> Yes looks like we need to keep it, and get it upstream too.
> >
> > Whoops.  That dropped through the cracks.
> > I'll queue that now-ish.
>
>
> https://patchew.org/QEMU/20210912174925.200132-1-richard.henderson@linaro.org/
>
> Ah right, I was supposed to test your kernel and never got there.
> Plus it never got any r-b's.
>
> Rebase was smooth and regression testing went ok on cortex-a57 host.
>
>
> r~
>
>

[-- Attachment #2: Type: text/html, Size: 1891 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-12-09 16:24 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <CAJzYwARYDA+E4wrszx-F1D_9+VAYB2dU=M-LtvzPJey02gu2qg@mail.gmail.com>
2021-12-03 19:37 ` QEMU 6.2.0 and rhbz#1999878 Richard W.M. Jones
2021-12-03 20:35   ` Eduardo Lima
2021-12-03 21:03     ` Richard W.M. Jones
2021-12-03 22:00       ` Richard Henderson
2021-12-04  0:09         ` Richard Henderson
2021-12-09 16:22           ` Eduardo Lima

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).