From: John Snow <jsnow@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: libvir-list@redhat.com, peterx@redhat.com
Subject: Re: [PATCH] docs/interop/qmp-spec: Document the request queue limit
Date: Wed, 27 Jan 2021 14:26:49 -0500 [thread overview]
Message-ID: <ca649f4c-ba21-e3b6-9c56-c14138f88f45@redhat.com> (raw)
In-Reply-To: <20210127144734.2367693-1-armbru@redhat.com>
On 1/27/21 9:47 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> docs/interop/qmp-spec.txt | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/docs/interop/qmp-spec.txt b/docs/interop/qmp-spec.txt
> index cdf5842555..b0e8351d5b 100644
> --- a/docs/interop/qmp-spec.txt
> +++ b/docs/interop/qmp-spec.txt
> @@ -133,9 +133,11 @@ to pass "id" with out-of-band commands. Passing it with all commands
> is recommended for clients that accept capability "oob".
>
> If the client sends in-band commands faster than the server can
> -execute them, the server will stop reading the requests from the QMP
> -channel until the request queue length is reduced to an acceptable
> -range.
> +execute them, the server will stop reading requests until the request
> +queue length is reduced to an acceptable range.
> +
> +To ensure commands to be executed out-of-band get read and executed,
> +the client should have at most eight in-band commands in flight.
>
> Only a few commands support out-of-band execution. The ones that do
> have "allow-oob": true in output of query-qmp-schema.
>
Great to know, thank you!
Reviewed-by: John Snow <jsnow@redhat.com>
next prev parent reply other threads:[~2021-01-27 19:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 14:47 [PATCH] docs/interop/qmp-spec: Document the request queue limit Markus Armbruster
2021-01-27 19:26 ` John Snow [this message]
2021-02-02 14:29 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca649f4c-ba21-e3b6-9c56-c14138f88f45@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=libvir-list@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).