Re: [PATCH 6/8] target/ppc: Move div/mod fixed-point insns (64 bits operands) to decodetree.

[Chinmay Rath <rathc@linux.vnet.ibm.com>]

On 4/17/24 00:08, Richard Henderson wrote:
> On 4/15/24 23:39, Chinmay Rath wrote:
>> Moving the below instructions to decodetree specification :
>>
>>     divd[u, e, eu][o][.]    : XO-form
>>     mod{sd, ud}        : X-form
>>
>> With this patch, all the fixed-point arithmetic instructions have been
>> moved to decodetree.
>> The changes were verified by validating that the tcg ops generated by 
>> those
>> instructions remain the same, which were captured using the '-d 
>> in_asm,op' flag.
>> Also, remaned do_divwe method in fixedpoint-impl.c.inc to do_dive 
>> because it is
>> now used to divide doubleword operands as well, and not just words.
>>
>> Signed-off-by: Chinmay Rath<rathc@linux.ibm.com>
>> ---
>>   target/ppc/helper.h                        |  4 +-
>>   target/ppc/insn32.decode                   |  8 +++
>>   target/ppc/int_helper.c                    |  4 +-
>>   target/ppc/translate.c                     | 65 ++--------------------
>>   target/ppc/translate/fixedpoint-impl.c.inc | 29 +++++++++-
>>   5 files changed, 42 insertions(+), 68 deletions(-)
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
Thanks,
Chinmay
> r~