From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, pbonzini@redhat.com
Subject: Re: [PATCH v3 6/6] include/exec: Introduce TARGET_PAGE_ENTRY_EXTRA
Date: Tue, 6 Sep 2022 08:42:36 +0100 [thread overview]
Message-ID: <ca6afa63-4ba5-ae4a-2af8-d7c1df9fcc1d@linaro.org> (raw)
In-Reply-To: <80ce327e-4381-743d-fd63-3b04006e4228@amsat.org>
On 9/5/22 22:28, Philippe Mathieu-Daudé wrote:
>> + /*
>> + * Allow target-specific additions to this structure.
>> + * This may be used to cache items from the guest cpu
>> + * page tables for later use by the implementation.
>> + */
>> +#ifdef TARGET_PAGE_ENTRY_EXTRA
>> + TARGET_PAGE_ENTRY_EXTRA
>> +#endif
>> } CPUTLBEntryFull;
>
> Alternatively declare a per-target structure in cpu-param.h
> and here:
>
> typedef struct CPUTLBEntryTarget CPUTLBEntryTarget;
>
> #ifndef TARGET_HAS_PAGE_ENTRY_EXTRA_STRUCT
> struct CPUTLBEntryTarget { }
> #endif
This was v1, more or less,
https://lore.kernel.org/qemu-devel/20220703082419.770989-2-richard.henderson@linaro.org/
In the end I thought the "extra" part confusing.
I was also concerned that I might be introducing
extra structure padding unnecessarily.
r~
next prev parent reply other threads:[~2022-09-06 7:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 20:22 [PATCH v3 0/6] tcg: Introduce CPUTLBEntryFull Richard Henderson
2022-09-05 20:22 ` [PATCH v3 1/6] accel/tcg: Rename CPUIOTLBEntry to CPUTLBEntryFull Richard Henderson
2022-09-05 21:07 ` Philippe Mathieu-Daudé via
2022-09-20 10:42 ` Peter Maydell
2022-09-05 20:22 ` [PATCH v3 2/6] accel/tcg: Drop addr member from SavedIOTLB Richard Henderson
2022-09-05 21:07 ` Philippe Mathieu-Daudé via
2022-09-20 10:43 ` Peter Maydell
2022-09-05 20:22 ` [PATCH v3 3/6] accel/tcg: Suppress auto-invalidate in probe_access_internal Richard Henderson
2022-09-20 11:21 ` Peter Maydell
2022-09-05 20:22 ` [PATCH v3 4/6] accel/tcg: Introduce probe_access_full Richard Henderson
2022-09-05 21:10 ` Philippe Mathieu-Daudé via
2022-09-20 10:46 ` Peter Maydell
2022-09-05 20:22 ` [PATCH v3 5/6] accel/tcg: Introduce tlb_set_page_full Richard Henderson
2022-09-05 21:20 ` Philippe Mathieu-Daudé via
2022-09-20 10:59 ` Peter Maydell
2022-09-05 20:22 ` [PATCH v3 6/6] include/exec: Introduce TARGET_PAGE_ENTRY_EXTRA Richard Henderson
2022-09-05 21:28 ` Philippe Mathieu-Daudé via
2022-09-06 7:42 ` Richard Henderson [this message]
2022-09-20 10:59 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca6afa63-4ba5-ae4a-2af8-d7c1df9fcc1d@linaro.org \
--to=richard.henderson@linaro.org \
--cc=f4bug@amsat.org \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).