From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Taylor Simpson <tsimpson@quicinc.com>
Subject: Re: [PATCH] target/hexagon: Drop include of qemu.h
Date: Sat, 17 Jul 2021 08:46:09 -0700 [thread overview]
Message-ID: <ca86bb31-6ced-58a5-5394-96c2085f7953@linaro.org> (raw)
In-Reply-To: <20210717103017.20491-1-peter.maydell@linaro.org>
On 7/17/21 3:30 AM, Peter Maydell wrote:
> The qemu.h file is a CONFIG_USER_ONLY header; it doesn't appear on
> the include path for softmmu builds. Currently we include it
> unconditionally in target/hexagon/op_helper.c. We used to need it
> for the put_user_*() and get_user_*() functions, but now that we have
> removed the uses of those from op_helper.c, the only reason it's
> still there is that we're implicitly relying on it pulling in some
> other headers.
>
> Explicitly include the headers we need for other functions, and drop
> the include of qemu.h.
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
> Based-on:1626384156-6248-1-git-send-email-tsimpson@quicinc.com
> ("[PATCH v3 0/2] SIGSEGV fixes")
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2021-07-17 15:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-17 10:30 [PATCH] target/hexagon: Drop include of qemu.h Peter Maydell
2021-07-17 10:58 ` Alex Bennée
2021-07-17 15:46 ` Richard Henderson [this message]
2021-07-17 23:08 ` Taylor Simpson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca86bb31-6ced-58a5-5394-96c2085f7953@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).