Re: [PATCH] softmmu: fix crash with invalid -M memory-backend=

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 3/9/20 3:51 PM, Marc-André Lureau wrote:
> Fixes: fe64d06afc1c5d895f220c268cfe4d5f1e65d44e ("vl.c: ensure that
> ram_size matches size of machine.memory-backend")

<new line>

> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>   softmmu/vl.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/softmmu/vl.c b/softmmu/vl.c
> index 5549f4b619..38e9c404f2 100644
> --- a/softmmu/vl.c
> +++ b/softmmu/vl.c
> @@ -4287,6 +4287,11 @@ void qemu_init(int argc, char **argv, char **envp)
>   
>           backend = object_resolve_path_type(current_machine->ram_memdev_id,
>                                              TYPE_MEMORY_BACKEND, NULL);
> +        if (!backend) {
> +            error_report("Memory backend '%s' not found",
> +                         current_machine->ram_memdev_id);
> +            exit(EXIT_FAILURE);
> +        }
>           backend_size = object_property_get_uint(backend, "size",  &error_abort);
>           if (have_custom_ram_size && backend_size != ram_size) {
>                   error_report("Size specified by -m option must match size of "
>