From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA400C77B7A for ; Thu, 25 May 2023 11:49:53 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q29T4-000759-Sl; Thu, 25 May 2023 07:49:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q29T3-00074s-Qs for qemu-devel@nongnu.org; Thu, 25 May 2023 07:49:17 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q29T2-00051J-0d for qemu-devel@nongnu.org; Thu, 25 May 2023 07:49:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685015355; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4dgPC8uTDwa1MM9V27R2UndeI639Y0bPbns0a3kp1FE=; b=JO+G0pwgz0ECU+kwGD7wlAc1qBL69IVfDSalWlR9QcBjvd4UwvOeK6K1/P63F8XMNTPhKk pYsSSSHOY7vWTLPMeGUJA2Bd+Wu9mVFMARnuebftDl8BQqRcIpuZt6BhGS68pmWkfvZnEr JW1/NgmcGE1Al/UBjbgleLiG4cJHlTM= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-220-Nec68Q94NY69ED3509M1fg-1; Thu, 25 May 2023 07:49:13 -0400 X-MC-Unique: Nec68Q94NY69ED3509M1fg-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3078b9943d6so812786f8f.1 for ; Thu, 25 May 2023 04:49:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685015352; x=1687607352; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4dgPC8uTDwa1MM9V27R2UndeI639Y0bPbns0a3kp1FE=; b=le3uaQ/hlLNO8mLTTh08JTr/BJmte1x3zWfJCAr2f/tS6/OFq+eI7xQmSN4mn9xuks oh7+vAPbsSBk8+RcsDEZMXug3RcMWgAyRepuuYdQse29iUki6eGcHle6Jvz5nDjFRwIX 96Q7b+pyw1gah910iL+AhqvM62a4GyqceXElXVCaba1ZtqD7bMVpjWAWQG0dzNSiWbS7 cTkjFt8xHxBfHndt8uIBpa3xd0r6zd5pusfS+66M0zksRZKjENkXgW1sOROYyvgpfW9n eotVCrJidTk5Ky0P7RZX2oUN4oSwEoWZaeekXmu/2watrsJxXBWwcyxYDWoDXIky9oya MQag== X-Gm-Message-State: AC+VfDysRVMbO3SEkL29YoS4qeJlQjckyVHcmv06IbCLd68Ij9UCD6GF CYUn/fYquYcIireWtfobU3AT/s2VcEI8kBNDV5s1owf/4ydk01ehCXdk8T3Ts109rmx2/ZzBQ3Z 6ofXekwb4VVckon0= X-Received: by 2002:adf:f58f:0:b0:306:30e8:eb34 with SMTP id f15-20020adff58f000000b0030630e8eb34mr1782166wro.48.1685015352308; Thu, 25 May 2023 04:49:12 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5PBZvFwI7L7UjNPLSeE7/7uW8UJ/iIKFgZhST971X/FfDRb2XpAgWhrMY44c5VVL35OBoKcg== X-Received: by 2002:adf:f58f:0:b0:306:30e8:eb34 with SMTP id f15-20020adff58f000000b0030630e8eb34mr1782150wro.48.1685015351977; Thu, 25 May 2023 04:49:11 -0700 (PDT) Received: from [192.168.0.3] (ip-109-43-177-30.web.vodafone.de. [109.43.177.30]) by smtp.gmail.com with ESMTPSA id g14-20020a5d540e000000b00307a86a4bcesm1581644wrv.35.2023.05.25.04.49.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 May 2023 04:49:11 -0700 (PDT) Message-ID: Date: Thu, 25 May 2023 13:49:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 1/2] docs: sbsa: correct graphics card name Content-Language: en-US To: Peter Maydell , Mark Cave-Ayland , Paolo Bonzini , Gerd Hoffmann , "Daniel P. Berrange" Cc: Marcin Juszkiewicz , qemu-devel@nongnu.org, qemu-arm@nongnu.org, Leif Lindholm References: <20230523155644.678524-1-marcin.juszkiewicz@linaro.org> <4101dedc-91d7-1735-4655-81082931b79d@linaro.org> <49fa8502-70f9-cdc4-1058-9d4202400db6@redhat.com> <87675164-50ce-a387-12a8-f965b450eb28@ilande.co.uk> From: Thomas Huth In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.091, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 25/05/2023 13.39, Peter Maydell wrote: > On Thu, 25 May 2023 at 12:06, Mark Cave-Ayland > wrote: >> >> On 25/05/2023 11:44, Peter Maydell wrote: >> >>> On Thu, 25 May 2023 at 11:32, Thomas Huth wrote: >>> >>>> So there needs to be at least some logic dealing with vga_interface_type if >>>> we want to be able to select a different graphics card for this machine. >>>> Then why not go the full way and use pci_vga_init() here, too? ... that's >>>> certainly the least confusing way for the users. >>> >>> Is it? From an Arm perspective, having "-vga" do anything >>> at all is pretty confusing: it's a rather PC-centric option name. >>> (Also pretty noticeable for the Sparc TCX/CG3 framebuffers, >>> which are not VGA in any way.) >> >> Right. From the SPARC perspective it was added to allow the user to select either the >> TCX (default) or CG3 framebuffers from the command line. >> >> However I guess that shouldn't be needed anymore now that mc->default_display exists. >> Presumably there is now some kind of -global sun4m.default_display=cg3 command line >> option that could set the machine default_display property value instead? > > Maybe. Handling builtin default devices remains kind of awkward. > But for this Arm board they're all just PCI cards, so the > only thing we really need is a way to say "don't create that > default device"... I wonder whether we could deprecate and finally remove "-vga" ... there is also the "graphics" machine property that is used by some boards instead, so maybe we could use that as a replacement for "-vga none" everywhere (and use "-device xxx" as replacement for "vga xxx" of course). Thoughts? Thomas