Re: [RFC PATCH for-7.1] Remove the slirp submodule (and only compile with an external libslirp)

[Paolo Bonzini <pbonzini@redhat.com>]

On 4/11/22 09:11, Paolo Bonzini wrote:
> On 4/8/22 18:47, Thomas Huth wrote:
>> The only one that still seems to be missing a libslirp package is
>> OpenBSD - but I assume that they can add it to their ports system
>> quickly if required.
>>
>> So there is no real urgent need for keeping the slirp submodule in
>> the QEMU tree anymore. Thus let's drop the slirp submodule now and
>> rely on the libslirp packages from the distributions instead.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
> 
> I would like to have feature parity even with CFI.  I had written the 
> libslirp side a few months ago, but never tested it because I didn't get 
> to the QEMU side.
> 
> I updated it and you can find it at 
> https://gitlab.freedesktop.org/slirp/libslirp/-/merge_requests/117. I'll 
> get to the QEMU side now.

Also, doing this at the same time as a switch to Meson >=0.60 (probably 
0.61.x) would allow something like

option('slirp', type: 'feature', value: 'auto',
        description: 'libslirp user mode network backend support',
        deprecated: {'system': 'enabled', 'internal': 'auto'})

This keeps incremental builds working.  All of this should be doable in 
7.1, so this is not an objection to removing the submodule in 7.1.

Paolo