qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: deller@kernel.org, qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>,
	Helge Deller <deller@gmx.de>
Subject: Re: [PATCH 3/5] target/hppa: Do not use hardcoded value for tlb_flush_*()
Date: Fri, 25 Aug 2023 09:14:02 +0200	[thread overview]
Message-ID: <cac0f87b-8026-8e02-c6b3-a415af664f55@linaro.org> (raw)
In-Reply-To: <20230824210434.151971-4-deller@kernel.org>

On 24/8/23 23:04, deller@kernel.org wrote:
> From: Helge Deller <deller@gmx.de>
> 
> Avoid using hardcoded values when calling the tlb_flush*() functions.
> Instead define the correct mask (HPPA_MMU_FLUSH_MASK) and use it.
> Skip flushing the MMU for physical addresses.

Alternatively:

   Instead, define and use HPPA_MMU_FLUSH_MASK (keeping the current
   behavior, which doesn't flush the physical address MMU).

> 
> Signed-off-by: Helge Deller <deller@gmx.de>
> ---
>   target/hppa/cpu.h        | 5 +++++
>   target/hppa/helper.c     | 2 +-
>   target/hppa/mem_helper.c | 7 +++----
>   3 files changed, 9 insertions(+), 5 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



  reply	other threads:[~2023-08-25  7:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-24 21:04 [PATCH 0/5] target/hppa: Clean up conversion from/to MMU index and priviledge level deller
2023-08-24 21:04 ` [PATCH 1/5] target/hppa: Add missing PL1 and PL2 priviledge levels deller
2023-08-25  7:11   ` Philippe Mathieu-Daudé
2023-08-24 21:04 ` [PATCH 2/5] target/hppa: Add priviledge to MMU index conversion helpers deller
2023-08-25  7:09   ` Philippe Mathieu-Daudé
2023-08-24 21:04 ` [PATCH 3/5] target/hppa: Do not use hardcoded value for tlb_flush_*() deller
2023-08-25  7:14   ` Philippe Mathieu-Daudé [this message]
2023-08-24 21:04 ` [PATCH 4/5] target/hppa: Use privilege helper in hppa_get_physical_address() deller
2023-08-25  7:15   ` Philippe Mathieu-Daudé
2023-08-24 21:04 ` [PATCH 5/5] target/hppa: Switch to use MMU indices 11-15 deller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cac0f87b-8026-8e02-c6b3-a415af664f55@linaro.org \
    --to=philmd@linaro.org \
    --cc=deller@gmx.de \
    --cc=deller@kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).