From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eMHfs-0001c2-BX for qemu-devel@nongnu.org; Tue, 05 Dec 2017 13:10:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eMHfo-0001SL-Ad for qemu-devel@nongnu.org; Tue, 05 Dec 2017 13:10:32 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:49088 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eMHfo-0001RZ-37 for qemu-devel@nongnu.org; Tue, 05 Dec 2017 13:10:28 -0500 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id vB5I9x8k075896 for ; Tue, 5 Dec 2017 13:10:25 -0500 Received: from e17.ny.us.ibm.com (e17.ny.us.ibm.com [129.33.205.207]) by mx0b-001b2d01.pphosted.com with ESMTP id 2enx79g8eq-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 05 Dec 2017 13:10:23 -0500 Received: from localhost by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 5 Dec 2017 13:10:22 -0500 References: <20171201151538.6844-1-farman@linux.vnet.ibm.com> <20171201151538.6844-2-farman@linux.vnet.ibm.com> <77147a49-b8b3-d94d-80ab-5ab279fbc8b9@redhat.com> <4f6e5359-2aee-64c3-332f-b60bb1c9af1f@linux.vnet.ibm.com> <20171205025804-mutt-send-email-mst@kernel.org> From: Eric Farman Date: Tue, 5 Dec 2017 13:10:19 -0500 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Message-Id: Subject: Re: [Qemu-devel] [PATCH 1/1] vhost-scsi: add missing virtqueue_size parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , "Michael S. Tsirkin" Cc: QEMU Developers , "Richard W . M . Jones" , Felipe Franciosi , Paolo Bonzini , Dariusz Stojaczyk On 12/05/2017 07:40 AM, Peter Maydell wrote: > On 5 December 2017 at 00:59, Michael S. Tsirkin wrote: >> On Mon, Dec 04, 2017 at 03:00:45PM -0500, Eric Farman wrote: >>> >>> >>> On 12/04/2017 01:05 PM, Peter Maydell wrote: >>>> On 4 December 2017 at 17:52, Eric Farman wrote: >>>>> On 12/01/2017 10:16 AM, Paolo Bonzini wrote: >>>>>> >>>>>> On 01/12/2017 16:15, Eric Farman wrote: >>>>>>> diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c >>>>>>> index cd4ab05233..9c1bea8ff3 100644 >>>>>>> --- a/hw/scsi/vhost-scsi.c >>>>>>> +++ b/hw/scsi/vhost-scsi.c >>>>>>> @@ -233,6 +233,8 @@ static Property vhost_scsi_properties[] = { >>>>>>> DEFINE_PROP_STRING("wwpn", VirtIOSCSICommon, conf.wwpn), >>>>>>> DEFINE_PROP_UINT32("boot_tpgt", VirtIOSCSICommon, conf.boot_tpgt, >>>>>>> 0), >>>>>>> DEFINE_PROP_UINT32("num_queues", VirtIOSCSICommon, conf.num_queues, >>>>>>> 1), >>>>>>> + DEFINE_PROP_UINT32("virtqueue_size", VirtIOSCSICommon, >>>>>>> conf.virtqueue_size, >>>>>>> + 128), >>>>>>> DEFINE_PROP_UINT32("max_sectors", VirtIOSCSICommon, >>>>>>> conf.max_sectors, >>>>>>> 0xFFFF), >>>>>>> DEFINE_PROP_UINT32("cmd_per_lun", VirtIOSCSICommon, >>>>>>> conf.cmd_per_lun, 128), >>>> >>>>> Wow, super quick, thank you! Seeing conversations today, is this queued for >>>>> -rc4, or 2.12 and backport to qemu-stable? >>>> >>>> If people can come to a consensus on whether this is -rc4 material >>>> by Tuesday 12:00 GMT that would be helpful. >>> >>> I'd vote for -rc4, since it's a new guest crash since 2.10. >> >> I think so too. > > Thanks; spoke also with Paolo on irc, and have pushed this to master > for -rc4. Cool! I just pulled master/rc4 and tested this scenario, and it works great. Thanks everyone! - Eric