From: John Snow <jsnow@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-trivial@nongnu.org, mrezanin@redhat.com,
Eduardo Habkost <ehabkost@redhat.com>,
qemu-block@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-doc: Do not hard-code the name of the QEMU binary
Date: Wed, 28 Aug 2019 15:18:58 -0400 [thread overview]
Message-ID: <cad0e700-be32-3fc2-210a-b395c0f00a12@redhat.com> (raw)
In-Reply-To: <20190828093447.12441-1-thuth@redhat.com>
On 8/28/19 5:34 AM, Thomas Huth wrote:
> In our documentation, we use a mix of "$QEMU", "qemu-system-i386" and
> "qemu-system-x86_64" when we give examples to the users how to run
> QEMU. Some more consistency would be good here. Also some distributions
> use different names for the QEMU binary (e.g. "qemu-kvm" in RHEL), so
> providing more flexibility here would also be good. Thus let's define
> some variables for the names of the QEMU command and use those in the
> documentation instead: @value{qemu_system} for generic examples, and
> @value{qemu_system_x86} for examples that only work with the x86
> binaries.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Makes sense to me, but do we want a definitions.texi or similar that can
be used globally (and is easy to find and edit by e.g. distro
packagers), or is it better to re-define them per-each file as you've done?
--js
next prev parent reply other threads:[~2019-08-28 20:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 9:34 [Qemu-devel] [PATCH] qemu-doc: Do not hard-code the name of the QEMU binary Thomas Huth
2019-08-28 19:18 ` John Snow [this message]
2019-08-29 5:41 ` [Qemu-devel] [Qemu-block] " Thomas Huth
2019-08-29 17:29 ` John Snow
2019-08-30 8:03 ` [Qemu-devel] " Miroslav Rezanina
2020-01-14 14:34 ` Peter Maydell
2020-01-14 14:52 ` Miroslav Rezanina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cad0e700-be32-3fc2-210a-b395c0f00a12@redhat.com \
--to=jsnow@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mrezanin@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).