From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01AE0CCFA18 for ; Tue, 11 Nov 2025 04:11:06 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vIfiS-00034m-W9; Mon, 10 Nov 2025 23:10:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vIfgD-0001Zm-JX for qemu-devel@nongnu.org; Mon, 10 Nov 2025 23:08:33 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vIfg7-0000LO-QQ for qemu-devel@nongnu.org; Mon, 10 Nov 2025 23:08:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762834102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uohHNH9wZFBBqRf+7H5zTRW9WT7sd4c/Jhauiiq23sg=; b=gTtJNKArxdcZKM6FMbBNqR20bpdUTcUX6wRgEDHi0YeSILoj28NsNia4WDn1fsGfqmIaHu GHkRcPstXPpYxv9uV2y2NBSpvBoWre7d0IpYUz8pT3iWf9tDm6UMwAvNErAfa6t1zFpbAS iJwxOWAsT9dgPAJ/y7Q/rYqNi8hNGoU= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-424-2toh3LOjPF2jy0o8cQlJBQ-1; Mon, 10 Nov 2025 23:08:20 -0500 X-MC-Unique: 2toh3LOjPF2jy0o8cQlJBQ-1 X-Mimecast-MFC-AGG-ID: 2toh3LOjPF2jy0o8cQlJBQ_1762834099 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-3418ad76023so9423739a91.0 for ; Mon, 10 Nov 2025 20:08:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1762834099; x=1763438899; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uohHNH9wZFBBqRf+7H5zTRW9WT7sd4c/Jhauiiq23sg=; b=bjZQ27UieE/NrUff+1mn/uWeWEu491CZU9CWoReMUjTQpF9M2WX+2n5GSDXV+3ZJ57 JguqYhAns+CQECtQVrwdwvgGwenDgNNdjcIgRYlqeZFv4iZZg40a8BL8uwrdvGNdtfql IZwpcsYjCzgR304g+WN+2eKugGBUqZSCSjh3QHPG4U26m7/iq0MQgIKEqTfL1EwdQ7dx wQDdo9Q+PJ4TnT3iDtWAVO/e8g6HCkfPqizTg70cNskFX8G+Icm1B6qQEyW5r5d2i4WK Srw3J3CpwF1H7V1ahh4Z3ZHijdQFo52ZN4V3X6rr7mYRuxJZA/eDaL96+Y5W+hIJcxNC 2UOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762834099; x=1763438899; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uohHNH9wZFBBqRf+7H5zTRW9WT7sd4c/Jhauiiq23sg=; b=jRqTvKB4hAwcv9Qqp55ixnEUeDJRQMsB5DWvK9HLH00YMtWAaODhVn5pVKU5yZ00TS 3u5bnGkndJWxpYWdYi/oDeYU352/roLfM2svblASpqIhE+PAJqTMT2X6gxFUg5JYBTsT h8F+ONRpv8Z3hZJFHD9ptb6VFDOk3FEOs+yuQs4MOKGy36fQ1I2IeC1tr42jBLUur1ra vXDY26xYDpS4N0GCIHYkxMzQDlGfa/T/RL4utqGFt5i2TW0hMRTOdlcRq9Y7PFG71EEX 0QUdQoDDMd4b8/A9eEBhGNebzU6FCen3PVgDjebQEXY4KxkrxlZxS14QTVekQCLj4KjU Fwaw== X-Forwarded-Encrypted: i=1; AJvYcCVGxVMvrr/J2K5WtHFeKhqS7DGu8pq2qp43iKzoWgpqmNPLNmMvdbKjcAavwJeLNn2JdVchkspgwEZX@nongnu.org X-Gm-Message-State: AOJu0YxXMy0IMItWsNiPXCXJnDl1n9s92LPITdJPu6RQJgNMDXYs4Y03 hv9i9EKRtoDvh5E0fADZgwGZLBhyMP1pXLsbE4vOrVXO+Nojn+1EP+SMrZ67KlmxML14VLWX2HF m8E9vTrWInYWjsEd5G4xDxWXnGTaspfUZadtnMdQtPYMeSoNvLEyaBWdk X-Gm-Gg: ASbGncvZTbtApXdiQ8h4d/FWvEJwEgzy/em9Dyg9v5+EEFzetluMfFzp0rt0a+7FEZn gL7Y7U9jlSiqlke57aaIz3BLYt0fw/Prw/2xqv518QHarRuomKBTJnQqvpVKJMLilb1SKKtVuM9 Wyi+AixJKDAqhVrkB2Te/E07RYiqenJy9wY2vcrjFmYlGpQZ5q4HksFCdTf8uUV8N7/19jsPqoi maUC8T+CuoeFsnMlfJLMFoDyUPd6QX8x0/uRTzC496wTpsX9Rlzumh786/apFM4SYal6bLnrEGQ qWbL5saalAXOC35UQ/vmCDZQM22A7XIZ5r6vBSEdwjfx9rgPyB/2JNi5hHVPsxsNesVByUO8E1A lWFB6H7ye6i/mR2nRJ+7AudbmstsvxZJKM0D95t0= X-Received: by 2002:a17:902:cf04:b0:296:5e6b:e1c8 with SMTP id d9443c01a7336-297e5606ec8mr138440855ad.13.1762834099438; Mon, 10 Nov 2025 20:08:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IGn/X6BKBS+OlMyI2SeRFVV2xfbY+0yelul7zDFlP3b/x9cTC0IGUu3UKpj39I5VTDbW6LPJg== X-Received: by 2002:a17:902:cf04:b0:296:5e6b:e1c8 with SMTP id d9443c01a7336-297e5606ec8mr138440515ad.13.1762834099008; Mon, 10 Nov 2025 20:08:19 -0800 (PST) Received: from [192.168.68.51] (n175-34-62-5.mrk21.qld.optusnet.com.au. [175.34.62.5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29650c5eb35sm163336385ad.38.2025.11.10.20.08.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Nov 2025 20:08:18 -0800 (PST) Message-ID: Date: Tue, 11 Nov 2025 14:08:13 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/8] acpi/ghes: Extend acpi_ghes_memory_errors() to support multiple CPERs To: Igor Mammedov Cc: Jonathan Cameron , shan.gavin@gmail.com, qemu-arm@nongnu.org, qemu-devel@nongnu.org, mchehab+huawei@kernel.org, gengdongjiu1@gmail.com, mst@redhat.com, anisinha@redhat.com, peter.maydell@linaro.org, pbonzini@redhat.com References: <20251105114453.2164073-1-gshan@redhat.com> <20251105114453.2164073-5-gshan@redhat.com> <20251105141455.000052f0@huawei.com> <20251110154957.5c481df7@fedora> Content-Language: en-US From: Gavin Shan In-Reply-To: <20251110154957.5c481df7@fedora> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=gshan@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi Igor and Jonathan, On 11/11/25 12:49 AM, Igor Mammedov wrote: > On Thu, 6 Nov 2025 13:15:52 +1000 > Gavin Shan wrote: >> On 11/6/25 12:14 AM, Jonathan Cameron wrote: >>> On Wed, 5 Nov 2025 21:44:49 +1000 >>> Gavin Shan wrote: >>> >>>> In the situation where host and guest has 64KiB and 4KiB page sizes, >>>> one problematic host page affects 16 guest pages. we need to send 16 >>>> consective errors in this specific case. >>>> >>>> Extend acpi_ghes_memory_errors() to support multiple CPERs after the >>>> hunk of code to generate the GHES error status is pulled out from >>>> ghes_gen_err_data_uncorrectable_recoverable(). The status field of >>>> generic error status block is also updated accordingly if multiple >>>> error data entries are contained in the generic error status block. >>>> >>>> Signed-off-by: Gavin Shan >>> Hi Gavin, >>> >>> Mostly fine, but a few comments on the defines added and a >>> question on what the multiple things are meant to mean? >>> >> >> Thanks for your review and comments, replies as below. >> >>>> diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c >>>> index a9c08e73c0..527b85c8d8 100644 >>>> --- a/hw/acpi/ghes.c >>>> +++ b/hw/acpi/ghes.c >>>> @@ -57,8 +57,12 @@ >>>> /* The memory section CPER size, UEFI 2.6: N.2.5 Memory Error Section */ >>>> #define ACPI_GHES_MEM_CPER_LENGTH 80 >>>> >>>> -/* Masks for block_status flags */ >>>> -#define ACPI_GEBS_UNCORRECTABLE 1 >>>> +/* Bits for block_status flags */ >>>> +#define ACPI_GEBS_UNCORRECTABLE 0 >>>> +#define ACPI_GEBS_CORRECTABLE 1 >>>> +#define ACPI_GEBS_MULTIPLE_UNCORRECTABLE 2 >>>> +#define ACPI_GEBS_MULTIPLE_CORRECTABLE 3 >>> >>> So this maps to the bits in block status. >>> >>> I'm not actually sure what these multiple variants are meant to tell us. >>> The multiple error blocks example referred to by the spec is a way to represent >>> the same error applying to multiple places. So that's one error, many blocks. >>> I have no idea if we set these bits in that case. >>> >>> Based on a quick look I don't think linux even takes any notice. THere >>> are defines in actbl1.h but I'm not seeing any use made of them. >>> >> >> I hope Igor can confirm since it was suggested by him. >> >> It's hard to understand how exactly these multiple variants are used from the >> spec. In ACPI 6.5 Table 18.11, it's explained as below. >> >> Bit [2] - Multiple Uncorrectable Errors: If set to one, indicates that more >> than one uncorrectable errors have been detected. >> >> I don't see those multiple variants have been used by Linux. So I think it's >> safe to drop them. > > even though example describes 'same' error at different components, > the bit fields descriptions doesn't set any limits on what 'more than one' means. > > Also from guest POV it's multiple different pages that we are reporting here > as multiple CPERs. > It seems to me that setting *_MULTIPLE_* here is correct thing to do. > I don't have strong opinions. Lets keep to set _MULTIPLE_ flag if Jonathan is fine. Again, this field isn't used by Linux guest. >>>> +#define ACPI_GEBS_ERROR_DATA_ENTRIES 4 >>> >>> This is bits 4-13 and the define isn't used. I'd drop it. >>> >> >> The definition is used in acpi_ghes_memory_errors() of this patch. However, >> I don't see it has been used by Linux. This field isn't used by Linux to determine >> the total number of error entries. So I think I can drop it either if Igor is ok. >> Lets keep this field either in next revision if Jonathan is fine. Thanks, Gavin