From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1chBDJ-0006b5-Od for qemu-devel@nongnu.org; Fri, 24 Feb 2017 03:26:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1chBDF-0007dK-R0 for qemu-devel@nongnu.org; Fri, 24 Feb 2017 03:26:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35036) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1chBDF-0007d0-Kd for qemu-devel@nongnu.org; Fri, 24 Feb 2017 03:26:49 -0500 References: <20170214133331.28997-1-lvivier@redhat.com> From: Laurent Vivier Message-ID: Date: Fri, 24 Feb 2017 09:26:44 +0100 MIME-Version: 1.0 In-Reply-To: <20170214133331.28997-1-lvivier@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vmstate-static-checker: update white list with spapr_pci List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: David Gibson , "Dr . David Alan Gilbert" , Thomas Huth , Greg Kurz , Alexey Kardashevskiy Ping? Laurent On 14/02/2017 14:33, Laurent Vivier wrote: > To fix migration between 2.7 and 2.8, some fields have > been renamed and managed with the help of a PHB property > (pre_2_8_migration): > > 5c4537b spapr: Fix 2.7<->2.8 migration of PCI host bridge > > So we need to add them to the white list: > > dma_liobn[0], > mem_win_addr, mem_win_size, > io_win_addr, io_win_size > > become > > mig_liobn, > mig_mem_win_addr, mig_mem_win_size, > mig_io_win_addr, mig_io_win_size > > CC: David Gibson > CC: Dr. David Alan Gilbert > CC: Thomas Huth > CC: Greg Kurz > CC: Alexey Kardashevskiy > Signed-off-by: Laurent Vivier > --- > scripts/vmstate-static-checker.py | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/scripts/vmstate-static-checker.py b/scripts/vmstate-static-checker.py > index 14a27e7..bcef7ee 100755 > --- a/scripts/vmstate-static-checker.py > +++ b/scripts/vmstate-static-checker.py > @@ -85,6 +85,11 @@ def check_fields_match(name, s_field, d_field): > 'xio3130-express-upstream-port': ['br.dev', 'parent_obj.parent_obj', > 'br.dev.exp.aer_log', > 'parent_obj.parent_obj.exp.aer_log'], > + 'spapr_pci': ['dma_liobn[0]', 'mig_liobn', > + 'mem_win_addr', 'mig_mem_win_addr', > + 'mem_win_size', 'mig_mem_win_size', > + 'io_win_addr', 'mig_io_win_addr', > + 'io_win_size', 'mig_io_win_size'], > } > > if not name in changed_names: >