From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] softmmu/vl: Be less verbose about missing KVM when running the qtests
Date: Mon, 27 Jul 2020 13:27:07 +0200 [thread overview]
Message-ID: <caf963db-26fb-e50a-3f82-e1b6a400813c@redhat.com> (raw)
In-Reply-To: <20200710085020.28222-1-thuth@redhat.com>
On 10/07/20 10:50, Thomas Huth wrote:
> Some of the qtests use "-accel kvm -accel tcg" to run real guest code.
> This causes some error messages when kvm is not available. We do not
> really care about these messages since the fallback to tcg is expected
> here. So let's silence them to avoid that they spoil the output of
> the tests.
>
> Unfortunately, we can not use the qtest_enabled() wrapper in this case,
> since the qtest accelerator itself is not initialized. Thus we have to
> test for the qtest_chrdev variable instead.
I wonder if "-accel kvm -accel tcg" should warn at all. I can
understand warning if we're running some /usr/bin/qemu-kvm binary, but
in this case the user has explicitly asked for a fallback.
Paolo
prev parent reply other threads:[~2020-07-27 11:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 8:50 [PATCH] softmmu/vl: Be less verbose about missing KVM when running the qtests Thomas Huth
2020-07-10 13:23 ` Alexander Bulekov
2020-07-27 11:27 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=caf963db-26fb-e50a-3f82-e1b6a400813c@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).