From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUysk-0001KC-VR for qemu-devel@nongnu.org; Wed, 03 Aug 2016 12:19:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUysg-0005kX-19 for qemu-devel@nongnu.org; Wed, 03 Aug 2016 12:18:58 -0400 References: <1470229005-152704-1-git-send-email-vsementsov@virtuozzo.com> <1470229005-152704-3-git-send-email-vsementsov@virtuozzo.com> <87d1lpdgi9.fsf@oc4731375738.ibm.com> From: Max Reitz Message-ID: Date: Wed, 3 Aug 2016 18:18:39 +0200 MIME-Version: 1.0 In-Reply-To: <87d1lpdgi9.fsf@oc4731375738.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="npdETGnX2lVViXj4Oi4BevJi5Hr7lgxuX" Subject: Re: [Qemu-devel] [PATCH 2/2] iotests: fix 109 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sascha Silbe , Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, jcody@redhat.com, stefanha@redhat.com, den@openvz.org, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --npdETGnX2lVViXj4Oi4BevJi5Hr7lgxuX From: Max Reitz To: Sascha Silbe , Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, jcody@redhat.com, stefanha@redhat.com, den@openvz.org, pbonzini@redhat.com Message-ID: Subject: Re: [Qemu-devel] [PATCH 2/2] iotests: fix 109 References: <1470229005-152704-1-git-send-email-vsementsov@virtuozzo.com> <1470229005-152704-3-git-send-email-vsementsov@virtuozzo.com> <87d1lpdgi9.fsf@oc4731375738.ibm.com> In-Reply-To: <87d1lpdgi9.fsf@oc4731375738.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03.08.2016 17:22, Sascha Silbe wrote: > Dear Vladimir, >=20 > Vladimir Sementsov-Ogievskiy writes: >=20 >> 109 iotest is broken for raw after 0965a41e998ab820b5 >> [mirror: double performance of the bulk stage if the disc is full] >> >> The problem is with finishing block-job with error: before specified >> patch mirror was not very async and it created one big request at disk= >> start, this request finished with error and qemu produced >> BLOCK_JOB_COMPLETED with zero progress. >> >> After 0965a41, mirror starts several smaller requests in parallel, whe= n >> BLOCK_JOB_COMPLETED emited we have some successful non-zero progress. > [...] >=20 >> --- a/tests/qemu-iotests/109.out >> +++ b/tests/qemu-iotests/109.out >> @@ -135,7 +135,7 @@ Automatically detecting the format is dangerous fo= r raw images, write operations >> Specify the 'raw' format explicitly to remove the restrictions. >> {"return": {}} >> {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "e= vent": "BLOCK_JOB_ERROR", "data": {"device": "src", "operation": "write",= "action": "report"}} >> -{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "e= vent": "BLOCK_JOB_COMPLETED", "data": {"device": "src", "len": 2560, "off= set": 0, "speed": 0, "type": "mirror", "error": "Operation not permitted"= }} >> +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "e= vent": "BLOCK_JOB_COMPLETED", "data": {"device": "src", "len": 2560, "off= set": OFFSET, "speed": 0, "type": "mirror", "error": "Operation not permi= tted"}} >=20 > What are the exact semantics of the "offset" field for > BLOCK_JOB_COMPLETED? >=20 > docs/qmp-events.txt is rather vague. As an API consumer I'd have assume= d > that everything up to offset has been completed successfully. If that > interpretation is correct, offset must be 0 for this test because the > very first sector wasn't mirrored successfully. As far as I'm aware, it doesn't have any real semantics besides the fact that $offset / $len is the progress of the block job; so it's the offset "in the job", but not the offset in the source disk. Max --npdETGnX2lVViXj4Oi4BevJi5Hr7lgxuX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEvBAEBCAAZBQJXohlgEhxtcmVpdHpAcmVkaGF0LmNvbQAKCRA7sUIC6DisrT+Y B/9cygoIlQyGbzaFd4MzA2eS0nV9m+xYxggbcxYpV4ZmahD0itHCAnBehadBKWUV q8LbvCFkH7G7uBasQezvUu5UfTWGiH+BlvtX8AOnwrmywimynf4v6ARnvTskqUC/ TTsh5s+RXBz3ZCdFKTSBSC6N3Rwcikv2zu9FiRhpJoESFQyJ49xpGOTcaeyl2R/a JKG6XYGQ9EYxLtnzSvBVDpnuLScfdb3Pa2tLxcdwirhW5SlC15qxseq8h8sX8rfd CLas7zrXrsigDh+Tf67swUUyNc1BgbDqE2H5cV41mtVgC8uUq8KDkHkedV7WLmo5 f/TBKOvpZEsY1o/f7VjkA5fk =+aiE -----END PGP SIGNATURE----- --npdETGnX2lVViXj4Oi4BevJi5Hr7lgxuX--